
This PR replaces the mixin `OpView` extension mechanism with the standard inheritance mechanism. Why? Firstly, mixins are not very pythonic (inheritance is usually used for this), a little convoluted, and too "tight" (can only be used in the immediately adjacent `_ext.py`). Secondly, it (mixins) are now blocking are correct implementation of "value builders" (see [here](https://github.com/llvm/llvm-project/pull/68764)) where the problem becomes how to choose the correct base class that the value builder should call. This PR looks big/complicated but appearances are deceiving; 4 things were needed to make this work: 1. Drop `skipDefaultBuilders` in `OpPythonBindingGen::emitDefaultOpBuilders` 2. Former mixin extension classes are converted to inherit from the generated `OpView` instead of being "mixins" a. extension classes that simply were calling into an already generated `super().__init__` continue to do so b. (almost all) extension classes that were calling `self.build_generic` because of a lack of default builder being generated can now also just call `super().__init__` 3. To handle the [lone single use-case](https://sourcegraph.com/search?q=context%3Aglobal+select_opview_mixin&patternType=standard&sm=1&groupBy=repo) of `select_opview_mixin`, namely [linalg](https://github.com/llvm/llvm-project/blob/main/mlir/python/mlir/dialects/_linalg_ops_ext.py#L38), only a small change was necessary in `opdsl/lang/emitter.py` (thanks to the emission/generation of default builders/`__init__`s) 4. since the `extend_opview_class` decorator is removed, we need a way to register extension classes as the desired `OpView` that `op.opview` conjures into existence; so we do the standard thing and just enable replacing the existing registered `OpView` i.e., `register_operation(_Dialect, replace=True)`. Note, the upgrade path for the common case is to change an extension to inherit from the generated builder and decorate it with `register_operation(_Dialect, replace=True)`. In the slightly more complicated case where `super().__init(self.build_generic(...))` is called in the extension's `__init__`, this needs to be updated to call `__init__` in `OpView`, i.e., the grandparent (see updated docs). Note, also `<DIALECT>_ext.py` files/modules will no longer be automatically loaded. Note, the PR has 3 base commits that look funny but this was done for the purpose of tracking the line history of moving the `<DIALECT>_ops_ext.py` class into `<DIALECT>.py` and updating (commit labeled "fix").
214 lines
7.2 KiB
C++
214 lines
7.2 KiB
C++
//===- IRModule.cpp - IR pybind module ------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "IRModule.h"
|
|
#include "Globals.h"
|
|
#include "PybindUtils.h"
|
|
|
|
#include <optional>
|
|
#include <vector>
|
|
|
|
#include "mlir-c/Bindings/Python/Interop.h"
|
|
#include "mlir-c/Support.h"
|
|
|
|
namespace py = pybind11;
|
|
using namespace mlir;
|
|
using namespace mlir::python;
|
|
|
|
// -----------------------------------------------------------------------------
|
|
// PyGlobals
|
|
// -----------------------------------------------------------------------------
|
|
|
|
PyGlobals *PyGlobals::instance = nullptr;
|
|
|
|
PyGlobals::PyGlobals() {
|
|
assert(!instance && "PyGlobals already constructed");
|
|
instance = this;
|
|
// The default search path include {mlir.}dialects, where {mlir.} is the
|
|
// package prefix configured at compile time.
|
|
dialectSearchPrefixes.emplace_back(MAKE_MLIR_PYTHON_QUALNAME("dialects"));
|
|
}
|
|
|
|
PyGlobals::~PyGlobals() { instance = nullptr; }
|
|
|
|
void PyGlobals::loadDialectModule(llvm::StringRef dialectNamespace) {
|
|
if (loadedDialectModulesCache.contains(dialectNamespace))
|
|
return;
|
|
// Since re-entrancy is possible, make a copy of the search prefixes.
|
|
std::vector<std::string> localSearchPrefixes = dialectSearchPrefixes;
|
|
py::object loaded;
|
|
for (std::string moduleName : localSearchPrefixes) {
|
|
moduleName.push_back('.');
|
|
moduleName.append(dialectNamespace.data(), dialectNamespace.size());
|
|
|
|
try {
|
|
loaded = py::module::import(moduleName.c_str());
|
|
} catch (py::error_already_set &e) {
|
|
if (e.matches(PyExc_ModuleNotFoundError)) {
|
|
continue;
|
|
}
|
|
throw;
|
|
}
|
|
break;
|
|
}
|
|
|
|
// Note: Iterator cannot be shared from prior to loading, since re-entrancy
|
|
// may have occurred, which may do anything.
|
|
loadedDialectModulesCache.insert(dialectNamespace);
|
|
}
|
|
|
|
void PyGlobals::registerAttributeBuilder(const std::string &attributeKind,
|
|
py::function pyFunc, bool replace) {
|
|
py::object &found = attributeBuilderMap[attributeKind];
|
|
if (found && !found.is_none() && !replace) {
|
|
throw std::runtime_error((llvm::Twine("Attribute builder for '") +
|
|
attributeKind +
|
|
"' is already registered with func: " +
|
|
py::str(found).operator std::string())
|
|
.str());
|
|
}
|
|
found = std::move(pyFunc);
|
|
}
|
|
|
|
void PyGlobals::registerTypeCaster(MlirTypeID mlirTypeID,
|
|
pybind11::function typeCaster,
|
|
bool replace) {
|
|
pybind11::object &found = typeCasterMap[mlirTypeID];
|
|
if (found && !found.is_none() && !replace)
|
|
throw std::runtime_error("Type caster is already registered");
|
|
found = std::move(typeCaster);
|
|
}
|
|
|
|
void PyGlobals::registerDialectImpl(const std::string &dialectNamespace,
|
|
py::object pyClass) {
|
|
py::object &found = dialectClassMap[dialectNamespace];
|
|
if (found) {
|
|
throw std::runtime_error((llvm::Twine("Dialect namespace '") +
|
|
dialectNamespace + "' is already registered.")
|
|
.str());
|
|
}
|
|
found = std::move(pyClass);
|
|
}
|
|
|
|
void PyGlobals::registerOperationImpl(const std::string &operationName,
|
|
py::object pyClass, bool replace) {
|
|
py::object &found = operationClassMap[operationName];
|
|
if (found && !replace) {
|
|
throw std::runtime_error((llvm::Twine("Operation '") + operationName +
|
|
"' is already registered.")
|
|
.str());
|
|
}
|
|
found = std::move(pyClass);
|
|
}
|
|
|
|
std::optional<py::function>
|
|
PyGlobals::lookupAttributeBuilder(const std::string &attributeKind) {
|
|
// Fast match against the class map first (common case).
|
|
const auto foundIt = attributeBuilderMap.find(attributeKind);
|
|
if (foundIt != attributeBuilderMap.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::function is defined");
|
|
return foundIt->second;
|
|
}
|
|
|
|
// Not found and loading did not yield a registration. Negative cache.
|
|
attributeBuilderMap[attributeKind] = py::none();
|
|
return std::nullopt;
|
|
}
|
|
|
|
std::optional<py::function> PyGlobals::lookupTypeCaster(MlirTypeID mlirTypeID,
|
|
MlirDialect dialect) {
|
|
{
|
|
// Fast match against the class map first (common case).
|
|
const auto foundIt = typeCasterMapCache.find(mlirTypeID);
|
|
if (foundIt != typeCasterMapCache.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::function is defined");
|
|
return foundIt->second;
|
|
}
|
|
}
|
|
|
|
// Not found. Load the dialect namespace.
|
|
loadDialectModule(unwrap(mlirDialectGetNamespace(dialect)));
|
|
|
|
// Attempt to find from the canonical map and cache.
|
|
{
|
|
const auto foundIt = typeCasterMap.find(mlirTypeID);
|
|
if (foundIt != typeCasterMap.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::object is defined");
|
|
// Positive cache.
|
|
typeCasterMapCache[mlirTypeID] = foundIt->second;
|
|
return foundIt->second;
|
|
}
|
|
// Negative cache.
|
|
typeCasterMap[mlirTypeID] = py::none();
|
|
return std::nullopt;
|
|
}
|
|
}
|
|
|
|
std::optional<py::object>
|
|
PyGlobals::lookupDialectClass(const std::string &dialectNamespace) {
|
|
loadDialectModule(dialectNamespace);
|
|
// Fast match against the class map first (common case).
|
|
const auto foundIt = dialectClassMap.find(dialectNamespace);
|
|
if (foundIt != dialectClassMap.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::object is defined");
|
|
return foundIt->second;
|
|
}
|
|
|
|
// Not found and loading did not yield a registration. Negative cache.
|
|
dialectClassMap[dialectNamespace] = py::none();
|
|
return std::nullopt;
|
|
}
|
|
|
|
std::optional<pybind11::object>
|
|
PyGlobals::lookupOperationClass(llvm::StringRef operationName) {
|
|
{
|
|
auto foundIt = operationClassMapCache.find(operationName);
|
|
if (foundIt != operationClassMapCache.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::object is defined");
|
|
return foundIt->second;
|
|
}
|
|
}
|
|
|
|
// Not found. Load the dialect namespace.
|
|
auto split = operationName.split('.');
|
|
llvm::StringRef dialectNamespace = split.first;
|
|
loadDialectModule(dialectNamespace);
|
|
|
|
// Attempt to find from the canonical map and cache.
|
|
{
|
|
auto foundIt = operationClassMap.find(operationName);
|
|
if (foundIt != operationClassMap.end()) {
|
|
if (foundIt->second.is_none())
|
|
return std::nullopt;
|
|
assert(foundIt->second && "py::object is defined");
|
|
// Positive cache.
|
|
operationClassMapCache[operationName] = foundIt->second;
|
|
return foundIt->second;
|
|
}
|
|
// Negative cache.
|
|
operationClassMap[operationName] = py::none();
|
|
return std::nullopt;
|
|
}
|
|
}
|
|
|
|
void PyGlobals::clearImportCache() {
|
|
loadedDialectModulesCache.clear();
|
|
operationClassMapCache.clear();
|
|
typeCasterMapCache.clear();
|
|
}
|