b5cd6e7b7e
ThreadList had an assignment operator that didn't lock the "rhs" thread list object. This means a thread list can be mutated while it is being copied. The copy constructor calls the assignment operator as well. So this fixes the unsafe threaded access to ThreadList which we believe is responsible for a lot of crashes. <rdar://problem/28075793> llvm-svn: 289100
61 lines
1.6 KiB
C++
61 lines
1.6 KiB
C++
//===-- ThreadCollection.h --------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef liblldb_ThreadCollection_h_
|
|
#define liblldb_ThreadCollection_h_
|
|
|
|
#include <mutex>
|
|
#include <vector>
|
|
|
|
#include "lldb/Utility/Iterable.h"
|
|
#include "lldb/lldb-private.h"
|
|
|
|
namespace lldb_private {
|
|
|
|
class ThreadCollection {
|
|
public:
|
|
typedef std::vector<lldb::ThreadSP> collection;
|
|
typedef LockingAdaptedIterable<collection, lldb::ThreadSP, vector_adapter,
|
|
std::recursive_mutex>
|
|
ThreadIterable;
|
|
|
|
ThreadCollection();
|
|
|
|
ThreadCollection(collection threads);
|
|
|
|
virtual ~ThreadCollection() {}
|
|
|
|
uint32_t GetSize();
|
|
|
|
void AddThread(const lldb::ThreadSP &thread_sp);
|
|
|
|
void AddThreadSortedByIndexID(const lldb::ThreadSP &thread_sp);
|
|
|
|
void InsertThread(const lldb::ThreadSP &thread_sp, uint32_t idx);
|
|
|
|
// Note that "idx" is not the same as the "thread_index". It is a zero
|
|
// based index to accessing the current threads, whereas "thread_index"
|
|
// is a unique index assigned
|
|
lldb::ThreadSP GetThreadAtIndex(uint32_t idx);
|
|
|
|
virtual ThreadIterable Threads() {
|
|
return ThreadIterable(m_threads, GetMutex());
|
|
}
|
|
|
|
virtual std::recursive_mutex &GetMutex() const { return m_mutex; }
|
|
|
|
protected:
|
|
collection m_threads;
|
|
mutable std::recursive_mutex m_mutex;
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif // liblldb_ThreadCollection_h_
|