a3d4f739ee
This patch should address a bug when a user have multiple scripted processes in the same debugging session. In order for the scripted process plugin to be able to call into the scripted object instance methods to fetch the necessary data to reconstruct its state, the scripted process plugin calls into a scripted process interface, that has a reference to the created script object instance. However, prior to this patch, we only had a single instance of the scripted process interface, living the script interpreter. So every time a new scripted process plugin was created, it would overwrite the script object instance that was held by the single scripted process interface in the script interpreter. That would cause all the method calls made to the scripted process interface to be dispatched by the last instanciated script object instance, which is wrong. In order to prevent that, this patch moves the scripted process interface reference to be help by the scripted process plugin itself. rdar://104882562 Differential Revision: https://reviews.llvm.org/D143308 Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
111 lines
3.1 KiB
C++
111 lines
3.1 KiB
C++
//===-- ScriptedProcess.h ------------------------------------- -*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_SCRIPTED_PROCESS_H
|
|
#define LLDB_SOURCE_PLUGINS_SCRIPTED_PROCESS_H
|
|
|
|
#include "lldb/Interpreter/ScriptedMetadata.h"
|
|
#include "lldb/Target/Process.h"
|
|
#include "lldb/Utility/ConstString.h"
|
|
#include "lldb/Utility/Status.h"
|
|
|
|
#include "ScriptedThread.h"
|
|
|
|
#include <mutex>
|
|
|
|
namespace lldb_private {
|
|
class ScriptedProcess : public Process {
|
|
public:
|
|
static lldb::ProcessSP CreateInstance(lldb::TargetSP target_sp,
|
|
lldb::ListenerSP listener_sp,
|
|
const FileSpec *crash_file_path,
|
|
bool can_connect);
|
|
|
|
static void Initialize();
|
|
|
|
static void Terminate();
|
|
|
|
static llvm::StringRef GetPluginNameStatic() { return "ScriptedProcess"; }
|
|
|
|
static llvm::StringRef GetPluginDescriptionStatic();
|
|
|
|
~ScriptedProcess() override;
|
|
|
|
bool CanDebug(lldb::TargetSP target_sp,
|
|
bool plugin_specified_by_name) override;
|
|
|
|
DynamicLoader *GetDynamicLoader() override { return nullptr; }
|
|
|
|
llvm::StringRef GetPluginName() override { return GetPluginNameStatic(); }
|
|
|
|
Status DoLoadCore() override;
|
|
|
|
Status DoLaunch(Module *exe_module, ProcessLaunchInfo &launch_info) override;
|
|
|
|
void DidLaunch() override;
|
|
|
|
Status DoResume() override;
|
|
|
|
Status DoDestroy() override;
|
|
|
|
void RefreshStateAfterStop() override;
|
|
|
|
bool IsAlive() override;
|
|
|
|
size_t DoReadMemory(lldb::addr_t addr, void *buf, size_t size,
|
|
Status &error) override;
|
|
|
|
ArchSpec GetArchitecture();
|
|
|
|
Status
|
|
GetMemoryRegions(lldb_private::MemoryRegionInfos ®ion_list) override;
|
|
|
|
bool GetProcessInfo(ProcessInstanceInfo &info) override;
|
|
|
|
lldb_private::StructuredData::ObjectSP
|
|
GetLoadedDynamicLibrariesInfos() override;
|
|
|
|
lldb_private::StructuredData::DictionarySP GetMetadata() override;
|
|
|
|
void UpdateQueueListIfNeeded() override;
|
|
|
|
void *GetImplementation() override;
|
|
|
|
protected:
|
|
ScriptedProcess(lldb::TargetSP target_sp, lldb::ListenerSP listener_sp,
|
|
const ScriptedMetadata &scripted_metadata, Status &error);
|
|
|
|
Status DoStop();
|
|
|
|
void Clear();
|
|
|
|
bool DoUpdateThreadList(ThreadList &old_thread_list,
|
|
ThreadList &new_thread_list) override;
|
|
|
|
Status DoGetMemoryRegionInfo(lldb::addr_t load_addr,
|
|
MemoryRegionInfo &range_info) override;
|
|
|
|
private:
|
|
friend class ScriptedThread;
|
|
|
|
inline void CheckScriptedInterface() const {
|
|
lldbassert(m_interface_up && "Invalid scripted process interface.");
|
|
}
|
|
|
|
ScriptedProcessInterface &GetInterface() const;
|
|
static bool IsScriptLanguageSupported(lldb::ScriptLanguage language);
|
|
|
|
// Member variables.
|
|
const ScriptedMetadata m_scripted_metadata;
|
|
lldb::ScriptedProcessInterfaceUP m_interface_up;
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif // LLDB_SOURCE_PLUGINS_SCRIPTED_PROCESS_H
|