llvm-project/lldb/tools/lldb-mi/MICmnLLDBProxySBValue.cpp
Jonas Devlieghere 8b3af63b89 [NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135
2019-04-10 20:48:55 +00:00

135 lines
4.5 KiB
C++

//===-- MICmnLLDBProxySBValue.cpp -------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include <stdlib.h>
// Third Party Headers:
#include "lldb/API/SBError.h"
// In-house headers:
#include "MICmnLLDBDebugSessionInfo.h"
#include "MICmnLLDBProxySBValue.h"
#include "MIUtilString.h"
//++
// Details: Retrieve the numerical value from the SBValue object. If the
// function fails
// it could indicate the SBValue object does not represent an internal
// type.
// Type: Static method.
// Args: vrValue - (R) The SBValue object to get a value from.
// vwValue - (W) The numerical value.
// Return: MIstatus::success - Functionality succeeded.
// MIstatus::failure - Functionality failed.
// Throws: None.
//--
bool CMICmnLLDBProxySBValue::GetValueAsUnsigned(const lldb::SBValue &vrValue,
MIuint64 &vwValue) {
lldb::SBValue &rValue = const_cast<lldb::SBValue &>(vrValue);
bool bCompositeType = true;
MIuint64 nFailValue = 0;
MIuint64 nValue = rValue.GetValueAsUnsigned(nFailValue);
if (nValue == nFailValue) {
nFailValue = 5; // Some arbitrary number
nValue = rValue.GetValueAsUnsigned(nFailValue);
if (nValue != nFailValue) {
bCompositeType = false;
vwValue = nValue;
}
} else {
bCompositeType = false;
vwValue = nValue;
}
return (bCompositeType ? MIstatus::failure : MIstatus::success);
}
//++
// Details: Retrieve the numerical value from the SBValue object. If the
// function fails
// it could indicate the SBValue object does not represent an internal
// type.
// Type: Static method.
// Args: vrValue - (R) The SBValue object to get a value from.
// vwValue - (W) The numerical value.
// Return: MIstatus::success - Functionality succeeded.
// MIstatus::failure - Functionality failed.
// Throws: None.
//--
bool CMICmnLLDBProxySBValue::GetValueAsSigned(const lldb::SBValue &vrValue,
MIint64 &vwValue) {
lldb::SBValue &rValue = const_cast<lldb::SBValue &>(vrValue);
bool bCompositeType = true;
MIuint64 nFailValue = 0;
MIuint64 nValue = rValue.GetValueAsSigned(nFailValue);
if (nValue == nFailValue) {
nFailValue = 5; // Some arbitrary number
nValue = rValue.GetValueAsSigned(nFailValue);
if (nValue != nFailValue) {
bCompositeType = false;
vwValue = nValue;
}
} else {
bCompositeType = false;
vwValue = nValue;
}
return (bCompositeType ? MIstatus::failure : MIstatus::success);
}
//++
// Details: Retrieve the NUL terminated string from the SBValue object if it of
// the type
// unsigned char *.
// Type: Static method.
// Args: vrValue - (R) The SBValue object to get a value from.
// vwCString - (W) The text data '\0' terminated.
// Return: MIstatus::success - Functionality succeeded.
// MIstatus::failure - Functionality failed, not suitable type.
// Throws: None.
//--
bool CMICmnLLDBProxySBValue::GetCString(const lldb::SBValue &vrValue,
CMIUtilString &vwCString) {
lldb::SBValue &rValue = const_cast<lldb::SBValue &>(vrValue);
const char *pCType = rValue.GetTypeName();
if (pCType == nullptr)
return MIstatus::failure;
const char *pType = "unsigned char *";
if (!CMIUtilString::Compare(pCType, pType))
return MIstatus::failure;
const CMIUtilString strAddr(rValue.GetValue());
MIint64 nNum = 0;
if (!strAddr.ExtractNumber(nNum))
return MIstatus::failure;
CMICmnLLDBDebugSessionInfo &rSessionInfo(
CMICmnLLDBDebugSessionInfo::Instance());
lldb::SBProcess sbProcess = rSessionInfo.GetProcess();
MIuint nBufferSize = 64;
bool bNeedResize = false;
char *pBuffer = static_cast<char *>(::malloc(nBufferSize));
do {
lldb::SBError error;
const size_t nReadSize = sbProcess.ReadCStringFromMemory(
(lldb::addr_t)nNum, pBuffer, nBufferSize, error);
if (nReadSize == (nBufferSize - 1)) {
bNeedResize = true;
nBufferSize = nBufferSize << 1;
pBuffer = static_cast<char *>(::realloc(pBuffer, nBufferSize));
} else
bNeedResize = false;
} while (bNeedResize);
vwCString = pBuffer;
free((void *)pBuffer);
return MIstatus::success;
}