A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
100 lines
2.7 KiB
C++
100 lines
2.7 KiB
C++
//===-- MIUtilMapIdToVariant.cpp --------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// In-house headers:
|
|
#include "MIUtilMapIdToVariant.h"
|
|
|
|
//++
|
|
// Details: CMIUtilMapIdToVariant constructor.
|
|
// Type: Method.
|
|
// Args: None.
|
|
// Return: None.
|
|
// Throws: None.
|
|
//--
|
|
CMIUtilMapIdToVariant::CMIUtilMapIdToVariant() {}
|
|
|
|
//++
|
|
// Details: CMIUtilMapIdToVariant destructor.
|
|
// Type: Method.
|
|
// Args: None.
|
|
// Return: None.
|
|
// Throws: None.
|
|
//--
|
|
CMIUtilMapIdToVariant::~CMIUtilMapIdToVariant() {}
|
|
|
|
//++
|
|
// Details: Remove at the data from *this container.
|
|
// Type: Method.
|
|
// Args: None.
|
|
// Return: None.
|
|
// Throws: None.
|
|
//--
|
|
void CMIUtilMapIdToVariant::Clear() { m_mapKeyToVariantValue.clear(); }
|
|
|
|
//++
|
|
// Details: Check an ID is present already in *this container.
|
|
// Type: Method.
|
|
// Args: vId - (R) Unique ID i.e. GUID.
|
|
// Return: True - registered.
|
|
// False - not found.
|
|
// Throws: None.
|
|
//--
|
|
bool CMIUtilMapIdToVariant::HaveAlready(const CMIUtilString &vId) const {
|
|
const MapKeyToVariantValue_t::const_iterator it =
|
|
m_mapKeyToVariantValue.find(vId);
|
|
return it != m_mapKeyToVariantValue.end();
|
|
}
|
|
|
|
//++
|
|
// Details: Determine if *this container is currently holding any data.
|
|
// Type: Method.
|
|
// Args: None.
|
|
// Return: bool - True - Yes empty, false - one or more data object present.
|
|
// Throws: None.
|
|
//--
|
|
bool CMIUtilMapIdToVariant::IsEmpty() const {
|
|
return m_mapKeyToVariantValue.empty();
|
|
}
|
|
|
|
//++
|
|
// Details: Check the ID is valid to be registered.
|
|
// Type: Method.
|
|
// Args: vId - (R) Unique ID i.e. GUID.
|
|
// Return: True - valid.
|
|
// False - not valid.
|
|
// Throws: None.
|
|
//--
|
|
bool CMIUtilMapIdToVariant::IsValid(const CMIUtilString &vId) const {
|
|
bool bValid = true;
|
|
|
|
if (vId.empty())
|
|
bValid = false;
|
|
|
|
return bValid;
|
|
}
|
|
|
|
//++
|
|
// Details: Remove from *this contain a data object specified by ID. The data
|
|
// object
|
|
// when removed also calls its destructor should it have one.
|
|
// Type: Method.
|
|
// Args: vId - (R) Unique ID i.e. GUID.
|
|
// Return: MIstatus::success - Functional succeeded.
|
|
// MIstatus::failure - Functional failed.
|
|
// Throws: None.
|
|
//--
|
|
bool CMIUtilMapIdToVariant::Remove(const CMIUtilString &vId) {
|
|
const MapKeyToVariantValue_t::const_iterator it =
|
|
m_mapKeyToVariantValue.find(vId);
|
|
if (it != m_mapKeyToVariantValue.end()) {
|
|
m_mapKeyToVariantValue.erase(it);
|
|
}
|
|
|
|
return MIstatus::success;
|
|
}
|