Eric Fiselier a9e659619f Implement N4606 optional
Summary:
Adapt implementation of Library Fundamentals TS optional into an implementation of N4606 optional.

  - Update relational operators per http://wg21.link/P0307
  - Update to requirements of http://wg21.link/P0032
  - Extension: Implement trivial copy/move construction/assignment for `optional<T>` when `T` is trivially copyable.

Audit P/Rs for optional LWG issues:
  - 2756 "C++ WP optional<T> should 'forward' T's implicit conversions" Implemented, which also resolves 2753 "Optional's constructors and assignments need constraints" (modulo my refusal to explicitly delete the move operations, which is a design error that I'm working on correcting in the 2756 P/R).
  - 2736 "nullopt_t insufficiently constrained" Already conforming. I've added a test ensuring that `nullopt_t` is not copy-initializable from an empty braced-init-list, which I believe is the root intent of the issue, to avoid regression.
  - 2740 "constexpr optional<T>::operator->" Already conforming.
  - 2746 "Inconsistency between requirements for emplace between optional and variant" No P/R, but note that the author's '"suggested resolution" is already implemented.
  - 2748 "swappable traits for optionals" Already conforming.
  - 2753 "Optional's constructors and assignments need constraints" Implemented.

Most of the work for this patch was done by Casey Carter @ Microsoft. Thank you Casey!



Reviewers: mclow.lists, CaseyCarter, EricWF

Differential Revision: https://reviews.llvm.org/D22741

llvm-svn: 283980
2016-10-12 07:46:20 +00:00

82 lines
2.2 KiB
C++

//===----------------------------------------------------------------------===//
//
// The LLVM Compiler Infrastructure
//
// This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11, c++14
// <optional>
// constexpr optional() noexcept;
#include <optional>
#include <type_traits>
#include <cassert>
#include "test_macros.h"
#include "archetypes.hpp"
using std::optional;
template <class Opt>
void
test_constexpr()
{
static_assert(std::is_nothrow_default_constructible<Opt>::value, "");
static_assert(std::is_trivially_destructible<Opt>::value, "");
static_assert(std::is_trivially_destructible<typename Opt::value_type>::value, "");
constexpr Opt opt;
static_assert(static_cast<bool>(opt) == false, "");
struct test_constexpr_ctor
: public Opt
{
constexpr test_constexpr_ctor() {}
};
}
template <class Opt>
void
test()
{
static_assert(std::is_nothrow_default_constructible<Opt>::value, "");
static_assert(!std::is_trivially_destructible<Opt>::value, "");
static_assert(!std::is_trivially_destructible<typename Opt::value_type>::value, "");
{
Opt opt;
assert(static_cast<bool>(opt) == false);
}
{
const Opt opt;
assert(static_cast<bool>(opt) == false);
}
struct test_constexpr_ctor
: public Opt
{
constexpr test_constexpr_ctor() {}
};
}
int main()
{
test_constexpr<optional<int>>();
test_constexpr<optional<int*>>();
test_constexpr<optional<ImplicitTypes::NoCtors>>();
test_constexpr<optional<NonTrivialTypes::NoCtors>>();
test_constexpr<optional<NonConstexprTypes::NoCtors>>();
test<optional<NonLiteralTypes::NoCtors>>();
// EXTENSIONS
#if defined(_LIBCPP_VERSION) && 0 // FIXME these extensions are currently disabled.
test_constexpr<optional<int&>>();
test_constexpr<optional<const int&>>();
test_constexpr<optional<int&>>();
test_constexpr<optional<NonLiteralTypes::NoCtors&>>();
test_constexpr<optional<NonLiteralTypes::NoCtors&&>>();
#endif
}