
The cleanup was manual, but assisted by "include-what-you-use". It consists in 1. Removing unused forward declaration. No impact expected. 2. Removing unused headers in .cpp files. No impact expected. 3. Removing unused headers in .h files. This removes implicit dependencies and is generally considered a good thing, but this may break downstream builds. I've updated llvm, clang, lld, lldb and mlir deps, and included a list of the modification in the second part of the commit. 4. Replacing header inclusion by forward declaration. This has the same impact as 3. Notable changes: - llvm/Support/TargetParser.h no longer includes llvm/Support/AArch64TargetParser.h nor llvm/Support/ARMTargetParser.h - llvm/Support/TypeSize.h no longer includes llvm/Support/WithColor.h - llvm/Support/YAMLTraits.h no longer includes llvm/Support/Regex.h - llvm/ADT/SmallVector.h no longer includes llvm/Support/MemAlloc.h nor llvm/Support/ErrorHandling.h You may need to add some of these headers in your compilation units, if needs be. As an hint to the impact of the cleanup, running clang++ -E -Iinclude -I../llvm/include ../llvm/lib/Support/*.cpp -std=c++14 -fno-rtti -fno-exceptions | wc -l before: 8000919 lines after: 7917500 lines Reduced dependencies also helps incremental rebuilds and is more ccache friendly, something not shown by the above metric :-) Discourse thread on the topic: https://llvm.discourse.group/t/include-what-you-use-include-cleanup/5831
56 lines
1.5 KiB
C++
56 lines
1.5 KiB
C++
#include "llvm/Support/ScopedPrinter.h"
|
|
|
|
#include "llvm/Support/Format.h"
|
|
|
|
using namespace llvm::support;
|
|
|
|
namespace llvm {
|
|
|
|
raw_ostream &operator<<(raw_ostream &OS, const HexNumber &Value) {
|
|
OS << "0x" << to_hexString(Value.Value);
|
|
return OS;
|
|
}
|
|
|
|
std::string to_hexString(uint64_t Value, bool UpperCase) {
|
|
std::string number;
|
|
llvm::raw_string_ostream stream(number);
|
|
stream << format_hex_no_prefix(Value, 1, UpperCase);
|
|
return stream.str();
|
|
}
|
|
|
|
void ScopedPrinter::printBinaryImpl(StringRef Label, StringRef Str,
|
|
ArrayRef<uint8_t> Data, bool Block,
|
|
uint32_t StartOffset) {
|
|
if (Data.size() > 16)
|
|
Block = true;
|
|
|
|
if (Block) {
|
|
startLine() << Label;
|
|
if (!Str.empty())
|
|
OS << ": " << Str;
|
|
OS << " (\n";
|
|
if (!Data.empty())
|
|
OS << format_bytes_with_ascii(Data, StartOffset, 16, 4,
|
|
(IndentLevel + 1) * 2, true)
|
|
<< "\n";
|
|
startLine() << ")\n";
|
|
} else {
|
|
startLine() << Label << ":";
|
|
if (!Str.empty())
|
|
OS << " " << Str;
|
|
OS << " (" << format_bytes(Data, None, Data.size(), 1, 0, true) << ")\n";
|
|
}
|
|
}
|
|
|
|
JSONScopedPrinter::JSONScopedPrinter(
|
|
raw_ostream &OS, bool PrettyPrint,
|
|
std::unique_ptr<DelimitedScope> &&OuterScope)
|
|
: ScopedPrinter(OS, ScopedPrinter::ScopedPrinterKind::JSON),
|
|
JOS(OS, /*Indent=*/PrettyPrint ? 2 : 0),
|
|
OuterScope(std::move(OuterScope)) {
|
|
if (this->OuterScope)
|
|
this->OuterScope->setPrinter(*this);
|
|
}
|
|
|
|
} // namespace llvm
|