ab2d3ce47d
Applied fixes enabled by the LLVM's .clang-tidy configs. Reverted files where
fixes introduced compile errors:
clang-tools-extra/clang-tidy/hicpp/NoAssemblerCheck.cpp
clang-tools-extra/clang-tidy/misc/ThrowByValueCatchByReferenceCheck.cpp
$ clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -fix clang-tools-extra/clang-tidy/
Enabled checks:
llvm-else-after-return
llvm-header-guard
llvm-include-order
llvm-namespace-comment
llvm-prefer-isa-or-dyn-cast-in-conditionals
llvm-prefer-register-over-unsigned
llvm-qualified-auto
llvm-twine-local
misc-definitions-in-headers
misc-misplaced-const
misc-new-delete-overloads
misc-no-recursion
misc-non-copyable-objects
misc-redundant-expression
misc-static-assert
misc-throw-by-value-catch-by-reference
misc-unconventional-assign-operator
misc-uniqueptr-reset-release
misc-unused-alias-decls
misc-unused-using-decls
readability-identifier-naming
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D95614
73 lines
2.7 KiB
C++
73 lines
2.7 KiB
C++
//===--- SimplifySubscriptExprCheck.cpp - clang-tidy-----------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "SimplifySubscriptExprCheck.h"
|
|
#include "../utils/OptionsUtils.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace readability {
|
|
|
|
static const char KDefaultTypes[] =
|
|
"::std::basic_string;::std::basic_string_view;::std::vector;::std::array";
|
|
|
|
SimplifySubscriptExprCheck::SimplifySubscriptExprCheck(
|
|
StringRef Name, ClangTidyContext *Context)
|
|
: ClangTidyCheck(Name, Context), Types(utils::options::parseStringList(
|
|
Options.get("Types", KDefaultTypes))) {
|
|
}
|
|
|
|
void SimplifySubscriptExprCheck::registerMatchers(MatchFinder *Finder) {
|
|
const auto TypesMatcher = hasUnqualifiedDesugaredType(
|
|
recordType(hasDeclaration(cxxRecordDecl(hasAnyName(
|
|
llvm::SmallVector<StringRef, 8>(Types.begin(), Types.end()))))));
|
|
|
|
Finder->addMatcher(
|
|
arraySubscriptExpr(hasBase(ignoringParenImpCasts(
|
|
cxxMemberCallExpr(
|
|
has(memberExpr().bind("member")),
|
|
on(hasType(qualType(
|
|
unless(anyOf(substTemplateTypeParmType(),
|
|
hasDescendant(substTemplateTypeParmType()))),
|
|
anyOf(TypesMatcher, pointerType(pointee(TypesMatcher)))))),
|
|
callee(namedDecl(hasName("data"))))
|
|
.bind("call")))),
|
|
this);
|
|
}
|
|
|
|
void SimplifySubscriptExprCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *Call = Result.Nodes.getNodeAs<CXXMemberCallExpr>("call");
|
|
if (Result.Context->getSourceManager().isMacroBodyExpansion(
|
|
Call->getExprLoc()))
|
|
return;
|
|
|
|
const auto *Member = Result.Nodes.getNodeAs<MemberExpr>("member");
|
|
auto DiagBuilder =
|
|
diag(Member->getMemberLoc(),
|
|
"accessing an element of the container does not require a call to "
|
|
"'data()'; did you mean to use 'operator[]'?");
|
|
if (Member->isArrow())
|
|
DiagBuilder << FixItHint::CreateInsertion(Member->getBeginLoc(), "(*")
|
|
<< FixItHint::CreateInsertion(Member->getOperatorLoc(), ")");
|
|
DiagBuilder << FixItHint::CreateRemoval(
|
|
{Member->getOperatorLoc(), Call->getEndLoc()});
|
|
}
|
|
|
|
void SimplifySubscriptExprCheck::storeOptions(
|
|
ClangTidyOptions::OptionMap &Opts) {
|
|
Options.store(Opts, "Types", utils::options::serializeStringList(Types));
|
|
}
|
|
|
|
} // namespace readability
|
|
} // namespace tidy
|
|
} // namespace clang
|