3da8e5f920
Summary: This is a general fix for the ConnectionFileDescriptor class but my main motivation was to make lldb-server working with IPv6. The connect URI can use square brackets ([]) to wrap the interface part of the URI (e.g.: <scheme>://[<interface>]:<port>). For IPv6 addresses this is a must since its ip can include colons and it will overlap with the port colon otherwise. The URIParser class parses the square brackets correctly but the ConnectionFileDescriptor doesn't generate them for IPv6 addresses making it impossible to connect to the gdb server when using this protocol. How to reproduce the issue: ``` $ lldb-server p --server --listen [::1]:8080 ... $ lldb (lldb) platform select remote-macosx (lldb) platform connect connect://[::1]:8080 (lldb) platform process -p <pid> error: unable to launch a GDB server on 'computer' ``` The server was actually launched we were just not able to connect to it. With this fix lldb will correctly connect. I fixed this by wrapping the ip portion with []. Reviewers: labath Reviewed By: labath Subscribers: xiaobai, mgorny, jfb, lldb-commits, labath Tags: #lldb Differential Revision: https://reviews.llvm.org/D61833 llvm-svn: 361898
47 lines
1.6 KiB
C++
47 lines
1.6 KiB
C++
//===--------------------- SocketTestUtilities.h ----------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_UNITTESTS_HOST_SOCKETTESTUTILITIES_H
|
|
#define LLDB_UNITTESTS_HOST_SOCKETTESTUTILITIES_H
|
|
|
|
#include <cstdio>
|
|
#include <functional>
|
|
#include <thread>
|
|
|
|
#include "lldb/Host/Config.h"
|
|
#include "lldb/Host/Socket.h"
|
|
#include "lldb/Host/common/TCPSocket.h"
|
|
#include "lldb/Host/common/UDPSocket.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/Path.h"
|
|
#include "llvm/Testing/Support/Error.h"
|
|
|
|
#ifndef LLDB_DISABLE_POSIX
|
|
#include "lldb/Host/posix/DomainSocket.h"
|
|
#endif
|
|
|
|
namespace lldb_private {
|
|
template <typename SocketType>
|
|
void CreateConnectedSockets(
|
|
llvm::StringRef listen_remote_address,
|
|
const std::function<std::string(const SocketType &)> &get_connect_addr,
|
|
std::unique_ptr<SocketType> *a_up, std::unique_ptr<SocketType> *b_up);
|
|
bool CreateTCPConnectedSockets(std::string listen_remote_ip,
|
|
std::unique_ptr<TCPSocket> *a_up,
|
|
std::unique_ptr<TCPSocket> *b_up);
|
|
#ifndef LLDB_DISABLE_POSIX
|
|
void CreateDomainConnectedSockets(llvm::StringRef path,
|
|
std::unique_ptr<DomainSocket> *a_up,
|
|
std::unique_ptr<DomainSocket> *b_up);
|
|
#endif
|
|
|
|
bool IsAddressFamilySupported(std::string ip);
|
|
bool IsIPv4(std::string ip);
|
|
} // namespace lldb_private
|
|
|
|
#endif |