Krzysztof Pszeniczny acaf403c63

[SampleProfile] Fix UB in Demangler invocation. (#137659) ...

Currently the backing buffer of a `std::vector<char>` is passed[1] to
`Demangler.getFunctionBaseName`. However, deeply inside the call stack
`OutputBuffer::grow` will call[2] `std::realloc` if it needs to grow the
buffer, leading to UB.

The demangler APIs specify[3] that "`Buf` and `N` behave like the second
and third parameters to `__cxa_demangle`" and the docs for the latter
say[4] that the output buffer must be allocated with `malloc` (but can
also be `NULL` and will then be realloced accordingly).

Note: PR #135863 changed this from a stack array to a `std::vector` and
increased the size to 65K, but this can still lead to a crash if the
demangled name is longer than that - yes, I'm surprised that a >65K-long
function name happens in practice...

[1]:
d7e631c7cd/llvm/lib/Transforms/IPO/SampleProfileMatcher.cpp (L744)
[2]:
d7e631c7cd/llvm/include/llvm/Demangle/Utility.h (L50)
[3]:
d7e631c7cd/llvm/include/llvm/Demangle/Demangle.h (L92-L93)
[4]:
https://gcc.gnu.org/onlinedocs/libstdc++/libstdc++-html-USERS-4.3/a01696.html

2025-04-28 19:28:56 +02:00

..

AlwaysInliner.cpp

[Analysis] Remove skipSCC (#127412)

2025-02-18 09:59:12 -08:00

Annotation2Metadata.cpp

[IPO] Remove unused includes (NFC) (#114716)

2024-11-03 13:48:55 -08:00

ArgumentPromotion.cpp

[llvm] Construct SmallVector with iterator ranges (NFC) (#136064)

2025-04-16 19:29:47 -07:00

Attributor.cpp

Attributor: Use use_empty instead of getNumUses == 0 (#136339)

2025-04-18 21:14:13 +02:00

AttributorAttributes.cpp

[llvm] Use llvm::interleaved (NFC) (#137496)

2025-04-26 23:28:46 -07:00

BarrierNoopPass.cpp

…

BlockExtractor.cpp

…

CalledValuePropagation.cpp

[NFC] Reapply 3f37c517f, SmallDenseMap speedups

2024-09-26 10:49:29 +01:00

CMakeLists.txt

[SampleFDO] Match functions with the same base function name (#126688)

2025-03-24 10:11:55 -07:00

ConstantMerge.cpp

[IR] Add getDataLayout() helpers to Function and GlobalValue (#96919)

2024-06-28 08:36:49 +02:00

CrossDSOCFI.cpp

[IRBuilder] Add new overload for CreateIntrinsic (#131942)

2025-03-31 08:10:34 -07:00

DeadArgumentElimination.cpp

[DeadArgElim] fix verifier failure when changing musttail's function signature (#127366)

2025-04-10 07:08:09 -07:00

ElimAvailExtern.cpp

[ctxprof] Only prune the profile in modules containing only context trees (#134340)

2025-04-07 19:52:03 -07:00

EmbedBitcodePass.cpp

[IPO] Remove unused includes (NFC) (#114716)

2024-11-03 13:48:55 -08:00

ExpandVariadics.cpp

[Transforms] Construct SmallVector with iterator ranges (NFC) (#136259)

2025-04-18 10:27:05 -07:00

ExtractGV.cpp

[Transforms] Use range constructors of *Set (NFC) (#133203)

2025-03-27 07:51:58 -07:00

FatLTOCleanup.cpp

[llvm][fatlto] Add FatLTOCleanup pass (#125911)

2025-02-13 11:39:02 -08:00

ForceFunctionAttrs.cpp

…

FunctionAttrs.cpp

[FunctionAttrs] Bail if initializes range overflows 64-bit signed int (#137053)

2025-04-23 15:56:24 -07:00

FunctionImport.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00

FunctionSpecialization.cpp

[CostModel] Remove optional from InstructionCost::getValue() (#135596)

2025-04-23 07:46:27 +01:00

GlobalDCE.cpp

[Transforms] Use *Set::insert_range (NFC) (#132056)

2025-03-19 15:35:01 -07:00

GlobalOpt.cpp

[GlobalOpt] Do not promote malloc if there are atomic loads/stores (#137158)

2025-04-24 15:15:47 +02:00

GlobalSplit.cpp

[IPO] Remove unused includes (NFC) (#114716)

2024-11-03 13:48:55 -08:00

HotColdSplitting.cpp

[NFC] Use the hasMinSize() instead of hasFnAttribute(Attribute::MinSize) (#135328)

2025-04-11 19:39:25 +08:00

InferFunctionAttrs.cpp

…

Inliner.cpp

Revert "[Analysis][EphemeralValuesAnalysis][NFCI] Remove EphemeralValuesCache class (#132454)"

2025-03-22 10:13:39 -07:00

Internalize.cpp

[IR] Store Triple in Module (NFC) (#129868)

2025-03-06 10:27:47 +01:00

IPO.cpp

[IPO] Remove unused includes (NFC) (#114716)

2024-11-03 13:48:55 -08:00

IROutliner.cpp

[llvm] Call hash_combine_range with ranges (NFC) (#136511)

2025-04-20 16:36:03 -07:00

LoopExtractor.cpp

[Transforms][NFC] Remove second CodeExtractor constructor

2024-08-14 09:50:15 +02:00

LowerTypeTests.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00

MemProfContextDisambiguation.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00

MergeFunctions.cpp

[MergeFunc] Fix crash caused by bitcasting ArrayType (#133259)

2025-04-04 10:16:40 +01:00

ModuleInliner.cpp

[ctxprof] Use isInSpecializedModule as criteria for using contextual profile (#134468)

2025-04-07 19:55:00 -07:00

OpenMPOpt.cpp

OpenMPOpt: Avoid using getNumUses (#136349)

2025-04-18 23:17:33 +02:00

PartialInlining.cpp

[CostModel] Remove optional from InstructionCost::getValue() (#135596)

2025-04-23 07:46:27 +01:00

SampleContextTracker.cpp

[IPO] Avoid repeated map lookups (NFC) (#132144)

2025-03-20 09:11:11 -07:00

SampleProfile.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00

SampleProfileMatcher.cpp

[SampleProfile] Fix UB in Demangler invocation. (#137659)

2025-04-28 19:28:56 +02:00

SampleProfileProbe.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00

SCCP.cpp

[IR][ModRef] Introduce errno memory location

2025-02-13 12:13:39 +01:00

StripDeadPrototypes.cpp

[IPO] Remove unused includes (NFC) (#114716)

2024-11-03 13:48:55 -08:00

StripSymbols.cpp

[llvm-extract] Delete dead CG Profile edges (#134940)

2025-04-09 10:36:12 -07:00

ThinLTOBitcodeWriter.cpp

ThinLTO: Add flag to print uselistorder in bitcode writer pass (#133230)

2025-04-14 20:34:02 +02:00

WholeProgramDevirt.cpp

Clean up external users of GlobalValue::getGUID(StringRef) (#129644)

2025-04-28 11:09:43 +10:00