shylie/llvm-project
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
llvm-project/clang/test/SemaOpenACC/loop-construct-collapse-clause.cpp
Erich Keane b0cfbfd74b
[OpenACC] Implement loop restrictions on for loops. (#115370) 
OpenACC restricts the contents of a 'for' loop affected by a 'loop'
construct without a 'seq'. The loop variable must be integer, pointer,
or random-access-iterator, it must monotonically increase/decrease, and
the trip count must be computable at runtime before the function.

This patch tries to implement some of these limitations to the best of
our ability, though it causes us to be perhaps overly restrictive at the
moment. I expect we'll revisit some of these rules/add additional
supported forms of loop-variable and 'monotonically increasing' here,
but the currently enforced rules are heavily inspired by the OMP
implementation here.
2024-11-08 05:49:45 -08:00

500 lines
16 KiB
C++
Raw Blame History

// RUN: %clang_cc1 %s -fopenacc -verify
void only_for_loops() {
// expected-error@+3{{OpenACC 'loop' construct can only be applied to a 'for' loop}}
// expected-note@+1{{'loop' construct is here}}
#pragma acc loop collapse(1)
while(true);
// expected-error@+3{{OpenACC 'loop' construct can only be applied to a 'for' loop}}
// expected-note@+1{{'loop' construct is here}}
#pragma acc loop collapse(1)
do{}while(true);
}
void only_one_on_loop() {
// expected-error@+2{{OpenACC 'collapse' clause cannot appear more than once on a 'loop' directive}}
// expected-note@+1{{previous clause is here}}
#pragma acc loop collapse(1) collapse(1)
for(unsigned i = 0; i < 5; ++i);
}
constexpr int three() { return 3; }
constexpr int one() { return 1; }
constexpr int neg() { return -1; }
constexpr int zero() { return 0; }
struct NotConstexpr {
constexpr NotConstexpr(){};
operator int(){ return 1; }
};
struct ConvertsNegative {
constexpr ConvertsNegative(){};
constexpr operator int(){ return -1; }
};
struct ConvertsOne{
constexpr ConvertsOne(){};
constexpr operator int(){ return 1; }
};
struct ConvertsThree{
constexpr ConvertsThree(){};
constexpr operator int(){ return 3; }
};
template <typename T, int Val>
void negative_constexpr_templ() {
// expected-error@+3 2{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to 0}}
// expected-note@#NCETN1{{in instantiation of function template specialization 'negative_constexpr_templ<int, -1>'}}
// expected-note@#NCET1{{in instantiation of function template specialization 'negative_constexpr_templ<int, 1>'}}
#pragma acc loop collapse(T{})
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to -1}}
#pragma acc loop collapse(Val)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
}
void negative_constexpr(int i) {
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
#pragma acc loop collapse(1)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to 0}}
#pragma acc loop collapse(0)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to -1}}
#pragma acc loop collapse(-1)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
#pragma acc loop collapse(one())
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to 0}}
#pragma acc loop collapse(zero())
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to -1}}
#pragma acc loop collapse(neg())
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a constant expression}}
#pragma acc loop collapse(NotConstexpr{})
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{OpenACC 'collapse' clause loop count must be a positive integer value, evaluated to -1}}
#pragma acc loop collapse(ConvertsNegative{})
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
#pragma acc loop collapse(ConvertsOne{})
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
negative_constexpr_templ<int, -1>(); // #NCETN1
negative_constexpr_templ<int, 1>(); // #NCET1
}
template<unsigned Val>
void depth_too_high_templ() {
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(Val)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
}
void depth_too_high() {
depth_too_high_templ<3>(); // expected-note{{in instantiation of function template specialization}}
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(three())
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(ConvertsThree{})
for(unsigned i = 0; i < 5; ++i)
for(unsigned j = 0; j < 5; ++j);
}
template<typename T, unsigned Three>
void not_single_loop_templ() {
T Arr[5];
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(auto x : Arr) {
for(auto y : Arr){
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(Three)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
#pragma acc loop collapse(Three)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k) {
do{}while(true);
}
}
}
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(Three)
for(auto x : Arr) {
for(auto y: Arr) {
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
#pragma acc loop collapse(Three)
for(auto x : Arr) {
for(auto y: Arr) {
for(auto z: Arr) {
do{}while(true);
}
}
}
}
void not_single_loop() {
not_single_loop_templ<int, 3>(); // expected-note{{in instantiation of function template}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k);
}
while(true); // expected-error{{while loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k);
}
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
while(true); // expected-error{{while loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
do{}while(true);
}
}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
while(true);
}
}
int Arr[5];
// expected-error@+2{{'collapse' clause specifies a loop count greater than the number of available loops}}
// expected-note@+1 2{{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(auto x : Arr) {
for(auto y : Arr){
do{}while(true); // expected-error{{do loop cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
}
}
// expected-note@+1 {{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k);
}
// expected-error@+1{{more than one for-loop in a loop associated with OpenACC 'loop' construct with a 'collapse' clause}}
for(unsigned k = 0; k < 5;++k);
}
// expected-note@+1 {{active 'collapse' clause defined here}}
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k);
// expected-error@+1{{more than one for-loop in a loop associated with OpenACC 'loop' construct with a 'collapse' clause}}
for(unsigned k = 0; k < 5;++k);
}
}
for(unsigned k = 0; k < 5;++k);
#pragma acc loop collapse(3)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
for(unsigned k = 0; k < 5;++k);
}
}
}
template<unsigned Two, unsigned Three>
void no_other_directives() {
#pragma acc loop collapse(Two)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {// last loop associated with the top level.
// expected-error@+1{{'collapse' clause specifies a loop count greater than the number of available loops}}
#pragma acc loop collapse(Three) // expected-note 2{{active 'collapse' clause defined here}}
for(unsigned k = 0; k < 6;++k) {
for(unsigned l = 0; l < 5; ++l) {
// expected-error@+1{{OpenACC 'serial' construct cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
#pragma acc serial
;
}
}
}
}
#pragma acc loop collapse(Two)// expected-note{{active 'collapse' clause defined here}}
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {// last loop associated with the top level.
#pragma acc loop collapse(Three)
for(unsigned k = 0; k < 6;++k) {
for(unsigned l = 0; l < 5; ++l) {
for(unsigned m = 0; m < 5; ++m);
}
}
}
// expected-error@+1{{OpenACC 'serial' construct cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
#pragma acc serial
;
}
}
void no_other_directives() {
no_other_directives<2,3>(); // expected-note{{in instantiation of function template specialization}}
// Ok, not inside the intervening list
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
#pragma acc data // expected-warning{{OpenACC construct 'data' not yet implemented}}
}
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
// expected-error@+1{{OpenACC 'data' construct cannot appear in intervening code of a 'loop' with a 'collapse' clause}}
#pragma acc data // expected-warning{{OpenACC construct 'data' not yet implemented}}
for(unsigned j = 0; j < 5; ++j) {
}
}
}
void call();
template<unsigned Two>
void intervening_without_force_templ() {
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
for(unsigned j = 0; j < 5; ++j);
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(Two)
for(unsigned i = 0; i < 5; ++i) {
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
for(unsigned j = 0; j < 5; ++j);
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
}
#pragma acc loop collapse(force:2)
for(unsigned i = 0; i < 5; ++i) {
call();
for(unsigned j = 0; j < 5; ++j);
}
#pragma acc loop collapse(force:Two)
for(unsigned i = 0; i < 5; ++i) {
call();
for(unsigned j = 0; j < 5; ++j);
}
#pragma acc loop collapse(force:2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
call();
}
#pragma acc loop collapse(force:Two)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
call();
}
#pragma acc loop collapse(Two)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
#pragma acc loop collapse(Two)
for(unsigned i = 0; i < 5; ++i) {
{
{
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
}
}
#pragma acc loop collapse(force:Two)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(Two)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
}
#pragma acc loop collapse(2)
// expected-error@+2{{OpenACC 'loop' construct must have a terminating condition}}
// expected-note@-2{{'loop' construct is here}}
for(int i = 0;;++i)
// expected-error@+2{{OpenACC 'loop' construct must have a terminating condition}}
// expected-note@-5{{'loop' construct is here}}
for(int j = 0;;++j)
for(;;);
}
void intervening_without_force() {
intervening_without_force_templ<2>(); // expected-note{{in instantiation of function template specialization}}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
for(unsigned j = 0; j < 5; ++j);
}
// expected-note@+1{{active 'collapse' clause defined here}}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
// expected-error@+1{{inner loops must be tightly nested inside a 'collapse' clause on a 'loop' construct}}
call();
}
// The below two are fine, as they use the 'force' tag.
#pragma acc loop collapse(force:2)
for(unsigned i = 0; i < 5; ++i) {
call();
for(unsigned j = 0; j < 5; ++j);
}
#pragma acc loop collapse(force:2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j);
call();
}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
#pragma acc loop collapse(2)
for(unsigned i = 0; i < 5; ++i) {
{
{
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
}
}
#pragma acc loop collapse(force:2)
for(unsigned i = 0; i < 5; ++i) {
for(unsigned j = 0; j < 5; ++j) {
call();
}
}
#pragma acc loop collapse(2)
// expected-error@+2{{OpenACC 'loop' construct must have a terminating condition}}
// expected-note@-2{{'loop' construct is here}}
for(int i = 0;;++i)
// expected-error@+2{{OpenACC 'loop' construct must have a terminating condition}}
// expected-note@-5{{'loop' construct is here}}
for(int j = 0;;++j)
for(;;);
}
Reference in New Issue View Git Blame Copy Permalink