b111da14ad
expression Clang emits invalid protocol metadata when a @protocol expression is used with a forward-declared protocol. The protocol metadata is missing protocol conformance list of the protocol since we don't have access to the definition of it in the compiled translation unit. The linker then might end up picking the invalid metadata when linking which will lead to incorrect runtime protocol conformance checks. This commit makes sure that Clang fails to compile code that uses a @protocol expression with a forward-declared protocol. This ensures that Clang does not emit invalid protocol metadata. I added an extra assert in CodeGen to ensure that this kind of issue won't happen in other places. rdar://32787811 Differential Revision: https://reviews.llvm.org/D49462 llvm-svn: 340102
59 lines
978 B
Objective-C
59 lines
978 B
Objective-C
// RUN: %clang_cc1 -emit-llvm-only %s
|
|
|
|
void p(const char*, ...);
|
|
|
|
@interface Root
|
|
+(int) maxValue;
|
|
-(int) conformsTo: (id) x;
|
|
@end
|
|
|
|
@protocol P0
|
|
@end
|
|
|
|
@protocol P1
|
|
+(void) classMethodReq0;
|
|
-(void) methodReq0;
|
|
@optional
|
|
+(void) classMethodOpt1;
|
|
-(void) methodOpt1;
|
|
@required
|
|
+(void) classMethodReq2;
|
|
-(void) methodReq2;
|
|
@end
|
|
|
|
@protocol P2
|
|
//@property(readwrite) int x;
|
|
@end
|
|
|
|
@protocol P3<P1, P2>
|
|
-(id <P1>) print0;
|
|
-(void) print1;
|
|
@end
|
|
|
|
void foo(const id a) {
|
|
void *p = @protocol(P3);
|
|
}
|
|
|
|
int main() {
|
|
Protocol *P0 = @protocol(P0);
|
|
Protocol *P1 = @protocol(P1);
|
|
Protocol *P2 = @protocol(P2);
|
|
Protocol *P3 = @protocol(P3);
|
|
|
|
#define Pbool(X) p(#X ": %s\n", X ? "yes" : "no");
|
|
Pbool([P0 conformsTo: P1]);
|
|
Pbool([P1 conformsTo: P0]);
|
|
Pbool([P1 conformsTo: P2]);
|
|
Pbool([P2 conformsTo: P1]);
|
|
Pbool([P3 conformsTo: P1]);
|
|
Pbool([P1 conformsTo: P3]);
|
|
|
|
return 0;
|
|
}
|
|
|
|
// rdar://problem/7992749
|
|
typedef Root<P1> P1Object;
|
|
int test10() {
|
|
return [P1Object maxValue];
|
|
}
|