ae7c944355
For example, given:
struct T1 {
struct T2 *p0;
};
-ast-print produced:
struct T1 {
struct T2;
struct T2 *p0;
};
Compiling that produces a warning that the first struct T2 declaration
does not declare anything.
Details:
A tag decl group is one or more decls that share a type specifier that
is a tag decl (that is, a struct/union/class/enum decl). Within
functions, the parser builds such a tag decl group as part of a
DeclStmt. However, in decl contexts, such as file scope or a member
list, the parser does not group together the members of a tag decl
group. Previously, detection of tag decl groups during printing was
implemented but only if the tag decl was unnamed. Otherwise, as in
the above example, the members of the group did not print together and
so sometimes introduced warnings.
This patch extends detection of tag decl groups in decl contexts to
any tag decl that is recorded in the AST as not free-standing.
Reviewed by: rsmith
Differential Revision: https://reviews.llvm.org/D45465
llvm-svn: 332314
106 lines
3.1 KiB
C
106 lines
3.1 KiB
C
// First check compiling and printing of this file.
|
|
//
|
|
// RUN: %clang_cc1 -verify -ast-print %s > %t.c
|
|
// RUN: FileCheck --check-prefixes=CHECK,PRINT %s --input-file %t.c
|
|
//
|
|
// Now check compiling and printing of the printed file.
|
|
//
|
|
// RUN: echo "// expected""-warning@* 6 {{'T' is deprecated}}" >> %t.c
|
|
// RUN: echo "// expected""-note@* 6 {{'T' has been explicitly marked deprecated here}}" >> %t.c
|
|
//
|
|
// RUN: %clang_cc1 -verify -ast-print %t.c \
|
|
// RUN: | FileCheck --check-prefixes=CHECK,PRINT %s
|
|
|
|
// END.
|
|
|
|
// CHECK-LABEL: defFirst
|
|
void defFirst() {
|
|
// PRINT-NEXT: enum
|
|
// PRINT-DAG: __attribute__((aligned(16)))
|
|
// PRINT-DAG: __attribute__((deprecated("")))
|
|
// PRINT-SAME: T {
|
|
// PRINT-NEXT: E0,
|
|
// PRINT-NEXT: E1
|
|
// PRINT-NEXT: } *p0;
|
|
// expected-warning@+2 {{'T' is deprecated}}
|
|
// expected-note@+1 2 {{'T' has been explicitly marked deprecated here}}
|
|
enum __attribute__((aligned(16))) __attribute__((deprecated(""))) T {
|
|
E0, E1
|
|
} *p0;
|
|
|
|
// PRINT-NEXT: enum T *p1;
|
|
enum T *p1; // expected-warning {{'T' is deprecated}}
|
|
}
|
|
|
|
// CHECK-LABEL: defLast
|
|
void defLast() {
|
|
// PRINT-NEXT: enum __attribute__((aligned(16))) T *p0;
|
|
enum __attribute__((aligned(16))) T *p0;
|
|
|
|
// PRINT-NEXT: enum __attribute__((deprecated(""))) T {
|
|
// PRINT-NEXT: E0,
|
|
// PRINT-NEXT: E1
|
|
// PRINT-NEXT: } *p1;
|
|
// expected-warning@+2 {{'T' is deprecated}}
|
|
// expected-note@+1 {{'T' has been explicitly marked deprecated here}}
|
|
enum __attribute__((deprecated(""))) T { E0, E1 } *p1;
|
|
}
|
|
|
|
// CHECK-LABEL: defMiddle
|
|
void defMiddle() {
|
|
// PRINT-NEXT: enum __attribute__((deprecated(""))) T *p0;
|
|
// expected-warning@+2 {{'T' is deprecated}}
|
|
// expected-note@+1 3 {{'T' has been explicitly marked deprecated here}}
|
|
enum __attribute__((deprecated(""))) T *p0;
|
|
|
|
// PRINT-NEXT: enum __attribute__((aligned(16))) T {
|
|
// PRINT-NEXT: E0
|
|
// PRINT-NEXT: E1
|
|
// PRINT-NEXT: } *p1;
|
|
enum __attribute__((aligned(16))) T { E0, E1 } *p1; // expected-warning {{'T' is deprecated}}
|
|
|
|
// PRINT-NEXT: enum T *p2;
|
|
enum T *p2; // expected-warning {{'T' is deprecated}}
|
|
}
|
|
|
|
// CHECK-LABEL: declsOnly
|
|
void declsOnly() {
|
|
// FIXME: For some reason, attributes are ignored if they're not on the first
|
|
// declaration and not on the definition.
|
|
|
|
// PRINT-NEXT: enum __attribute__((aligned)) T *p0;
|
|
enum __attribute__((aligned)) T *p0;
|
|
|
|
// PRINT-NEXT: enum T *p1;
|
|
enum __attribute__((may_alias)) T *p1;
|
|
|
|
// PRINT-NEXT: enum T *p2;
|
|
enum T *p2;
|
|
|
|
// PRINT-NEXT: enum T *p3;
|
|
enum __attribute__((deprecated(""))) T *p3;
|
|
|
|
// PRINT-NEXT: enum T *p4;
|
|
enum T *p4;
|
|
}
|
|
|
|
// Check that tag decl groups stay together in decl contexts.
|
|
|
|
// PRINT-LABEL: enum DeclGroupAtFileScope {
|
|
// PRINT-NEXT: DeclGroupAtFileScope0
|
|
// PRINT-NEXT: } *DeclGroupAtFileScopePtr;
|
|
enum DeclGroupAtFileScope { DeclGroupAtFileScope0 } *DeclGroupAtFileScopePtr;
|
|
|
|
// PRINT-LABEL: struct DeclGroupInMemberList
|
|
struct DeclGroupInMemberList {
|
|
// PRINT-NEXT: enum T1 {
|
|
// PRINT-NEXT: T10
|
|
// PRINT-NEXT: } *p0;
|
|
enum T1 { T10 } *p0;
|
|
// PRINT-NEXT: enum T2 {
|
|
// PRINT-NEXT: T20
|
|
// PRINT-NEXT: } *p1, *p2;
|
|
enum T2 { T20 } *p1, *p2;
|
|
// PRINT-NEXT: };
|
|
};
|