460ce58fa6
Previously, __weak was silently accepted and ignored in MRC mode. That makes this a potentially source-breaking change that we have to roll out cautiously. Accordingly, for the time being, actual support for __weak references in MRC is experimental, and the compiler will reject attempts to actually form such references. The intent is to eventually enable the feature by default in all non-GC modes. (It is, of course, incompatible with ObjC GC's interpretation of __weak.) If you like, you can enable this feature with -Xclang -fobjc-weak but like any -Xclang option, this option may be removed at any point, e.g. if/when it is eventually enabled by default. This patch also enables the use of the ARC __unsafe_unretained qualifier in MRC. Unlike __weak, this is being enabled immediately. Since variables are essentially __unsafe_unretained by default in MRC, the only practical uses are (1) communication and (2) changing the default behavior of by-value block capture. As an implementation matter, this means that the ObjC ownership qualifiers may appear in any ObjC language mode, and so this patch removes a number of checks for getLangOpts().ObjCAutoRefCount that were guarding the processing of these qualifiers. I don't expect this to be a significant drain on performance; it may even be faster to just check for these qualifiers directly on a type (since it's probably in a register anyway) than to do N dependent loads to grab the LangOptions. rdar://9674298 llvm-svn: 251041
31 lines
1.4 KiB
Objective-C
31 lines
1.4 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fsyntax-only -verify %s
|
|
static id __attribute((objc_gc(weak))) a;
|
|
static id __attribute((objc_gc(strong))) b;
|
|
|
|
static id __attribute((objc_gc())) c; // expected-error{{'objc_gc' attribute requires a string}}
|
|
static id __attribute((objc_gc(123))) d; // expected-error{{'objc_gc' attribute requires a string}}
|
|
static id __attribute((objc_gc(foo, 456))) e; // expected-error{{'objc_gc' attribute takes one argument}}
|
|
static id __attribute((objc_gc(hello))) f; // expected-warning{{'objc_gc' attribute argument not supported: 'hello'}}
|
|
|
|
static int __attribute__((objc_gc(weak))) g; // expected-warning {{'objc_gc' only applies to pointer types; type here is 'int'}}
|
|
|
|
static __weak int h; // expected-warning {{'__weak' only applies to Objective-C object or block pointer types; type here is 'int'}}
|
|
|
|
// TODO: it would be great if this reported as __weak
|
|
#define WEAK __weak
|
|
static WEAK int h; // expected-warning {{'objc_ownership' only applies to Objective-C object or block pointer types; type here is 'int'}}
|
|
|
|
/* expected-warning {{'__weak' only applies to Objective-C object or block pointer types; type here is 'int'}}*/ static __we\
|
|
ak int i;
|
|
|
|
// rdar://problem/9126213
|
|
void test2(id __attribute((objc_gc(strong))) *strong,
|
|
id __attribute((objc_gc(weak))) *weak) {
|
|
void *opaque;
|
|
opaque = strong;
|
|
strong = opaque;
|
|
|
|
opaque = weak;
|
|
weak = opaque;
|
|
}
|