c4a3395103
Summary:
I originally set out to move the NameMatches closer to the relevant
function and add some unit tests. However, in the process I've found a
couple of bugs in the implementation:
- the early exits where not always correct:
- (test==pattern) does not mean the match will always suceed because
of regular expressions
- pattern.empty() does not mean the match will fail because the "" is
a valid prefix of any string
So I cleaned up those and added some tests. The only tricky part here
was that regcomp() implementation on darwin did not recognise the empty
string as a regular expression and returned an REG_EMPTY error instead.
The simples fix here seemed to be to replace the empty expression with
an equivalent non-empty one.
Reviewers: clayborg, zturner
Subscribers: mgorny, lldb-commits
Differential Revision: https://reviews.llvm.org/D30094
llvm-svn: 295651
36 lines
1.0 KiB
C++
36 lines
1.0 KiB
C++
//===-- NameMatches.cpp -----------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
#include "lldb/Utility/NameMatches.h"
|
|
#include "lldb/Utility/RegularExpression.h"
|
|
|
|
#include "llvm/ADT/StringRef.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
bool lldb_private::NameMatches(llvm::StringRef name, NameMatch match_type,
|
|
llvm::StringRef match) {
|
|
switch (match_type) {
|
|
case NameMatch::Ignore:
|
|
return true;
|
|
case NameMatch::Equals:
|
|
return name == match;
|
|
case NameMatch::Contains:
|
|
return name.contains(match);
|
|
case NameMatch::StartsWith:
|
|
return name.startswith(match);
|
|
case NameMatch::EndsWith:
|
|
return name.endswith(match);
|
|
case NameMatch::RegularExpression: {
|
|
RegularExpression regex(match);
|
|
return regex.Execute(name);
|
|
}
|
|
}
|
|
return false;
|
|
}
|