a105877646
The idea behind this canonicalization is that it allows us to handle less patterns, because we know that some will be canonicalized away. This is indeed very useful to e.g. know that constants are always on the right. However, this is only useful if the canonicalization is actually reliable. This is the case for constants, but not for arguments: Moving these to the right makes it look like the "more complex" expression is guaranteed to be on the left, but this is not actually the case in practice. It fails as soon as you replace the argument with another instruction. The end result is that it looks like things correctly work in tests, while they actually don't. We use the "thwart complexity-based canonicalization" trick to handle this in tests, but it's often a challenge for new contributors to get this right, and based on the regressions this PR originally exposed, we clearly don't get this right in many cases. For this reason, I think that it's better to remove this complexity canonicalization. It will make it much easier to write tests for commuted cases and make sure that they are handled.
86 lines
3.6 KiB
C
86 lines
3.6 KiB
C
// RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X64,ALL
|
|
// RUN: %clang_cc1 -triple i386-pc-win32 -fms-extensions -emit-llvm -O2 < %s | FileCheck %s --check-prefixes=X86,ALL
|
|
|
|
struct Foo {
|
|
int * __ptr32 p32;
|
|
int * __ptr64 p64;
|
|
};
|
|
void use_foo(struct Foo *f);
|
|
void test_sign_ext(struct Foo *f, int * __ptr32 __sptr i) {
|
|
// X64-LABEL: define dso_local void @test_sign_ext({{.*}}ptr addrspace(270) noundef %i)
|
|
// X86-LABEL: define dso_local void @test_sign_ext(ptr noundef %f, ptr noundef %i)
|
|
// X64: %{{.+}} = addrspacecast ptr addrspace(270) %i to ptr
|
|
// X86: %{{.+}} = addrspacecast ptr %i to ptr addrspace(272)
|
|
f->p64 = i;
|
|
use_foo(f);
|
|
}
|
|
void test_zero_ext(struct Foo *f, int * __ptr32 __uptr i) {
|
|
// X64-LABEL: define dso_local void @test_zero_ext({{.*}}ptr addrspace(271) noundef %i)
|
|
// X86-LABEL: define dso_local void @test_zero_ext({{.*}}ptr addrspace(271) noundef %i)
|
|
// X64: %{{.+}} = addrspacecast ptr addrspace(271) %i to ptr
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(271) %i to ptr addrspace(272)
|
|
f->p64 = i;
|
|
use_foo(f);
|
|
}
|
|
void test_trunc(struct Foo *f, int * __ptr64 i) {
|
|
// X64-LABEL: define dso_local void @test_trunc(ptr noundef %f, ptr noundef %i)
|
|
// X86-LABEL: define dso_local void @test_trunc({{.*}}ptr addrspace(272) noundef %i)
|
|
// X64: %{{.+}} = addrspacecast ptr %i to ptr addrspace(270)
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(272) %i to ptr
|
|
f->p32 = i;
|
|
use_foo(f);
|
|
}
|
|
void test_noop(struct Foo *f, int * __ptr32 i) {
|
|
// X64-LABEL: define dso_local void @test_noop({{.*}}ptr addrspace(270) noundef %i)
|
|
// X86-LABEL: define dso_local void @test_noop({{.*}}ptr noundef %i)
|
|
// X64-NOT: addrspacecast
|
|
// X86-NOT: addrspacecast
|
|
f->p32 = i;
|
|
use_foo(f);
|
|
}
|
|
|
|
void test_other(struct Foo *f, __attribute__((address_space(10))) int *i) {
|
|
// X64-LABEL: define dso_local void @test_other({{.*}}ptr addrspace(10) noundef %i)
|
|
// X86-LABEL: define dso_local void @test_other({{.*}}ptr addrspace(10) noundef %i)
|
|
// X64: %{{.+}} = addrspacecast ptr addrspace(10) %i to ptr addrspace(270)
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(10) %i to ptr
|
|
f->p32 = (int * __ptr32)i;
|
|
use_foo(f);
|
|
}
|
|
|
|
int test_compare1(int *__ptr32 __uptr i, int *__ptr64 j) {
|
|
// ALL-LABEL: define dso_local range(i32 0, 2) i32 @test_compare1
|
|
// X64: %{{.+}} = addrspacecast ptr %j to ptr addrspace(271)
|
|
// X64: %cmp = icmp eq ptr addrspace(271) %i, %{{.+}}
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(272) %j to ptr addrspace(271)
|
|
// X86: %cmp = icmp eq ptr addrspace(271) %i, %{{.+}}
|
|
return (i == j);
|
|
}
|
|
|
|
int test_compare2(int *__ptr32 __sptr i, int *__ptr64 j) {
|
|
// ALL-LABEL: define dso_local range(i32 0, 2) i32 @test_compare2
|
|
// X64: %{{.+}} = addrspacecast ptr %j to ptr addrspace(270)
|
|
// X64: %cmp = icmp eq ptr addrspace(270) %i, %{{.+}}
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(272) %j to ptr
|
|
// X86: %cmp = icmp eq ptr %i, %{{.+}}
|
|
return (i == j);
|
|
}
|
|
|
|
int test_compare3(int *__ptr32 __uptr i, int *__ptr64 j) {
|
|
// ALL-LABEL: define dso_local range(i32 0, 2) i32 @test_compare3
|
|
// X64: %{{.+}} = addrspacecast ptr addrspace(271) %i to ptr
|
|
// X64: %cmp = icmp eq ptr %j, %{{.+}}
|
|
// X86: %{{.+}} = addrspacecast ptr addrspace(271) %i to ptr addrspace(272)
|
|
// X86: %cmp = icmp eq ptr addrspace(272) %j, %{{.+}}
|
|
return (j == i);
|
|
}
|
|
|
|
int test_compare4(int *__ptr32 __sptr i, int *__ptr64 j) {
|
|
// ALL-LABEL: define dso_local range(i32 0, 2) i32 @test_compare4
|
|
// X64: %{{.+}} = addrspacecast ptr addrspace(270) %i to ptr
|
|
// X64: %cmp = icmp eq ptr %j, %{{.+}}
|
|
// X86: %{{.+}} = addrspacecast ptr %i to ptr addrspace(272)
|
|
// X86: %cmp = icmp eq ptr addrspace(272) %j, %{{.+}}
|
|
return (j == i);
|
|
}
|