dfa7ff97b2
into the current module Following of https://github.com/llvm/llvm-project/pull/86912. After https://github.com/llvm/llvm-project/pull/86912, with reduced BMI, the BMI can keep unchange if the dependent modules only changes the implementation (without introduing new decls). However, this is not strictly correct. For example: ``` // a.cppm export module a; export inline int a() { ... } // b.cppm export module b; import a; export inline int b() { return a(); } ``` Since both `a()` and `b()` are inline, we need to make sure the BMI of `b.pcm` will change after the implementation of `a()` changes. We can't get that naturally since we won't record the body of `a()` during the writing process. We can't reuse ODRHash here since ODRHash won't calculate the called function recursively. So ODRHash will be problematic if `a()` calls other inline functions. Probably we can solve this by a new hash mechanism. But the safety and efficiency may a problem too. Here we just combine the hash value of the used modules conservatively.
95 lines
2.8 KiB
C++
95 lines
2.8 KiB
C++
// Test that, in C++20 modules reduced BMI, the implementation detail changes
|
|
// in non-inline function may not propagate while the inline function changes
|
|
// can get propagate.
|
|
//
|
|
// RUN: rm -rf %t
|
|
// RUN: split-file %s %t
|
|
// RUN: cd %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 %t/a.cppm -emit-reduced-module-interface -o %t/a.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/a.v1.cppm -emit-reduced-module-interface -o %t/a.v1.pcm
|
|
//
|
|
// The BMI of A should differ since the different implementation.
|
|
// RUN: not diff %t/a.pcm %t/a.v1.pcm &> /dev/null
|
|
//
|
|
// The BMI of B should change since the dependent inline function changes
|
|
// RUN: %clang_cc1 -std=c++20 %t/b.cppm -emit-reduced-module-interface -fmodule-file=a=%t/a.pcm \
|
|
// RUN: -o %t/b.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/b.cppm -emit-reduced-module-interface -fmodule-file=a=%t/a.v1.pcm \
|
|
// RUN: -o %t/b.v1.pcm
|
|
// RUN: not diff %t/b.v1.pcm %t/b.pcm &> /dev/null
|
|
//
|
|
// Test the case with unused partitions.
|
|
// RUN: %clang_cc1 -std=c++20 %t/M-A.cppm -emit-reduced-module-interface -o %t/M-A.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/M-B.cppm -emit-reduced-module-interface -o %t/M-B.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/M.cppm -emit-reduced-module-interface -o %t/M.pcm \
|
|
// RUN: -fmodule-file=M:partA=%t/M-A.pcm \
|
|
// RUN: -fmodule-file=M:partB=%t/M-B.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/N.cppm -emit-reduced-module-interface -o %t/N.pcm \
|
|
// RUN: -fmodule-file=M:partA=%t/M-A.pcm \
|
|
// RUN: -fmodule-file=M:partB=%t/M-B.pcm \
|
|
// RUN: -fmodule-file=M=%t/M.pcm
|
|
//
|
|
// Now we change `M-A.cppm` to `M-A.v1.cppm`.
|
|
// RUN: %clang_cc1 -std=c++20 %t/M-A.v1.cppm -emit-reduced-module-interface -o %t/M-A.v1.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/M.cppm -emit-reduced-module-interface -o %t/M.v1.pcm \
|
|
// RUN: -fmodule-file=M:partA=%t/M-A.v1.pcm \
|
|
// RUN: -fmodule-file=M:partB=%t/M-B.pcm
|
|
// RUN: %clang_cc1 -std=c++20 %t/N.cppm -emit-reduced-module-interface -o %t/N.v1.pcm \
|
|
// RUN: -fmodule-file=M:partA=%t/M-A.v1.pcm \
|
|
// RUN: -fmodule-file=M:partB=%t/M-B.pcm \
|
|
// RUN: -fmodule-file=M=%t/M.v1.pcm
|
|
//
|
|
// The BMI of N can keep unchanged since the N didn't use the changed partition unit 'M:A'.
|
|
// RUN: diff %t/N.v1.pcm %t/N.pcm &> /dev/null
|
|
|
|
//--- a.cppm
|
|
export module a;
|
|
export inline int a() {
|
|
return 48;
|
|
}
|
|
|
|
//--- a.v1.cppm
|
|
export module a;
|
|
export inline int a() {
|
|
return 50;
|
|
}
|
|
|
|
//--- b.cppm
|
|
export module b;
|
|
import a;
|
|
export inline int b() {
|
|
return a();
|
|
}
|
|
|
|
//--- M-A.cppm
|
|
export module M:partA;
|
|
export inline int a() {
|
|
return 43;
|
|
}
|
|
|
|
//--- M-A.v1.cppm
|
|
export module M:partA;
|
|
export inline int a() {
|
|
return 50;
|
|
}
|
|
|
|
//--- M-B.cppm
|
|
export module M:partB;
|
|
export inline int b() {
|
|
return 44;
|
|
}
|
|
|
|
//--- M.cppm
|
|
export module M;
|
|
export import :partA;
|
|
export import :partB;
|
|
|
|
//--- N.cppm
|
|
export module N;
|
|
import M;
|
|
|
|
export inline int n() {
|
|
return b();
|
|
}
|