3f6bc1adf8
Previously we disabled to compute ODR hash for declarations from the global module fragment. However, we missed the case that the functions lives in the concept requiments (see the attached the test files for example). And the mismatch causes the potential crashment. Due to we will set the function body as lazy after we deserialize it and we will only take its body when needed. However, we don't allow to take the body during deserializing. So it is actually potentially problematic if we set the body as lazy first and computing the hash value of the function, which requires to deserialize its body. So we will meet a crash here. This patch tries to solve the issue by not taking the body of the function from GMF. Note that we can't skip comparing the constraint expression from the GMF directly since it is an key part of the function selecting and it may be the reason why we can't return 0 directly for `FunctionDecl::getODRHash()` from the GMF.
68 lines
1.3 KiB
C++
68 lines
1.3 KiB
C++
// RUN: rm -rf %t
|
|
// RUN: mkdir -p %t
|
|
// RUN: split-file %s %t
|
|
//
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/A.cppm -emit-module-interface -o %t/A.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/B.cppm -emit-module-interface -o %t/B.pcm
|
|
// RUN: %clang_cc1 -std=c++20 -fskip-odr-check-in-gmf %t/test.cpp -fprebuilt-module-path=%t -fsyntax-only -verify
|
|
|
|
//--- header.h
|
|
#pragma once
|
|
template <class _Tp>
|
|
class Optional {};
|
|
|
|
template <class _Tp>
|
|
concept C = requires(const _Tp& __t) {
|
|
[]<class _Up>(const Optional<_Up>&) {}(__t);
|
|
};
|
|
|
|
//--- func.h
|
|
#include "header.h"
|
|
template <C T>
|
|
void func() {}
|
|
|
|
//--- duplicated_func.h
|
|
#include "header.h"
|
|
template <C T>
|
|
void duplicated_func() {}
|
|
|
|
//--- test_func.h
|
|
#include "func.h"
|
|
|
|
void test_func() {
|
|
func<Optional<int>>();
|
|
}
|
|
|
|
//--- test_duplicated_func.h
|
|
#include "duplicated_func.h"
|
|
|
|
void test_duplicated_func() {
|
|
duplicated_func<Optional<int>>();
|
|
}
|
|
|
|
//--- A.cppm
|
|
module;
|
|
#include "header.h"
|
|
#include "test_duplicated_func.h"
|
|
export module A;
|
|
export using ::test_duplicated_func;
|
|
|
|
//--- B.cppm
|
|
module;
|
|
#include "header.h"
|
|
#include "test_func.h"
|
|
#include "test_duplicated_func.h"
|
|
export module B;
|
|
export using ::test_func;
|
|
export using ::test_duplicated_func;
|
|
|
|
//--- test.cpp
|
|
// expected-no-diagnostics
|
|
import A;
|
|
import B;
|
|
|
|
void test() {
|
|
test_func();
|
|
test_duplicated_func();
|
|
}
|