87ce7b41d8
This is a follow-on to {D129556}. I've refactored the code such that
`addFile()` no longer needs to take an extra parameter. Additionally,
the "do we force-load or not" policy logic is now fully contained within
addFile, instead of being split between `addFile` and
`parseLCLinkerOptions`. This also allows us to move the `ForceLoad` (now
`LoadType`) enum out of the header file.
Additionally, we can now correctly report loads induced by
`LC_LINKER_OPTION` in our `-why_load` output.
I've also added another test to check that CLI library non-force-loads
take precedence over `LC_LINKER_OPTION` + `-force_load_swift_libs`. (The
existing logic is correct, just untested.)
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D130137
53 lines
2.1 KiB
LLVM
53 lines
2.1 KiB
LLVM
; REQUIRES: x86
|
|
; RUN: rm -rf %t; split-file %s %t
|
|
|
|
; RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/swift-foo.s -o %t/swift-foo.o
|
|
; RUN: llvm-ar rcs %t/libswiftFoo.a %t/swift-foo.o
|
|
; RUN: llvm-as %t/lc-linker-opt.ll -o %t/lc-linker-opt.o
|
|
; RUN: llvm-as %t/no-lc-linker-opt.ll -o %t/no-lc-linker-opt.o
|
|
|
|
; RUN: %lld -lSystem -force_load_swift_libs -L%t %t/lc-linker-opt.o -o \
|
|
; RUN: %t/lc-linker-opt -why_load 2>&1 | FileCheck %s --check-prefix=WHY-LOAD
|
|
; RUN: llvm-objdump --macho --syms %t/lc-linker-opt | FileCheck %s --check-prefix=HAS-SWIFT
|
|
|
|
; RUN: %lld -lSystem -L%t %t/lc-linker-opt.o -o %t/lc-linker-opt-no-force
|
|
; RUN: llvm-objdump --macho --syms %t/lc-linker-opt-no-force | FileCheck %s --check-prefix=NO-SWIFT
|
|
|
|
;; Swift libraries passed on the CLI don't get force-loaded!
|
|
; RUN: %lld -lSystem -force_load_swift_libs -lswiftFoo -L%t %t/no-lc-linker-opt.o -o %t/no-lc-linker-opt
|
|
; RUN: llvm-objdump --macho --syms %t/no-lc-linker-opt | FileCheck %s --check-prefix=NO-SWIFT
|
|
|
|
;; Moreover, if a Swift library is passed on the CLI, that supersedes any
|
|
;; LC_LINKER_OPTIONs that reference it.
|
|
; RUN: %lld -lSystem -force_load_swift_libs -lswiftFoo -L%t %t/lc-linker-opt.o -o %t/both-cli-and-lc-linker-opt
|
|
; RUN: llvm-objdump --macho --syms %t/both-cli-and-lc-linker-opt | FileCheck %s --check-prefix=NO-SWIFT
|
|
; RUN: %lld -lSystem -force_load_swift_libs -L%t %t/lc-linker-opt.o -lswiftFoo -o %t/both-cli-and-lc-linker-opt
|
|
; RUN: llvm-objdump --macho --syms %t/both-cli-and-lc-linker-opt | FileCheck %s --check-prefix=NO-SWIFT
|
|
|
|
; WHY-LOAD: LC_LINKER_OPTION forced load of {{.*}}libswiftFoo.a(swift-foo.o)
|
|
; HAS-SWIFT: _swift_foo
|
|
; NO-SWIFT-NOT: _swift_foo
|
|
|
|
;--- lc-linker-opt.ll
|
|
target triple = "x86_64-apple-macosx10.15.0"
|
|
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
!0 = !{!"-lswiftFoo"}
|
|
!llvm.linker.options = !{!0}
|
|
|
|
define void @main() {
|
|
ret void
|
|
}
|
|
|
|
;--- no-lc-linker-opt.ll
|
|
target triple = "x86_64-apple-macosx10.15.0"
|
|
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
define void @main() {
|
|
ret void
|
|
}
|
|
|
|
;--- swift-foo.s
|
|
.globl _swift_foo
|
|
_swift_foo:
|