llvm-project/lld/test/ELF/wrap-dynamic-undef.s
Fangrui Song 7c74ce3c68 [ELF] --wrap: don't clear sym->isUsedInRegularObj if real->isUsedInRegularObj; set wrap's initial binding to sym's
Fix PR49897: if `__real_foo` has the isUsedInRegularObj bit set, we need to
retain `foo` in .symtab, even if `foo` is undefined. The new behavior will match
GNU ld.

Before the patch, we produced an R_X86_64_JUMP_SLOT relocation referencing the
index 0 undefined symbol, which would be erroed by glibc
(see f96ff3c0f8ebd941b3f6b345164c3d858b781484).

While here, fix another bug: if `__wrap_foo` does not exist, its initial binding
should be `foo`'s.
2021-04-17 00:29:51 -07:00

42 lines
1.1 KiB
ArmAsm

# REQUIRES: x86
# RUN: split-file %s %t
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/a.s -o %t/a.o
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/def.s -o %t/def.o
# RUN: ld.lld %t/def.o -o %t/def.so -shared --soname=def
# RUN: ld.lld %t/a.o %t/def.so -o %t1 --wrap foo
# RUN: llvm-readelf --dyn-syms %t1 | FileCheck %s
# Test that the dynamic relocation uses foo. We used to produce a
# relocation with __real_foo.
# CHECK: Symbol table '.dynsym' contains 2 entries:
# CHECK: NOTYPE LOCAL DEFAULT UND
# CHECK-NEXT: NOTYPE GLOBAL DEFAULT UND foo
# RUN: llvm-mc -filetype=obj -triple=x86_64 %t/b.s -o %t/b.o
# RUN: ld.lld -shared --wrap foo %t/b.o -o %t2.so
# RUN: llvm-readelf --dyn-syms %t2.so | FileCheck %s --check-prefix=SYM2
# SYM2: Symbol table '.dynsym' contains 4 entries:
# SYM2: NOTYPE LOCAL DEFAULT UND
# SYM2-NEXT: NOTYPE WEAK DEFAULT UND foo
# SYM2-NEXT: NOTYPE WEAK DEFAULT UND __wrap_foo
# SYM2-NEXT: NOTYPE GLOBAL DEFAULT [[#]] _start
#--- a.s
.global _start
_start:
callq __real_foo@plt
#--- def.s
.globl foo
foo:
#--- b.s
.weak foo
.weak __real_foo
.global _start
_start:
call __real_foo@plt
call foo@plt