1f67508b7f
We want to trust user type annotations and stop assuming pointers declared as nonnull still can be null. This functionality is implemented as part of NonNullParamChecker because it already checks parameter attributes. Whenever we start analyzing a new function, we assume that all parameters with 'nonnull' attribute are indeed non-null. Patch by Valeriy Savchenko! Differential Revision: https://reviews.llvm.org/D77806
85 lines
2.8 KiB
Objective-C
85 lines
2.8 KiB
Objective-C
// RUN: %clang_analyze_cc1 -verify -Wno-objc-root-class %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=nullability \
|
|
// RUN: -analyzer-checker=osx.cocoa.NSError \
|
|
// RUN: -analyzer-checker=osx.coreFoundation.CFError
|
|
|
|
typedef signed char BOOL;
|
|
typedef int NSInteger;
|
|
typedef struct _NSZone NSZone;
|
|
@class NSInvocation, NSMethodSignature, NSCoder, NSString, NSEnumerator;
|
|
@protocol NSObject - (BOOL)isEqual:(id)object; @end
|
|
@protocol NSCopying - (id)copyWithZone:(NSZone *)zone; @end
|
|
@protocol NSCoding - (void)encodeWithCoder:(NSCoder *)aCoder; @end
|
|
@interface NSObject <NSObject> {} @end
|
|
@class NSDictionary;
|
|
@interface NSError : NSObject <NSCopying, NSCoding> {}
|
|
+ (id)errorWithDomain:(NSString *)domain code:(NSInteger)code userInfo:(NSDictionary *)dict;
|
|
@end
|
|
extern NSString * const NSXMLParserErrorDomain ;
|
|
|
|
@interface A
|
|
- (void)myMethodWhichMayFail:(NSError **)error;
|
|
- (BOOL)myMethodWhichMayFail2:(NSError **)error;
|
|
- (BOOL)myMethodWhichMayFail3:(NSError **_Nonnull)error;
|
|
- (BOOL)myMethodWhichMayFail4:(NSError **)error __attribute__((nonnull));
|
|
@end
|
|
|
|
@implementation A
|
|
- (void)myMethodWhichMayFail:(NSError **)error { // expected-warning {{Method accepting NSError** should have a non-void return value to indicate whether or not an error occurred}}
|
|
*error = [NSError errorWithDomain:@"domain" code:1 userInfo:0]; // expected-warning {{Potential null dereference}}
|
|
}
|
|
|
|
- (BOOL)myMethodWhichMayFail2:(NSError **)error { // no-warning
|
|
if (error) *error = [NSError errorWithDomain:@"domain" code:1 userInfo:0]; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
- (BOOL)myMethodWhichMayFail3:(NSError **_Nonnull)error { // no-warning
|
|
*error = [NSError errorWithDomain:@"domain" code:1 userInfo:0]; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
- (BOOL)myMethodWhichMayFail4:(NSError **)error { // no-warning
|
|
*error = [NSError errorWithDomain:@"domain" code:1 userInfo:0]; // no-warning
|
|
return 0;
|
|
}
|
|
@end
|
|
|
|
struct __CFError {};
|
|
typedef struct __CFError* CFErrorRef;
|
|
|
|
void foo(CFErrorRef* error) { // expected-warning {{Function accepting CFErrorRef* should have a non-void return value to indicate whether or not an error occurred}}
|
|
*error = 0; // expected-warning {{Potential null dereference}}
|
|
}
|
|
|
|
int f1(CFErrorRef* error) {
|
|
if (error) *error = 0; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
int f2(CFErrorRef* error) {
|
|
if (0 != error) *error = 0; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
int f3(CFErrorRef* error) {
|
|
if (error != 0) *error = 0; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
int __attribute__((nonnull)) f4(CFErrorRef *error) {
|
|
*error = 0; // no-warning
|
|
return 0;
|
|
}
|
|
|
|
int __attribute__((nonnull(1))) f5(int *x, CFErrorRef *error) {
|
|
*error = 0; // expected-warning {{Potential null dereference}}
|
|
return 0;
|
|
}
|
|
|
|
int __attribute__((nonnull(2))) f6(int *x, CFErrorRef *error) {
|
|
*error = 0; // no-warning
|
|
return 0;
|
|
}
|