223b824022
Motivation:
```
int foo(int x, int y) { // any compiler will happily inline this function
return x / y;
}
int test(int x, int y) {
int r = 0;
[[clang::noinline]] r += foo(x, y); // for some reason we don't want any inlining here
return r;
}
```
In 2018, @kuhar proposed "Introduce per-callsite inline intrinsics" in https://reviews.llvm.org/D51200 to solve this motivation case (and many others).
This patch solves this problem with call site attribute. The implementation is "smaller" wrt approach which uses new intrinsics and thanks to https://reviews.llvm.org/D79121 (Add nomerge statement attribute to clang), we have got some basic infrastructure to deal with attrs on statements with call expressions.
GCC devs are more inclined to call attribute solution as well, as builtins are problematic for them - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104187. But they have no patch proposal yet so.. We have free hands here.
If this approach makes sense, next future steps would be support for call site attributes for always_inline / flatten.
Reviewed By: aaron.ballman, kuhar
Differential Revision: https://reviews.llvm.org/D119061
56 lines
1.9 KiB
C++
56 lines
1.9 KiB
C++
// RUN: %clang_cc1 -S -emit-llvm %s -triple x86_64-unknown-linux-gnu -o - | FileCheck %s
|
|
|
|
bool bar();
|
|
void f(bool, bool);
|
|
void g(bool);
|
|
|
|
static int baz(int x) {
|
|
return x * 10;
|
|
}
|
|
|
|
[[clang::noinline]] bool noi() { }
|
|
|
|
void foo(int i) {
|
|
[[clang::noinline]] bar();
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR:[0-9]+]]
|
|
[[clang::noinline]] i = baz(i);
|
|
// CHECK: call noundef i32 @_ZL3bazi({{.*}}) #[[NOINLINEATTR]]
|
|
[[clang::noinline]] (i = 4, bar());
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
[[clang::noinline]] (void)(bar());
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
[[clang::noinline]] f(bar(), bar());
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
// CHECK: call void @_Z1fbb({{.*}}) #[[NOINLINEATTR]]
|
|
[[clang::noinline]] [] { bar(); bar(); }(); // noinline only applies to the anonymous function call
|
|
// CHECK: call void @"_ZZ3fooiENK3$_0clEv"(%class.anon* {{[^,]*}} %ref.tmp) #[[NOINLINEATTR]]
|
|
[[clang::noinline]] for (bar(); bar(); bar()) {}
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
// CHECK: call noundef zeroext i1 @_Z3barv() #[[NOINLINEATTR]]
|
|
bar();
|
|
// CHECK: call noundef zeroext i1 @_Z3barv()
|
|
[[clang::noinline]] noi();
|
|
// CHECK: call noundef zeroext i1 @_Z3noiv()
|
|
noi();
|
|
// CHECK: call noundef zeroext i1 @_Z3noiv()
|
|
[[gnu::noinline]] bar();
|
|
// CHECK: call noundef zeroext i1 @_Z3barv()
|
|
}
|
|
|
|
struct S {
|
|
friend bool operator==(const S &LHS, const S &RHS);
|
|
};
|
|
|
|
void func(const S &s1, const S &s2) {
|
|
[[clang::noinline]]g(s1 == s2);
|
|
// CHECK: call noundef zeroext i1 @_ZeqRK1SS1_({{.*}}) #[[NOINLINEATTR]]
|
|
// CHECK: call void @_Z1gb({{.*}}) #[[NOINLINEATTR]]
|
|
bool b;
|
|
[[clang::noinline]] b = s1 == s2;
|
|
// CHECK: call noundef zeroext i1 @_ZeqRK1SS1_({{.*}}) #[[NOINLINEATTR]]
|
|
}
|
|
|
|
// CHECK: attributes #[[NOINLINEATTR]] = { noinline }
|