Now in libcxx and clang, all the coroutine components are defined in std::experimental namespace. And now the coroutine TS is merged into C++20. So in the working draft like N4892, we could find the coroutine components is defined in std namespace instead of std::experimental namespace. And the coroutine support in clang seems to be relatively stable. So I think it may be suitable to move the coroutine component into the experiment namespace now. This patch would make clang lookup coroutine_traits in std namespace first. For the compatibility consideration, clang would lookup in std::experimental namespace if it can't find definitions in std namespace. So the existing codes wouldn't be break after update compiler. And in case the compiler found std::coroutine_traits and std::experimental::coroutine_traits at the same time, it would emit an error for it. The support for looking up std::experimental::coroutine_traits would be removed in Clang16. Reviewed By: lxfind, Quuxplusone Differential Revision: https://reviews.llvm.org/D108696
44 lines
1.4 KiB
C++
44 lines
1.4 KiB
C++
// Tests that coroutine passes are added to and run by the new pass manager
|
|
// pipeline, at -O0 and above.
|
|
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -o /dev/null \
|
|
// RUN: -fexperimental-new-pass-manager -fdebug-pass-manager -std=c++20 \
|
|
// RUN: -O0 %s 2>&1 | FileCheck %s --check-prefixes=CHECK-ALL
|
|
// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -o /dev/null \
|
|
// RUN: -fexperimental-new-pass-manager -fdebug-pass-manager -std=c++20 \
|
|
// RUN: -O1 %s 2>&1 | FileCheck %s --check-prefixes=CHECK-ALL,CHECK-OPT
|
|
//
|
|
// CHECK-ALL: Running pass:{{.*}}CoroEarlyPass
|
|
//
|
|
// CHECK-ALL: Running pass: CoroSplitPass on (_Z3foov)
|
|
// CHECK-OPT: Running pass:{{.*}}CoroElidePass{{.*}} on {{.*}}_Z3foov{{.*}}
|
|
//
|
|
// CHECK-ALL: Running pass:{{.*}}CoroCleanupPass
|
|
|
|
namespace std {
|
|
|
|
struct handle {};
|
|
|
|
struct awaitable {
|
|
bool await_ready() noexcept { return false; }
|
|
void await_suspend(handle) noexcept {}
|
|
bool await_resume() noexcept { return true; }
|
|
};
|
|
|
|
template <typename T> struct coroutine_handle {
|
|
static handle from_address(void *address) noexcept { return {}; }
|
|
};
|
|
|
|
template <typename T = void> struct coroutine_traits {
|
|
struct promise_type {
|
|
awaitable initial_suspend() { return {}; }
|
|
awaitable final_suspend() noexcept { return {}; }
|
|
void return_void() {}
|
|
T get_return_object() { return T(); }
|
|
void unhandled_exception() {}
|
|
};
|
|
};
|
|
} // namespace std
|
|
|
|
void foo() { co_return; }
|