ecb502342c
We currently emit the selector load early, but only because we need it to compute the signature (so that we know which msgSend variant to call). We can prepare the signature with a plain undef, and replace it with the materialized selector value if (and only if) needed, later. Concretely, this usually doesn't have an effect, but tests need updating because we reordered the receiver bitcast and the selector load, which is always fine. There is one notable change: with this, when a msgSend needs a receiver null check, the selector is now loaded in the non-null block, instead of before the null check. That should be a mild improvement.
155 lines
6.1 KiB
Objective-C
155 lines
6.1 KiB
Objective-C
// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fobjc-arc -emit-llvm %s -o - | FileCheck %s
|
|
|
|
// rdar://problem/10290317
|
|
@interface Test0
|
|
- (void) setValue: (id) x;
|
|
@end
|
|
void test0(Test0 *t0, id value) {
|
|
t0.value = value;
|
|
}
|
|
// CHECK-LABEL: define{{.*}} void @test0(
|
|
// CHECK: call void @llvm.objc.storeStrong
|
|
// CHECK: call void @llvm.objc.storeStrong
|
|
// CHECK: @objc_msgSend
|
|
// CHECK: call void @llvm.objc.storeStrong(
|
|
// CHECK: call void @llvm.objc.storeStrong(
|
|
|
|
struct S1 { Class isa; };
|
|
@interface Test1
|
|
@property (nonatomic, strong) __attribute__((NSObject)) struct S1 *pointer;
|
|
@end
|
|
@implementation Test1
|
|
@synthesize pointer;
|
|
@end
|
|
// The getter should be a simple load.
|
|
// CHECK: define internal [[S1:%.*]]* @"\01-[Test1 pointer]"(
|
|
// CHECK: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test1.pointer"
|
|
// CHECK-NEXT: [[T0:%.*]] = bitcast [[TEST1:%.*]]* {{%.*}} to i8*
|
|
// CHECK-NEXT: [[T1:%.*]] = getelementptr inbounds i8, i8* [[T0]], i64 [[OFFSET]]
|
|
// CHECK-NEXT: [[T2:%.*]] = bitcast i8* [[T1]] to [[S1]]**
|
|
// CHECK-NEXT: [[T3:%.*]] = load [[S1]]*, [[S1]]** [[T2]], align 8
|
|
// CHECK-NEXT: ret [[S1]]* [[T3]]
|
|
|
|
// The setter should be using objc_setProperty.
|
|
// CHECK: define internal void @"\01-[Test1 setPointer:]"(
|
|
// CHECK: [[T0:%.*]] = bitcast [[TEST1]]* {{%.*}} to i8*
|
|
// CHECK-NEXT: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test1.pointer"
|
|
// CHECK-NEXT: [[T1:%.*]] = load [[S1]]*, [[S1]]** {{%.*}}
|
|
// CHECK-NEXT: [[T2:%.*]] = bitcast [[S1]]* [[T1]] to i8*
|
|
// CHECK-NEXT: call void @objc_setProperty(i8* noundef [[T0]], i8* noundef {{%.*}}, i64 noundef [[OFFSET]], i8* noundef [[T2]], i1 noundef zeroext false, i1 noundef zeroext false)
|
|
// CHECK-NEXT: ret void
|
|
|
|
|
|
// rdar://problem/12039404
|
|
@interface Test2 {
|
|
@private
|
|
Class _theClass;
|
|
}
|
|
@property (copy) Class theClass;
|
|
@end
|
|
|
|
static Class theGlobalClass;
|
|
@implementation Test2
|
|
@synthesize theClass = _theClass;
|
|
- (void) test {
|
|
_theClass = theGlobalClass;
|
|
}
|
|
@end
|
|
// CHECK: define internal void @"\01-[Test2 test]"(
|
|
// CHECK: [[T0:%.*]] = load i8*, i8** @theGlobalClass, align 8
|
|
// CHECK-NEXT: [[T1:%.*]] = load [[TEST2:%.*]]*, [[TEST2:%.*]]**
|
|
// CHECK-NEXT: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test2._theClass"
|
|
// CHECK-NEXT: [[T2:%.*]] = bitcast [[TEST2]]* [[T1]] to i8*
|
|
// CHECK-NEXT: [[T3:%.*]] = getelementptr inbounds i8, i8* [[T2]], i64 [[OFFSET]]
|
|
// CHECK-NEXT: [[T4:%.*]] = bitcast i8* [[T3]] to i8**
|
|
// CHECK-NEXT: call void @llvm.objc.storeStrong(i8** [[T4]], i8* [[T0]]) [[NUW:#[0-9]+]]
|
|
// CHECK-NEXT: ret void
|
|
|
|
// CHECK: define internal i8* @"\01-[Test2 theClass]"(
|
|
// CHECK: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test2._theClass"
|
|
// CHECK-NEXT: [[T0:%.*]] = tail call i8* @objc_getProperty(i8* noundef {{.*}}, i8* noundef {{.*}}, i64 noundef [[OFFSET]], i1 noundef zeroext true)
|
|
// CHECK-NEXT: ret i8* [[T0]]
|
|
|
|
// CHECK: define internal void @"\01-[Test2 setTheClass:]"(
|
|
// CHECK: [[T0:%.*]] = bitcast [[TEST2]]* {{%.*}} to i8*
|
|
// CHECK-NEXT: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test2._theClass"
|
|
// CHECK-NEXT: [[T1:%.*]] = load i8*, i8** {{%.*}}
|
|
// CHECK-NEXT: call void @objc_setProperty(i8* noundef [[T0]], i8* noundef {{%.*}}, i64 noundef [[OFFSET]], i8* noundef [[T1]], i1 noundef zeroext true, i1 noundef zeroext true)
|
|
// CHECK-NEXT: ret void
|
|
|
|
// CHECK: define internal void @"\01-[Test2 .cxx_destruct]"(
|
|
// CHECK: [[T0:%.*]] = load [[TEST2]]*, [[TEST2]]**
|
|
// CHECK-NEXT: [[OFFSET:%.*]] = load i64, i64* @"OBJC_IVAR_$_Test2._theClass"
|
|
// CHECK-NEXT: [[T1:%.*]] = bitcast [[TEST2]]* [[T0]] to i8*
|
|
// CHECK-NEXT: [[T2:%.*]] = getelementptr inbounds i8, i8* [[T1]], i64 [[OFFSET]]
|
|
// CHECK-NEXT: [[T3:%.*]] = bitcast i8* [[T2]] to i8**
|
|
// CHECK-NEXT: call void @llvm.objc.storeStrong(i8** [[T3]], i8* null) [[NUW]]
|
|
// CHECK-NEXT: ret void
|
|
|
|
// rdar://13115896
|
|
@interface Test3
|
|
@property id copyMachine;
|
|
@end
|
|
|
|
void test3(Test3 *t) {
|
|
id x = t.copyMachine;
|
|
x = [t copyMachine];
|
|
}
|
|
// CHECK: define{{.*}} void @test3([[TEST3:%.*]]*
|
|
// Prologue.
|
|
// CHECK: [[T:%.*]] = alloca [[TEST3]]*,
|
|
// CHECK-NEXT: [[X:%.*]] = alloca i8*,
|
|
// Property access.
|
|
// CHECK: [[T0:%.*]] = load [[TEST3]]*, [[TEST3]]** [[T]],
|
|
// CHECK-NEXT: [[T1:%.*]] = bitcast [[TEST3]]* [[T0]] to i8*
|
|
// CHECK-NEXT: [[SEL:%.*]] = load i8*, i8** @OBJC_SELECTOR_REFERENCES
|
|
// CHECK-NEXT: [[T2:%.*]] = call i8* bitcast ({{.*}} @objc_msgSend to {{.*}})(i8* noundef [[T1]], i8* noundef [[SEL]])
|
|
// CHECK-NEXT: store i8* [[T2]], i8** [[X]],
|
|
// Message send.
|
|
// CHECK-NEXT: [[T0:%.*]] = load [[TEST3]]*, [[TEST3]]** [[T]],
|
|
// CHECK-NEXT: [[T1:%.*]] = bitcast [[TEST3]]* [[T0]] to i8*
|
|
// CHECK-NEXT: [[SEL:%.*]] = load i8*, i8** @OBJC_SELECTOR_REFERENCES
|
|
// CHECK-NEXT: [[T2:%.*]] = call i8* bitcast ({{.*}} @objc_msgSend to {{.*}})(i8* noundef [[T1]], i8* noundef [[SEL]])
|
|
// CHECK-NEXT: [[T3:%.*]] = load i8*, i8** [[X]],
|
|
// CHECK-NEXT: store i8* [[T2]], i8** [[X]],
|
|
// CHECK-NEXT: call void @llvm.objc.release(i8* [[T3]])
|
|
// Epilogue.
|
|
// CHECK-NEXT: call void @llvm.objc.storeStrong(i8** [[X]], i8* null)
|
|
// CHECK-NEXT: [[T0:%.*]] = bitcast [[TEST3]]** [[T]] to i8**
|
|
// CHECK-NEXT: call void @llvm.objc.storeStrong(i8** [[T0]], i8* null)
|
|
// CHECK-NEXT: ret void
|
|
|
|
@implementation Test3
|
|
- (id) copyMachine {
|
|
extern id test3_helper(void);
|
|
return test3_helper();
|
|
}
|
|
// CHECK: define internal i8* @"\01-[Test3 copyMachine]"(
|
|
// CHECK: [[T0:%.*]] = call i8* @test3_helper()
|
|
// CHECK-NEXT: [[T1:%.*]] = notail call i8* @llvm.objc.retainAutoreleasedReturnValue(i8* [[T0]])
|
|
// CHECK-NEXT: ret i8* [[T1]]
|
|
- (void) setCopyMachine: (id) x {}
|
|
@end
|
|
|
|
// rdar://31579994
|
|
// When synthesizing a property that's declared in multiple protocols, ensure
|
|
// that the setter is emitted if any of these declarations is readwrite.
|
|
@protocol ABC
|
|
@property (copy, nonatomic, readonly) Test3 *someId;
|
|
@end
|
|
@protocol ABC__Mutable <ABC>
|
|
@property (copy, nonatomic, readwrite) Test3 *someId;
|
|
@end
|
|
|
|
@interface ABC_Class <ABC, ABC__Mutable>
|
|
@end
|
|
|
|
@implementation ABC_Class
|
|
@synthesize someId = _someId;
|
|
// CHECK: define internal %{{.*}}* @"\01-[ABC_Class someId]"
|
|
// CHECK: define internal void @"\01-[ABC_Class setSomeId:]"(
|
|
@end
|
|
|
|
|
|
// CHECK: attributes [[NUW]] = { nounwind }
|