aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
31 lines
1.2 KiB
C++
31 lines
1.2 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 -Wvla-extension %s
|
|
struct StillPOD {
|
|
StillPOD() = default;
|
|
};
|
|
|
|
struct StillPOD2 {
|
|
StillPOD np;
|
|
};
|
|
|
|
struct NonPOD {
|
|
NonPOD(int) {}
|
|
};
|
|
|
|
struct POD {
|
|
int x;
|
|
int y;
|
|
};
|
|
|
|
// We allow VLAs of POD types, only.
|
|
void vla(int N) { // expected-note 5{{here}}
|
|
int array1[N]; // expected-warning{{variable length arrays are a C99 feature}} expected-note {{parameter 'N'}}
|
|
POD array2[N]; // expected-warning{{variable length arrays are a C99 feature}} expected-note {{parameter 'N'}}
|
|
StillPOD array3[N]; // expected-warning{{variable length arrays are a C99 feature}} expected-note {{parameter 'N'}}
|
|
StillPOD2 array4[N][3]; // expected-warning{{variable length arrays are a C99 feature}} expected-note {{parameter 'N'}}
|
|
NonPOD array5[N]; // expected-error{{no matching constructor for initialization of 'NonPOD[N]'}}
|
|
// expected-warning@-1{{variable length arrays are a C99 feature}} expected-note@-1 {{parameter 'N'}}
|
|
// expected-note@-16{{candidate constructor not viable}}
|
|
// expected-note@-18{{candidate constructor (the implicit copy constructor) not viable}}
|
|
// expected-note@-19{{candidate constructor (the implicit move constructor) not viable}}
|
|
}
|