aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
102 lines
1.9 KiB
C++
102 lines
1.9 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
// pr7029
|
|
|
|
template <class Key, class T> struct QMap
|
|
{
|
|
void insert(const Key &, const T &);
|
|
T v;
|
|
};
|
|
|
|
|
|
template <class Key, class T>
|
|
void QMap<Key, T>::insert(const Key &, const T &avalue)
|
|
{
|
|
v = avalue;
|
|
}
|
|
|
|
struct Rec {
|
|
union { // expected-warning-re {{variable sized type '{{.*}}' not at the end of a struct or class is a GNU extension}}
|
|
int u0[];
|
|
};
|
|
int x;
|
|
} rec;
|
|
|
|
struct inotify_event
|
|
{
|
|
int wd;
|
|
|
|
// clang doesn't like '[]':
|
|
// cannot initialize a parameter of type 'void *' with an rvalue of type 'char (*)[]'
|
|
char name [];
|
|
};
|
|
|
|
|
|
void foo()
|
|
{
|
|
inotify_event event;
|
|
inotify_event* ptr = &event;
|
|
inotify_event event1 = *ptr;
|
|
*ptr = event;
|
|
QMap<int, inotify_event> eventForId;
|
|
eventForId.insert(ptr->wd, *ptr);
|
|
}
|
|
|
|
struct S {
|
|
virtual void foo();
|
|
};
|
|
|
|
struct X {
|
|
int blah;
|
|
S strings[];
|
|
};
|
|
|
|
S a, b = a;
|
|
S f(X &x) {
|
|
a = b;
|
|
return x.strings[0];
|
|
}
|
|
|
|
class A {
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
union B {
|
|
int s;
|
|
char c[];
|
|
};
|
|
|
|
class C {
|
|
char c[]; // expected-error {{flexible array member 'c' with type 'char[]' is not at the end of class}}
|
|
int s; // expected-note {{next field declaration is here}}
|
|
};
|
|
|
|
namespace rdar9065507 {
|
|
|
|
struct StorageBase {
|
|
long ref_count;
|
|
unsigned size;
|
|
unsigned capacity;
|
|
};
|
|
|
|
struct Storage : StorageBase {
|
|
int data[];
|
|
};
|
|
|
|
struct VirtStorage : virtual StorageBase {
|
|
int data[]; // expected-error {{flexible array member 'data' not allowed in struct which has a virtual base class}}
|
|
};
|
|
|
|
}
|
|
|
|
struct NonTrivDtor { ~NonTrivDtor(); };
|
|
// FIXME: It's not clear whether we should disallow examples like this. GCC accepts.
|
|
struct FlexNonTrivDtor {
|
|
int n;
|
|
NonTrivDtor ntd[]; // expected-error {{flexible array member 'ntd' of type 'NonTrivDtor[]' with non-trivial destruction}}
|
|
~FlexNonTrivDtor() {
|
|
for (int i = n; i != 0; --i)
|
|
ntd[i-1].~NonTrivDtor();
|
|
}
|
|
};
|