45b8a741fb
This is a follow-up for D70378 (Cover usage of LLD as a library). While debugging an intermittent failure on a bot, I recalled this scenario which causes the issue: 1.When executing lld/test/ELF/invalid/symtab-sh-info.s L45, we reach lld:🧝:Obj-File::ObjFile() which goes straight into its base ELFFileBase(), then ELFFileBase::init(). 2.At that point fatal() is thrown in lld/ELF/InputFiles.cpp L381, leaving a half-initialized ObjFile instance. 3.We then end up in lld::exitLld() and since we are running with LLD_IN_TEST, we hapily restore the control flow to CrashRecoveryContext::RunSafely() then back in lld::safeLldMain(). 4.Before this patch, we called errorHandler().reset() just after, and this attempted to reset the associated SpecificAlloc<ObjFile<ELF64LE>>. That tried to free the half-initialized ObjFile instance, and more precisely its ObjFile::dwarf member. Sometimes that worked, sometimes it failed and was catched by the CrashRecoveryContext. This scenario was the reason we called errorHandler().reset() through a CrashRecoveryContext. But in some rare cases, the above repro somehow corrupted the heap, creating a stack overflow. When the CrashRecoveryContext's filter (that is, __except (ExceptionFilter(GetExceptionInformation()))) tried to handle the exception, it crashed again since the stack was exhausted -- and that took the whole application down. That is the issue seen on the bot. Locally it happens about 1 times out of 15. Now this situation can happen anywhere in LLD. Since catching stack overflows is not a reliable scenario ATM when using CrashRecoveryContext, we're now preventing further re-entrance when such failures occur, by signaling lld::SafeReturn::canRunAgain=false. When running with LLD_IN_TEST=2 (or above), only one iteration will be executed, instead of two. Differential Revision: https://reviews.llvm.org/D88348
98 lines
4.9 KiB
Plaintext
98 lines
4.9 KiB
Plaintext
RUN: lld-link %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj %S/Inputs/precomp.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf /summary | FileCheck %s -check-prefix SUMMARY
|
|
RUN: llvm-pdbutil dump -types %t.pdb | FileCheck %s
|
|
|
|
RUN: lld-link %S/Inputs/precomp.obj %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf
|
|
RUN: llvm-pdbutil dump -types %t.pdb | FileCheck %s
|
|
|
|
RUN: lld-link %S/Inputs/precomp-a.obj %S/Inputs/precomp-invalid.obj %S/Inputs/precomp.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf 2>&1 | FileCheck %s -check-prefix FAILURE
|
|
RUN: lld-link %S/Inputs/precomp-a.obj %S/Inputs/precomp-invalid.obj %S/Inputs/precomp.obj /nodefaultlib /entry:main /debug:ghash /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf 2>&1 | FileCheck %s -check-prefix FAILURE
|
|
|
|
FIXME: The following RUN line should fail, regardless of whether debug info is
|
|
enabled or not. Normally this would result in an error due to missing _PchSym_
|
|
references, but SymbolTable.cpp suppresses such errors. MSVC seems to have a
|
|
special case for those symbols and it emits the LNK2011 error.
|
|
|
|
RUN: lld-link %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf 2>&1 | FileCheck %s -check-prefix FAILURE-MISSING-PRECOMPOBJ
|
|
|
|
FAILURE: warning: Cannot use debug info for '{{.*}}precomp-invalid.obj' [LNK4099]
|
|
FAILURE-NEXT: failed to load reference '{{.*}}precomp.obj': No matching precompiled header could be located.
|
|
|
|
FAILURE-MISSING-PRECOMPOBJ: warning: Cannot use debug info for '{{.*}}precomp-a.obj' [LNK4099]
|
|
FAILURE-MISSING-PRECOMPOBJ-NEXT: failed to load reference '{{.*}}precomp.obj': No matching precompiled header could be located.
|
|
|
|
Check that a PCH object file with a missing S_OBJNAME record results in an
|
|
error. Edit out this record from the yaml-ified object:
|
|
- Kind: S_OBJNAME
|
|
ObjNameSym:
|
|
Signature: 545589255
|
|
ObjectName: 'F:\svn\lld\test\COFF\precomp\precomp.obj'
|
|
|
|
RUN: obj2yaml %S/Inputs/precomp.obj | grep -v 'SectionData: *04000000' > %t.precomp.yaml
|
|
RUN: sed '/S_OBJNAME/,/ObjectName:/d' < %t.precomp.yaml > precomp-no-objname.yaml
|
|
RUN: sed 's/Signature: *545589255/Signature: 0/' < %t.precomp.yaml > precomp-zero-sig.yaml
|
|
RUN: yaml2obj precomp-no-objname.yaml -o %t.precomp-no-objname.obj
|
|
RUN: yaml2obj precomp-zero-sig.yaml -o %t.precomp-zero-sig.obj
|
|
|
|
RUN: env LLD_IN_TEST=1 not lld-link %t.precomp-no-objname.obj %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe 2>&1 | FileCheck %s -check-prefix FAILURE-NO-SIGNATURE
|
|
|
|
RUN: env LLD_IN_TEST=1 not lld-link %t.precomp-zero-sig.obj %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe 2>&1 | FileCheck %s -check-prefix FAILURE-NO-SIGNATURE
|
|
|
|
FAILURE-NO-SIGNATURE: error: {{.*}}.obj claims to be a PCH object, but does not have a valid signature
|
|
|
|
Check that two PCH objs with duplicate signatures are an error.
|
|
|
|
RUN: cp %S/Inputs/precomp.obj %t.precomp-dup.obj
|
|
|
|
RUN: env LLD_IN_TEST=1 not lld-link %S/Inputs/precomp.obj %t.precomp-dup.obj %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj /nodefaultlib /entry:main /debug /pdb:%t.pdb /out:%t.exe 2>&1 | FileCheck %s -check-prefix FAILURE-DUP-SIGNATURE
|
|
|
|
FAILURE-DUP-SIGNATURE: error: a PCH object with the same signature has already been provided ({{.*precomp.obj and .*precomp-dup.obj.*}})
|
|
|
|
|
|
CHECK: Types (TPI Stream)
|
|
CHECK-NOT: LF_PRECOMP
|
|
CHECK-NOT: LF_ENDPRECOMP
|
|
|
|
|
|
Re-run with ghash. Eventually, perhaps this will be the default.
|
|
|
|
RUN: lld-link %S/Inputs/precomp-a.obj %S/Inputs/precomp-b.obj %S/Inputs/precomp.obj /nodefaultlib /entry:main /debug /debug:ghash /pdb:%t.pdb /out:%t.exe /opt:ref /opt:icf /summary | FileCheck %s -check-prefix SUMMARY
|
|
RUN: llvm-pdbutil dump -types %t.pdb | FileCheck %s
|
|
|
|
|
|
SUMMARY: Summary
|
|
SUMMARY-NEXT: --------------------------------------------------------------------------------
|
|
SUMMARY-NEXT: 3 Input OBJ files (expanded from all cmd-line inputs)
|
|
SUMMARY-NEXT: 0 PDB type server dependencies
|
|
SUMMARY-NEXT: 1 Precomp OBJ dependencies
|
|
SUMMARY-NEXT: 1066 Input type records
|
|
SUMMARY-NEXT: 55968 Input type records bytes
|
|
SUMMARY-NEXT: 874 Merged TPI records
|
|
SUMMARY-NEXT: 170 Merged IPI records
|
|
SUMMARY-NEXT: 5 Output PDB strings
|
|
SUMMARY-NEXT: 167 Global symbol records
|
|
SUMMARY-NEXT: 20 Module symbol records
|
|
SUMMARY-NEXT: 3 Public symbol records
|
|
|
|
// precomp.h
|
|
#pragma once
|
|
int Function(char A);
|
|
|
|
// precomp.cpp
|
|
#include "precomp.h"
|
|
|
|
// a.cpp
|
|
#include "precomp.h"
|
|
int main(void) {
|
|
Function('a');
|
|
return 0;
|
|
}
|
|
|
|
// b.cpp
|
|
#include "precomp.h"
|
|
int Function(char a) {
|
|
return (int)a;
|
|
}
|
|
|
|
// cl.exe precomp.cpp /Z7 /Ycprecomp.h /c
|
|
// cl.exe a.cpp b.cpp /Z7 /Yuprecomp.h /c
|