1beffc1888
SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand, shorter-than-16-bytes UUIDs are completely ignored. In this patch, we change the parsing code to handle UUIDs of arbitrary size. To support arbitrary size UUIDs in SBTarget::AddModule, this patch changes UUID::SetFromStringRef to parse UUIDs of arbitrary length. We subtly change the semantics of SetFromStringRef - SetFromStringRef now only succeeds if the entire input is consumed to prevent some prefix-parsing confusion. This is up for discussion, but I believe this is more consistent - we always return false for invalid UUIDs rather than sometimes truncating to a valid prefix. Also, all the call-sites except the API and interpreter seem to expect to consume the entire input. This also adds tests for adding existing modules 4-, 16-, and 20-byte build-ids. Finally, we took the liberty of testing the minidump scenario we care about - removing placeholder module from minidump and replacing it with the real module. Reviewed By: labath, friss Differential Revision: https://reviews.llvm.org/D80755
96 lines
3.1 KiB
C++
96 lines
3.1 KiB
C++
//===-- UUIDTest.cpp ------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "lldb/Utility/UUID.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
TEST(UUIDTest, RelationalOperators) {
|
|
UUID empty;
|
|
UUID a16 = UUID::fromData("1234567890123456", 16);
|
|
UUID b16 = UUID::fromData("1234567890123457", 16);
|
|
UUID a20 = UUID::fromData("12345678901234567890", 20);
|
|
UUID b20 = UUID::fromData("12345678900987654321", 20);
|
|
|
|
EXPECT_EQ(empty, empty);
|
|
EXPECT_EQ(a16, a16);
|
|
EXPECT_EQ(a20, a20);
|
|
|
|
EXPECT_NE(a16, b16);
|
|
EXPECT_NE(a20, b20);
|
|
EXPECT_NE(a16, a20);
|
|
EXPECT_NE(empty, a16);
|
|
|
|
EXPECT_LT(empty, a16);
|
|
EXPECT_LT(a16, a20);
|
|
EXPECT_LT(a16, b16);
|
|
EXPECT_GT(a20, b20);
|
|
}
|
|
|
|
TEST(UUIDTest, Validity) {
|
|
UUID empty;
|
|
std::vector<uint8_t> zeroes(20, 0);
|
|
UUID a16 = UUID::fromData(zeroes.data(), 16);
|
|
UUID a20 = UUID::fromData(zeroes.data(), 20);
|
|
UUID a16_0 = UUID::fromOptionalData(zeroes.data(), 16);
|
|
UUID a20_0 = UUID::fromOptionalData(zeroes.data(), 20);
|
|
UUID from_str;
|
|
from_str.SetFromStringRef("00000000-0000-0000-0000-000000000000");
|
|
UUID opt_from_str;
|
|
opt_from_str.SetFromOptionalStringRef("00000000-0000-0000-0000-000000000000");
|
|
|
|
EXPECT_FALSE(empty);
|
|
EXPECT_TRUE(a16);
|
|
EXPECT_TRUE(a20);
|
|
EXPECT_TRUE(from_str);
|
|
EXPECT_FALSE(a16_0);
|
|
EXPECT_FALSE(a20_0);
|
|
EXPECT_FALSE(opt_from_str);
|
|
}
|
|
|
|
TEST(UUIDTest, SetFromStringRef) {
|
|
UUID u;
|
|
EXPECT_TRUE(u.SetFromStringRef("404142434445464748494a4b4c4d4e4f"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u);
|
|
|
|
EXPECT_TRUE(u.SetFromStringRef("40-41-42-43-4445464748494a4b4c4d4e4f"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u);
|
|
|
|
EXPECT_TRUE(
|
|
u.SetFromStringRef("40-41-42-43-4445464748494a4b4c4d4e4f-50515253"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNOPQRS", 20), u);
|
|
|
|
EXPECT_TRUE(u.SetFromStringRef("40-41-42-43-4445464748494a4b4c4d4e4f"));
|
|
|
|
EXPECT_FALSE(u.SetFromStringRef("40xxxxx"));
|
|
EXPECT_FALSE(u.SetFromStringRef(""));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNO", 16), u)
|
|
<< "uuid was changed by failed parse calls";
|
|
|
|
EXPECT_TRUE(u.SetFromStringRef("404142434445464748494a4b4c4d4e4f-50515253"));
|
|
EXPECT_EQ(UUID::fromData("@ABCDEFGHIJKLMNOPQRS", 20), u);
|
|
|
|
EXPECT_TRUE(u.SetFromStringRef("40414243"));
|
|
EXPECT_EQ(UUID::fromData("@ABCD", 4), u);
|
|
|
|
EXPECT_FALSE(u.SetFromStringRef("4"));
|
|
}
|
|
|
|
TEST(UUIDTest, StringConverion) {
|
|
EXPECT_EQ("40414243", UUID::fromData("@ABC", 4).GetAsString());
|
|
EXPECT_EQ("40414243-4445-4647", UUID::fromData("@ABCDEFG", 8).GetAsString());
|
|
EXPECT_EQ("40414243-4445-4647-4849-4A4B",
|
|
UUID::fromData("@ABCDEFGHIJK", 12).GetAsString());
|
|
EXPECT_EQ("40414243-4445-4647-4849-4A4B4C4D4E4F",
|
|
UUID::fromData("@ABCDEFGHIJKLMNO", 16).GetAsString());
|
|
EXPECT_EQ("40414243-4445-4647-4849-4A4B4C4D4E4F-50515253",
|
|
UUID::fromData("@ABCDEFGHIJKLMNOPQRS", 20).GetAsString());
|
|
}
|