Simon Pilgrim 147cfcbef1 [X86] LowerShiftByScalarVariable - find splat patterns with getSplatSourceVector instead of getSplatValue
This completes the removal of uses of SelectionDAG::getSplatValue started in D119090 - by avoiding extracting the splatted element we make it a lot easier to zero-extend the bottom 64-bits of the shift amount and fixes issues we had on 32-bit targets where i64 isn't legal.

I've removed the old version of getTargetVShiftNode that took the scalar shift amount argument and LowerRotate can finally efficiently handle vXi16 rotates-by-scalar (using the same code as general funnel-shifts).

The only regression we see is in the X86-AVX2 PR52719 test case in vector-shift-ashr-256.ll - this is now hitting the same problem as the X86-AVX1 case (failure to simplify a multi-use X86ISD::VBROADCAST_LOAD) which I intend to address in a follow up patch.
2022-03-04 16:47:35 +00:00

114 lines
4.6 KiB
LLVM

; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
; RUN: llc < %s -mtriple=i686-pc-linux -mcpu=corei7-avx | FileCheck %s --check-prefixes=X86
; RUN: llc < %s -mtriple=x86_64-pc-linux -mcpu=corei7-avx | FileCheck %s --check-prefixes=X64
define <8 x i32> @shiftInput___vyuunu(<8 x i32> %input, i32 %shiftval, <8 x i32> %__mask) nounwind {
; X86-LABEL: shiftInput___vyuunu:
; X86: # %bb.0: # %allocas
; X86-NEXT: vextractf128 $1, %ymm0, %xmm1
; X86-NEXT: vmovd {{.*#+}} xmm2 = mem[0],zero,zero,zero
; X86-NEXT: vpsrld %xmm2, %xmm1, %xmm1
; X86-NEXT: vpsrld %xmm2, %xmm0, %xmm0
; X86-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; X86-NEXT: retl
;
; X64-LABEL: shiftInput___vyuunu:
; X64: # %bb.0: # %allocas
; X64-NEXT: vmovd %edi, %xmm1
; X64-NEXT: vextractf128 $1, %ymm0, %xmm2
; X64-NEXT: vpsrld %xmm1, %xmm2, %xmm2
; X64-NEXT: vpsrld %xmm1, %xmm0, %xmm0
; X64-NEXT: vinsertf128 $1, %xmm2, %ymm0, %ymm0
; X64-NEXT: retq
allocas:
%smear.0 = insertelement <8 x i32> undef, i32 %shiftval, i32 0
%smear.1 = insertelement <8 x i32> %smear.0, i32 %shiftval, i32 1
%smear.2 = insertelement <8 x i32> %smear.1, i32 %shiftval, i32 2
%smear.3 = insertelement <8 x i32> %smear.2, i32 %shiftval, i32 3
%smear.4 = insertelement <8 x i32> %smear.3, i32 %shiftval, i32 4
%smear.5 = insertelement <8 x i32> %smear.4, i32 %shiftval, i32 5
%smear.6 = insertelement <8 x i32> %smear.5, i32 %shiftval, i32 6
%smear.7 = insertelement <8 x i32> %smear.6, i32 %shiftval, i32 7
%bitop = lshr <8 x i32> %input, %smear.7
ret <8 x i32> %bitop
}
define <8 x i32> @shiftInput___canonical(<8 x i32> %input, i32 %shiftval, <8 x i32> %__mask) nounwind {
; X86-LABEL: shiftInput___canonical:
; X86: # %bb.0: # %allocas
; X86-NEXT: vbroadcastss {{[0-9]+}}(%esp), %xmm1
; X86-NEXT: vpmovzxdq {{.*#+}} xmm1 = xmm1[0],zero,xmm1[1],zero
; X86-NEXT: vextractf128 $1, %ymm0, %xmm2
; X86-NEXT: vpsrld %xmm1, %xmm2, %xmm2
; X86-NEXT: vpsrld %xmm1, %xmm0, %xmm0
; X86-NEXT: vinsertf128 $1, %xmm2, %ymm0, %ymm0
; X86-NEXT: retl
;
; X64-LABEL: shiftInput___canonical:
; X64: # %bb.0: # %allocas
; X64-NEXT: vmovd %edi, %xmm1
; X64-NEXT: vextractf128 $1, %ymm0, %xmm2
; X64-NEXT: vpsrld %xmm1, %xmm2, %xmm2
; X64-NEXT: vpsrld %xmm1, %xmm0, %xmm0
; X64-NEXT: vinsertf128 $1, %xmm2, %ymm0, %ymm0
; X64-NEXT: retq
allocas:
%smear.0 = insertelement <8 x i32> undef, i32 %shiftval, i32 0
%smear.7 = shufflevector <8 x i32> %smear.0, <8 x i32> undef, <8 x i32> zeroinitializer
%bitop = lshr <8 x i32> %input, %smear.7
ret <8 x i32> %bitop
}
define <4 x i64> @shiftInput___64in32bitmode(<4 x i64> %input, i64 %shiftval) nounwind {
; X86-LABEL: shiftInput___64in32bitmode:
; X86: # %bb.0: # %allocas
; X86-NEXT: vextractf128 $1, %ymm0, %xmm1
; X86-NEXT: vmovq {{.*#+}} xmm2 = mem[0],zero
; X86-NEXT: vpsrlq %xmm2, %xmm1, %xmm1
; X86-NEXT: vpsrlq %xmm2, %xmm0, %xmm0
; X86-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; X86-NEXT: retl
;
; X64-LABEL: shiftInput___64in32bitmode:
; X64: # %bb.0: # %allocas
; X64-NEXT: vmovq %rdi, %xmm1
; X64-NEXT: vextractf128 $1, %ymm0, %xmm2
; X64-NEXT: vpsrlq %xmm1, %xmm2, %xmm2
; X64-NEXT: vpsrlq %xmm1, %xmm0, %xmm0
; X64-NEXT: vinsertf128 $1, %xmm2, %ymm0, %ymm0
; X64-NEXT: retq
allocas:
%smear.0 = insertelement <4 x i64> undef, i64 %shiftval, i32 0
%smear.7 = shufflevector <4 x i64> %smear.0, <4 x i64> undef, <4 x i32> zeroinitializer
%bitop = lshr <4 x i64> %input, %smear.7
ret <4 x i64> %bitop
}
define <4 x i64> @shiftInput___2x32bitcast(<4 x i64> %input, i32 %shiftval) nounwind {
; X86-LABEL: shiftInput___2x32bitcast:
; X86: # %bb.0: # %allocas
; X86-NEXT: vextractf128 $1, %ymm0, %xmm1
; X86-NEXT: vmovd {{.*#+}} xmm2 = mem[0],zero,zero,zero
; X86-NEXT: vpsrlq %xmm2, %xmm1, %xmm1
; X86-NEXT: vpsrlq %xmm2, %xmm0, %xmm0
; X86-NEXT: vinsertf128 $1, %xmm1, %ymm0, %ymm0
; X86-NEXT: retl
;
; X64-LABEL: shiftInput___2x32bitcast:
; X64: # %bb.0: # %allocas
; X64-NEXT: vmovd %edi, %xmm1
; X64-NEXT: vextractf128 $1, %ymm0, %xmm2
; X64-NEXT: vpsrlq %xmm1, %xmm2, %xmm2
; X64-NEXT: vpsrlq %xmm1, %xmm0, %xmm0
; X64-NEXT: vinsertf128 $1, %xmm2, %ymm0, %ymm0
; X64-NEXT: retq
allocas:
%smear.0 = insertelement <8 x i32> zeroinitializer, i32 %shiftval, i32 0
%smear.1 = insertelement <8 x i32> %smear.0, i32 %shiftval, i32 2
%smear.2 = insertelement <8 x i32> %smear.1, i32 %shiftval, i32 4
%smear.3 = insertelement <8 x i32> %smear.2, i32 %shiftval, i32 6
%smear.4 = bitcast <8 x i32> %smear.3 to <4 x i64>
%bitop = lshr <4 x i64> %input, %smear.4
ret <4 x i64> %bitop
}