90ec6dff86
Currently, opaque pointers are supported in two forms: The -force-opaque-pointers mode, where all pointers are opaque and typed pointers do not exist. And as a simple ptr type that can coexist with typed pointers. This patch removes support for the mixed mode. You either get typed pointers, or you get opaque pointers, but not both. In the (current) default mode, using ptr is forbidden. In -opaque-pointers mode, all pointers are opaque. The motivation here is that the mixed mode introduces additional issues that don't exist in fully opaque mode. D105155 is an example of a design problem. Looking at D109259, it would probably need additional work to support mixed mode (e.g. to generate GEPs for typed base but opaque result). Mixed mode will also end up inserting many casts between i8* and ptr, which would require significant additional work to consistently avoid. I don't think the mixed mode is particularly valuable, as it doesn't align with our end goal. The only thing I've found it to be moderately useful for is adding some opaque pointer tests in between typed pointer tests, but I think we can live without that. Differential Revision: https://reviews.llvm.org/D109290
27 lines
1.0 KiB
LLVM
27 lines
1.0 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
|
|
; RUN: opt -S -instcombine -opaque-pointers < %s | FileCheck %s
|
|
|
|
@g = global [16 x i16] zeroinitializer
|
|
|
|
define ptr @gep_constexpr_gv_1() {
|
|
; CHECK-LABEL: @gep_constexpr_gv_1(
|
|
; CHECK-NEXT: ret ptr getelementptr inbounds ([16 x i16], ptr @g, i64 0, i64 10)
|
|
;
|
|
ret ptr getelementptr([16 x i16], ptr @g, i64 0, i64 10)
|
|
}
|
|
|
|
define ptr @gep_constexpr_gv_2() {
|
|
; CHECK-LABEL: @gep_constexpr_gv_2(
|
|
; CHECK-NEXT: ret ptr getelementptr inbounds ([16 x i16], ptr @g, i64 0, i64 12)
|
|
;
|
|
ret ptr getelementptr(i32, ptr getelementptr([16 x i16], ptr @g, i64 0, i64 10), i64 1)
|
|
}
|
|
|
|
; Silly expression to get an inttoptr that does not combine with the GEP.
|
|
define ptr @gep_constexpr_inttoptr() {
|
|
; CHECK-LABEL: @gep_constexpr_inttoptr(
|
|
; CHECK-NEXT: ret ptr getelementptr (i8, ptr inttoptr (i64 mul (i64 ptrtoint (ptr @g to i64), i64 2) to ptr), i64 20)
|
|
;
|
|
ret ptr getelementptr([16 x i16], ptr inttoptr (i64 mul (i64 ptrtoint ([16 x i16]* @g to i64), i64 2) to ptr), i64 0, i64 10)
|
|
}
|