77eee5795e
The current dialect registry allows for attaching delayed interfaces, that are added to attrs/dialects/ops/etc. when the owning dialect gets loaded. This is clunky for quite a few reasons, e.g. each interface type has a separate tracking structure, and is also quite limiting. This commit refactors this delayed mutation of dialect constructs into a more general DialectExtension mechanism. This mechanism is essentially a registration callback that is invoked when a set of dialects have been loaded. This allows for attaching interfaces directly on the loaded constructs, and also allows for loading new dependent dialects. The latter of which is extremely useful as it will now enable dependent dialects to only apply in the contexts in which they are necessary. For example, a dialect dependency can now be conditional on if a user actually needs the interface that relies on it. Differential Revision: https://reviews.llvm.org/D120367
128 lines
4.7 KiB
C++
128 lines
4.7 KiB
C++
//===- DialectTest.cpp - Dialect unit tests -------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/IR/Dialect.h"
|
|
#include "mlir/IR/DialectInterface.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
using namespace mlir;
|
|
using namespace mlir::detail;
|
|
|
|
namespace {
|
|
struct TestDialect : public Dialect {
|
|
static StringRef getDialectNamespace() { return "test"; };
|
|
TestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context, TypeID::get<TestDialect>()) {}
|
|
};
|
|
struct AnotherTestDialect : public Dialect {
|
|
static StringRef getDialectNamespace() { return "test"; };
|
|
AnotherTestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context,
|
|
TypeID::get<AnotherTestDialect>()) {}
|
|
};
|
|
|
|
TEST(DialectDeathTest, MultipleDialectsWithSameNamespace) {
|
|
MLIRContext context;
|
|
|
|
// Registering a dialect with the same namespace twice should result in a
|
|
// failure.
|
|
context.loadDialect<TestDialect>();
|
|
ASSERT_DEATH(context.loadDialect<AnotherTestDialect>(), "");
|
|
}
|
|
|
|
struct SecondTestDialect : public Dialect {
|
|
static StringRef getDialectNamespace() { return "test2"; }
|
|
SecondTestDialect(MLIRContext *context)
|
|
: Dialect(getDialectNamespace(), context,
|
|
TypeID::get<SecondTestDialect>()) {}
|
|
};
|
|
|
|
struct TestDialectInterfaceBase
|
|
: public DialectInterface::Base<TestDialectInterfaceBase> {
|
|
TestDialectInterfaceBase(Dialect *dialect) : Base(dialect) {}
|
|
virtual int function() const { return 42; }
|
|
};
|
|
|
|
struct TestDialectInterface : public TestDialectInterfaceBase {
|
|
using TestDialectInterfaceBase::TestDialectInterfaceBase;
|
|
int function() const final { return 56; }
|
|
};
|
|
|
|
struct SecondTestDialectInterface : public TestDialectInterfaceBase {
|
|
using TestDialectInterfaceBase::TestDialectInterfaceBase;
|
|
int function() const final { return 78; }
|
|
};
|
|
|
|
TEST(Dialect, DelayedInterfaceRegistration) {
|
|
DialectRegistry registry;
|
|
registry.insert<TestDialect, SecondTestDialect>();
|
|
|
|
// Delayed registration of an interface for TestDialect.
|
|
registry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
|
|
MLIRContext context(registry);
|
|
|
|
// Load the TestDialect and check that the interface got registered for it.
|
|
Dialect *testDialect = context.getOrLoadDialect<TestDialect>();
|
|
ASSERT_TRUE(testDialect != nullptr);
|
|
auto *testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
|
|
// Load the SecondTestDialect and check that the interface is not registered
|
|
// for it.
|
|
Dialect *secondTestDialect = context.getOrLoadDialect<SecondTestDialect>();
|
|
ASSERT_TRUE(secondTestDialect != nullptr);
|
|
auto *secondTestDialectInterface =
|
|
dyn_cast<SecondTestDialectInterface>(secondTestDialect);
|
|
EXPECT_TRUE(secondTestDialectInterface == nullptr);
|
|
|
|
// Use the same mechanism as for delayed registration but for an already
|
|
// loaded dialect and check that the interface is now registered.
|
|
DialectRegistry secondRegistry;
|
|
secondRegistry.insert<SecondTestDialect>();
|
|
secondRegistry.addExtension(
|
|
+[](MLIRContext *ctx, SecondTestDialect *dialect) {
|
|
dialect->addInterfaces<SecondTestDialectInterface>();
|
|
});
|
|
context.appendDialectRegistry(secondRegistry);
|
|
secondTestDialectInterface =
|
|
dyn_cast<SecondTestDialectInterface>(secondTestDialect);
|
|
EXPECT_TRUE(secondTestDialectInterface != nullptr);
|
|
}
|
|
|
|
TEST(Dialect, RepeatedDelayedRegistration) {
|
|
// Set up the delayed registration.
|
|
DialectRegistry registry;
|
|
registry.insert<TestDialect>();
|
|
registry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
MLIRContext context(registry);
|
|
|
|
// Load the TestDialect and check that the interface got registered for it.
|
|
Dialect *testDialect = context.getOrLoadDialect<TestDialect>();
|
|
ASSERT_TRUE(testDialect != nullptr);
|
|
auto *testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
|
|
// Try adding the same dialect interface again and check that we don't crash
|
|
// on repeated interface registration.
|
|
DialectRegistry secondRegistry;
|
|
secondRegistry.insert<TestDialect>();
|
|
secondRegistry.addExtension(+[](MLIRContext *ctx, TestDialect *dialect) {
|
|
dialect->addInterfaces<TestDialectInterface>();
|
|
});
|
|
context.appendDialectRegistry(secondRegistry);
|
|
testDialectInterface = dyn_cast<TestDialectInterfaceBase>(testDialect);
|
|
EXPECT_TRUE(testDialectInterface != nullptr);
|
|
}
|
|
|
|
} // namespace
|