5e50dd048e
This commit restructures how TypeID is implemented to ideally avoid the current problems related to shared libraries. This is done by changing the "implicit" fallback path to use the name of the type, instead of using a static template variable (which breaks shared libraries). The major downside to this is that it adds some additional initialization costs for the implicit path. Given the use of type names for uniqueness in the fallback, we also no longer allow types defined in anonymous namespaces to have an implicit TypeID. To simplify defining an ID for these classes, a new `MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID` macro was added to allow for explicitly defining a TypeID directly on an internal class. To help identify when types are using the fallback, `-debug-only=typeid` can be used to log which types are using implicit ids. This change generally only requires changes to the test passes, which are all defined in anonymous namespaces, and thus can't use the fallback any longer. Differential Revision: https://reviews.llvm.org/D122775
69 lines
2.6 KiB
C++
69 lines
2.6 KiB
C++
//===- TestAvailability.cpp - Test pass for setting Entry point ABI info --===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file implements a pass that sets the spv.entry_point_abi attribute on
|
|
// functions that are to be lowered as entry point functions.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "mlir/Dialect/GPU/GPUDialect.h"
|
|
#include "mlir/Dialect/SPIRV/IR/SPIRVDialect.h"
|
|
#include "mlir/Dialect/SPIRV/IR/TargetAndABI.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
|
|
using namespace mlir;
|
|
|
|
namespace {
|
|
/// Pass to set the spv.entry_point_abi
|
|
struct TestSpirvEntryPointABIPass
|
|
: public PassWrapper<TestSpirvEntryPointABIPass,
|
|
OperationPass<gpu::GPUModuleOp>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestSpirvEntryPointABIPass)
|
|
|
|
StringRef getArgument() const final { return "test-spirv-entry-point-abi"; }
|
|
StringRef getDescription() const final {
|
|
return "Set the spv.entry_point_abi attribute on GPU kernel function "
|
|
"within the "
|
|
"module, intended for testing only";
|
|
}
|
|
TestSpirvEntryPointABIPass() = default;
|
|
TestSpirvEntryPointABIPass(const TestSpirvEntryPointABIPass &) {}
|
|
void runOnOperation() override;
|
|
|
|
private:
|
|
Pass::ListOption<int32_t> workgroupSize{
|
|
*this, "workgroup-size",
|
|
llvm::cl::desc(
|
|
"Workgroup size to use for all gpu.func kernels in the module, "
|
|
"specified with x-dimension first, y-dimension next and z-dimension "
|
|
"last. Unspecified dimensions will be set to 1"),
|
|
llvm::cl::ZeroOrMore};
|
|
};
|
|
} // namespace
|
|
|
|
void TestSpirvEntryPointABIPass::runOnOperation() {
|
|
gpu::GPUModuleOp gpuModule = getOperation();
|
|
MLIRContext *context = &getContext();
|
|
StringRef attrName = spirv::getEntryPointABIAttrName();
|
|
for (gpu::GPUFuncOp gpuFunc : gpuModule.getOps<gpu::GPUFuncOp>()) {
|
|
if (!gpu::GPUDialect::isKernel(gpuFunc) || gpuFunc->getAttr(attrName))
|
|
continue;
|
|
SmallVector<int32_t, 3> workgroupSizeVec(workgroupSize.begin(),
|
|
workgroupSize.end());
|
|
workgroupSizeVec.resize(3, 1);
|
|
gpuFunc->setAttr(attrName,
|
|
spirv::getEntryPointABIAttr(workgroupSizeVec, context));
|
|
}
|
|
}
|
|
|
|
namespace mlir {
|
|
void registerTestSpirvEntryPointABIPass() {
|
|
PassRegistration<TestSpirvEntryPointABIPass>();
|
|
}
|
|
} // namespace mlir
|