Jordan Rose 2be02a7848 [analyzer] Shitfing a constant value by its bit width is undefined.
Citation: C++11 [expr.shift]p1 (and the equivalent text in C11).

This fixes PR18073, but the right thing to do (as noted in the FIXME) is to
have a real checker for too-large shifts.

llvm-svn: 199405
2014-01-16 18:02:23 +00:00

32 lines
1.1 KiB
C

// RUN: %clang_cc1 -analyze -analyzer-checker=core,debug.ExprInspection -triple x86_64-apple-darwin13 -Wno-shift-count-overflow -verify %s
void clang_analyzer_eval(int);
#define CHECK(expr) if (!(expr)) return; clang_analyzer_eval(expr)
void testPersistentConstraints(int x, int y) {
// Sanity check
CHECK(x); // expected-warning{{TRUE}}
CHECK(x & 1); // expected-warning{{TRUE}}
// False positives due to SValBuilder giving up on certain kinds of exprs.
CHECK(1 - x); // expected-warning{{UNKNOWN}}
CHECK(x & y); // expected-warning{{UNKNOWN}}
}
int testConstantShifts_PR18073(int which) {
// FIXME: We should have a checker that actually specifically checks bitwise
// shifts against the width of the LHS's /static/ type, rather than just
// having BasicValueFactory return "undefined" when dealing with two constant
// operands.
switch (which) {
case 1:
return 0ULL << 63; // no-warning
case 2:
return 0ULL << 64; // expected-warning{{The result of the '<<' expression is undefined}}
case 3:
return 0ULL << 65; // expected-warning{{The result of the '<<' expression is undefined}}
default:
return 0;
}
}