c1fa60b4cd
The MLIR classes Type/Attribute/Operation/Op/Value support cast/dyn_cast/isa/dyn_cast_or_null functionality through llvm's doCast functionality in addition to defining methods with the same name. This change begins the migration of uses of the method to the corresponding function call as has been decided as more consistent. Note that there still exist classes that only define methods directly, such as AffineExpr, and this does not include work currently to support a functional cast/isa call. Context: * https://mlir.llvm.org/deprecation/ at "Use the free function variants for dyn_cast/cast/isa/…" * Original discussion at https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443 Implementation: This follows a previous patch that updated calls `op.cast<T>()-> cast<T>(op)`. However some cases could not handle an unprefixed `cast` call due to occurrences of variables named cast, or occurring inside of class definitions which would resolve to the method. All C++ files that did not work automatically with `cast<T>()` are updated here to `llvm::cast` and similar with the intention that they can be easily updated after the methods are removed through a find-replace. See https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check for the clang-tidy check that is used and then update printed occurrences of the function to include `llvm::` before. One can then run the following: ``` ninja -C $BUILD_DIR clang-tidy run-clang-tidy -clang-tidy-binary=$BUILD_DIR/bin/clang-tidy -checks='-*,misc-cast-functions'\ -export-fixes /tmp/cast/casts.yaml mlir/*\ -header-filter=mlir/ -fix rm -rf $BUILD_DIR/tools/mlir/**/*.inc ``` Differential Revision: https://reviews.llvm.org/D150348
119 lines
4.0 KiB
C++
119 lines
4.0 KiB
C++
//===- BuiltinDialectBytecode.cpp - Builtin Bytecode Implementation -------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "BuiltinDialectBytecode.h"
|
|
#include "mlir/Bytecode/BytecodeImplementation.h"
|
|
#include "mlir/IR/BuiltinAttributes.h"
|
|
#include "mlir/IR/BuiltinDialect.h"
|
|
#include "mlir/IR/BuiltinTypes.h"
|
|
#include "mlir/IR/Diagnostics.h"
|
|
#include "mlir/IR/DialectResourceBlobManager.h"
|
|
#include "llvm/ADT/TypeSwitch.h"
|
|
|
|
using namespace mlir;
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// BuiltinDialectBytecodeInterface
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Utility functions
|
|
|
|
// TODO: Move these to separate file.
|
|
|
|
// Returns the bitwidth if known, else return 0.
|
|
static unsigned getIntegerBitWidth(DialectBytecodeReader &reader, Type type) {
|
|
if (auto intType = dyn_cast<IntegerType>(type)) {
|
|
return intType.getWidth();
|
|
} else if (llvm::isa<IndexType>(type)) {
|
|
return IndexType::kInternalStorageBitWidth;
|
|
}
|
|
reader.emitError()
|
|
<< "expected integer or index type for IntegerAttr, but got: " << type;
|
|
return 0;
|
|
}
|
|
|
|
static LogicalResult readAPIntWithKnownWidth(DialectBytecodeReader &reader,
|
|
Type type, FailureOr<APInt> &val) {
|
|
unsigned bitWidth = getIntegerBitWidth(reader, type);
|
|
if (bitWidth == 0)
|
|
return failure();
|
|
val = reader.readAPIntWithKnownWidth(bitWidth);
|
|
return val;
|
|
}
|
|
|
|
static LogicalResult
|
|
readAPFloatWithKnownSemantics(DialectBytecodeReader &reader, Type type,
|
|
FailureOr<APFloat> &val) {
|
|
auto ftype = dyn_cast<FloatType>(type);
|
|
if (!ftype)
|
|
return failure();
|
|
val = reader.readAPFloatWithKnownSemantics(ftype.getFloatSemantics());
|
|
return success();
|
|
}
|
|
|
|
LogicalResult
|
|
readPotentiallySplatString(DialectBytecodeReader &reader, ShapedType type,
|
|
bool isSplat,
|
|
SmallVectorImpl<StringRef> &rawStringData) {
|
|
rawStringData.resize(isSplat ? 1 : type.getNumElements());
|
|
for (StringRef &value : rawStringData)
|
|
if (failed(reader.readString(value)))
|
|
return failure();
|
|
return success();
|
|
}
|
|
|
|
void writePotentiallySplatString(DialectBytecodeWriter &writer,
|
|
DenseStringElementsAttr attr) {
|
|
bool isSplat = attr.isSplat();
|
|
if (isSplat)
|
|
return writer.writeOwnedString(attr.getRawStringData().front());
|
|
|
|
for (StringRef str : attr.getRawStringData())
|
|
writer.writeOwnedString(str);
|
|
}
|
|
|
|
#include "mlir/IR/BuiltinDialectBytecode.cpp.inc"
|
|
|
|
/// This class implements the bytecode interface for the builtin dialect.
|
|
struct BuiltinDialectBytecodeInterface : public BytecodeDialectInterface {
|
|
BuiltinDialectBytecodeInterface(Dialect *dialect)
|
|
: BytecodeDialectInterface(dialect) {}
|
|
|
|
//===--------------------------------------------------------------------===//
|
|
// Attributes
|
|
|
|
Attribute readAttribute(DialectBytecodeReader &reader) const override {
|
|
return ::readAttribute(getContext(), reader);
|
|
}
|
|
|
|
LogicalResult writeAttribute(Attribute attr,
|
|
DialectBytecodeWriter &writer) const override {
|
|
return ::writeAttribute(attr, writer);
|
|
}
|
|
|
|
//===--------------------------------------------------------------------===//
|
|
// Types
|
|
|
|
Type readType(DialectBytecodeReader &reader) const override {
|
|
return ::readType(getContext(), reader);
|
|
}
|
|
|
|
LogicalResult writeType(Type type,
|
|
DialectBytecodeWriter &writer) const override {
|
|
return ::writeType(type, writer);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
void builtin_dialect_detail::addBytecodeInterface(BuiltinDialect *dialect) {
|
|
dialect->addInterfaces<BuiltinDialectBytecodeInterface>();
|
|
}
|