0e2c5cda3c
Ignore false positives related to matching parameters of non coroutine functions and increase issue detection for cases involving type aliases with references. Fixes: #64915 Reviewed By: ccotter Differential Revision: https://reviews.llvm.org/D158665
37 lines
1.2 KiB
C++
37 lines
1.2 KiB
C++
//===--- AvoidReferenceCoroutineParametersCheck.cpp - clang-tidy ----------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "AvoidReferenceCoroutineParametersCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang::tidy::cppcoreguidelines {
|
|
|
|
void AvoidReferenceCoroutineParametersCheck::registerMatchers(
|
|
MatchFinder *Finder) {
|
|
Finder->addMatcher(
|
|
functionDecl(unless(parameterCountIs(0)), hasBody(coroutineBodyStmt()))
|
|
.bind("fnt"),
|
|
this);
|
|
}
|
|
|
|
void AvoidReferenceCoroutineParametersCheck::check(
|
|
const MatchFinder::MatchResult &Result) {
|
|
const auto *Function = Result.Nodes.getNodeAs<FunctionDecl>("fnt");
|
|
for (const ParmVarDecl *Param : Function->parameters()) {
|
|
if (!Param->getType().getCanonicalType()->isReferenceType())
|
|
continue;
|
|
|
|
diag(Param->getBeginLoc(), "coroutine parameters should not be references");
|
|
}
|
|
}
|
|
|
|
} // namespace clang::tidy::cppcoreguidelines
|