c64257b4b7
We stopped marking `__lldb_expr` with the function qualifiers of the method LLDB is stopped in ever since `8bdcd522510f923185cdfaec66c4a78d0a0d38c0`. The assumption was that it wasn't ever required for correctness (i.e., LLDB should just always pretend it's in a mutable context). But since function qualifiers affect overloading in C++, this assumption can lead to unexpected expression evaluator behaviour. E.g., if a function is overloaded on qualifiers (`const` vs. `non-const`), the expression evaluator would currently always call the non-CV qualified overload. This patch adds function qualifiers to `$__lldb_class::$__lldb_expr` that resemble the qualifiers of the method that we're stopped in. However, mutating variables or calling arbitrary member functions from CV-qualified methods can be useful/is something users already may be used to. To provide users with the ability to ignore the CV-qualifiers of the current context, we will provide an expression evaluator flag that switches this off in a follow-up patch.
106 lines
3.3 KiB
Python
106 lines
3.3 KiB
Python
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestCase(TestBase):
|
|
def test(self):
|
|
self.build()
|
|
(_, process, _, _) = lldbutil.run_to_source_breakpoint(
|
|
self, "Break: const_method begin", lldb.SBFileSpec("main.cpp")
|
|
)
|
|
|
|
self.expect_expr("bar()", result_value="2", result_type="int")
|
|
self.expect(
|
|
"expression m_const_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member",
|
|
"with const-qualified type",
|
|
],
|
|
)
|
|
self.expect(
|
|
"expression m_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member within const member function"
|
|
],
|
|
)
|
|
self.expect_expr("((Foo*)this)->bar()", result_type="double", result_value="5")
|
|
|
|
lldbutil.continue_to_source_breakpoint(
|
|
self,
|
|
process,
|
|
"Break: const_method no-this lambda",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
|
|
self.expect(
|
|
"expression x = 7.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member within const member function"
|
|
],
|
|
)
|
|
|
|
lldbutil.continue_to_source_breakpoint(
|
|
self,
|
|
process,
|
|
"Break: const_method mutable no-this lambda",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
|
|
self.expect_expr("x = 7.0; x", result_value="7")
|
|
|
|
lldbutil.continue_to_source_breakpoint(
|
|
self, process, "Break: const_method lambda", lldb.SBFileSpec("main.cpp")
|
|
)
|
|
|
|
# FIXME: mutating this capture should be disallowed in a non-mutable lambda.
|
|
self.expect_expr("y = 8.0")
|
|
self.expect_expr("bar()", result_value="2", result_type="int")
|
|
self.expect(
|
|
"expression m_const_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member",
|
|
"with const-qualified type",
|
|
],
|
|
)
|
|
self.expect(
|
|
"expression m_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member within const member function"
|
|
],
|
|
)
|
|
self.expect_expr("m_mem", result_value="-2")
|
|
self.expect_expr("((Foo*)this)->bar()", result_type="double", result_value="5")
|
|
|
|
lldbutil.continue_to_source_breakpoint(
|
|
self,
|
|
process,
|
|
"Break: const_method mutable lambda",
|
|
lldb.SBFileSpec("main.cpp"),
|
|
)
|
|
|
|
self.expect_expr("y = 9.0")
|
|
self.expect_expr("bar()", result_value="2", result_type="int")
|
|
self.expect(
|
|
"expression m_const_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member",
|
|
"with const-qualified type",
|
|
],
|
|
)
|
|
self.expect(
|
|
"expression m_mem = 2.0",
|
|
error=True,
|
|
substrs=[
|
|
"cannot assign to non-static data member within const member function"
|
|
],
|
|
)
|
|
self.expect_expr("m_mem", result_value="-2")
|