Jonas Devlieghere c69307e5ee
[lldb] Prevent object file plugins from changing the data buffer
The current design allows that the object file contents could be mapped
by one object file plugin and then used by another. Presumably the idea
here was to avoid mapping the same file twice.

This becomes an issue when one object file plugin wants to map the file
differently from the others. For example, ObjectFileELF needs to map its
memory as writable while others likeObjectFileMachO needs it to be
mapped read-only.

This patch prevents plugins from changing the buffer by passing them is
by value rather than by reference.

Differential revision: https://reviews.llvm.org/D122944
2022-04-04 09:24:24 -07:00

115 lines
3.3 KiB
C++

//===-- ObjectFileMinidump.cpp --------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "ObjectFileMinidump.h"
#include "MinidumpFileBuilder.h"
#include "lldb/Core/ModuleSpec.h"
#include "lldb/Core/PluginManager.h"
#include "lldb/Core/Section.h"
#include "lldb/Target/Process.h"
#include "llvm/Support/FileSystem.h"
using namespace lldb;
using namespace lldb_private;
LLDB_PLUGIN_DEFINE(ObjectFileMinidump)
void ObjectFileMinidump::Initialize() {
PluginManager::RegisterPlugin(
GetPluginNameStatic(), GetPluginDescriptionStatic(), CreateInstance,
CreateMemoryInstance, GetModuleSpecifications, SaveCore);
}
void ObjectFileMinidump::Terminate() {
PluginManager::UnregisterPlugin(CreateInstance);
}
ObjectFile *ObjectFileMinidump::CreateInstance(
const lldb::ModuleSP &module_sp, lldb::DataBufferSP data_sp,
lldb::offset_t data_offset, const lldb_private::FileSpec *file,
lldb::offset_t offset, lldb::offset_t length) {
return nullptr;
}
ObjectFile *ObjectFileMinidump::CreateMemoryInstance(
const lldb::ModuleSP &module_sp, DataBufferSP data_sp,
const ProcessSP &process_sp, lldb::addr_t header_addr) {
return nullptr;
}
size_t ObjectFileMinidump::GetModuleSpecifications(
const lldb_private::FileSpec &file, lldb::DataBufferSP &data_sp,
lldb::offset_t data_offset, lldb::offset_t file_offset,
lldb::offset_t length, lldb_private::ModuleSpecList &specs) {
specs.Clear();
return 0;
}
bool ObjectFileMinidump::SaveCore(const lldb::ProcessSP &process_sp,
const lldb_private::FileSpec &outfile,
lldb::SaveCoreStyle &core_style,
lldb_private::Status &error) {
if (core_style != SaveCoreStyle::eSaveCoreStackOnly) {
error.SetErrorString("Only stack minidumps supported yet.");
return false;
}
if (!process_sp)
return false;
MinidumpFileBuilder builder;
Target &target = process_sp->GetTarget();
error = builder.AddSystemInfo(target.GetArchitecture().GetTriple());
if (error.Fail())
return false;
error = builder.AddModuleList(target);
if (error.Fail())
return false;
builder.AddMiscInfo(process_sp);
if (target.GetArchitecture().GetMachine() == llvm::Triple::ArchType::x86_64) {
error = builder.AddThreadList(process_sp);
if (error.Fail())
return false;
error = builder.AddException(process_sp);
if (error.Fail())
return false;
error = builder.AddMemoryList(process_sp);
if (error.Fail())
return false;
}
if (target.GetArchitecture().GetTriple().getOS() ==
llvm::Triple::OSType::Linux) {
builder.AddLinuxFileStreams(process_sp);
}
llvm::Expected<lldb::FileUP> maybe_core_file = FileSystem::Instance().Open(
outfile, File::eOpenOptionWriteOnly | File::eOpenOptionCanCreate);
if (!maybe_core_file) {
error = maybe_core_file.takeError();
return false;
}
lldb::FileUP core_file = std::move(maybe_core_file.get());
error = builder.Dump(core_file);
if (error.Fail())
return false;
return true;
}