Summary: Previously the ABI plugin exposed some "register infos" and the gdb-remote code used those to fill in the missing bits. Now, the "filling in" code is in the ABI plugin itself, and the gdb-remote code just invokes that. The motivation for this is two-fold: a) the "augmentation" logic is useful outside of process gdb-remote. For instance, it would allow us to avoid repeating the register number definitions in minidump code. b) It gives more implementation freedom to the ABI classes. Now that these "register infos" are essentially implementation details, classes can use other methods to obtain dwarf/eh_frame register numbers -- for instance they can consult llvm MC layer. Since the augmentation code was not currently tested anywhere, I took the opportunity to create a simple test for it. Reviewers: jasonmolenda, clayborg, tatyana-krasnukha Subscribers: aprantl, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D70906
231 lines
7.6 KiB
C++
231 lines
7.6 KiB
C++
//===-- ABI.cpp -------------------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Target/ABI.h"
|
|
#include "lldb/Core/PluginManager.h"
|
|
#include "lldb/Core/Value.h"
|
|
#include "lldb/Core/ValueObjectConstResult.h"
|
|
#include "lldb/Expression/ExpressionVariable.h"
|
|
#include "lldb/Symbol/CompilerType.h"
|
|
#include "lldb/Symbol/TypeSystem.h"
|
|
#include "lldb/Target/Target.h"
|
|
#include "lldb/Target/Thread.h"
|
|
#include "lldb/Utility/Log.h"
|
|
#include "llvm/Support/TargetRegistry.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
ABISP
|
|
ABI::FindPlugin(lldb::ProcessSP process_sp, const ArchSpec &arch) {
|
|
ABISP abi_sp;
|
|
ABICreateInstance create_callback;
|
|
|
|
for (uint32_t idx = 0;
|
|
(create_callback = PluginManager::GetABICreateCallbackAtIndex(idx)) !=
|
|
nullptr;
|
|
++idx) {
|
|
abi_sp = create_callback(process_sp, arch);
|
|
|
|
if (abi_sp)
|
|
return abi_sp;
|
|
}
|
|
abi_sp.reset();
|
|
return abi_sp;
|
|
}
|
|
|
|
ABI::~ABI() = default;
|
|
|
|
bool ABI::GetRegisterInfoByName(ConstString name, RegisterInfo &info) {
|
|
uint32_t count = 0;
|
|
const RegisterInfo *register_info_array = GetRegisterInfoArray(count);
|
|
if (register_info_array) {
|
|
const char *unique_name_cstr = name.GetCString();
|
|
uint32_t i;
|
|
for (i = 0; i < count; ++i) {
|
|
if (register_info_array[i].name == unique_name_cstr) {
|
|
info = register_info_array[i];
|
|
return true;
|
|
}
|
|
}
|
|
for (i = 0; i < count; ++i) {
|
|
if (register_info_array[i].alt_name == unique_name_cstr) {
|
|
info = register_info_array[i];
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
ValueObjectSP ABI::GetReturnValueObject(Thread &thread, CompilerType &ast_type,
|
|
bool persistent) const {
|
|
if (!ast_type.IsValid())
|
|
return ValueObjectSP();
|
|
|
|
ValueObjectSP return_valobj_sp;
|
|
|
|
return_valobj_sp = GetReturnValueObjectImpl(thread, ast_type);
|
|
if (!return_valobj_sp)
|
|
return return_valobj_sp;
|
|
|
|
// Now turn this into a persistent variable.
|
|
// FIXME: This code is duplicated from Target::EvaluateExpression, and it is
|
|
// used in similar form in a couple
|
|
// of other places. Figure out the correct Create function to do all this
|
|
// work.
|
|
|
|
if (persistent) {
|
|
Target &target = *thread.CalculateTarget();
|
|
PersistentExpressionState *persistent_expression_state =
|
|
target.GetPersistentExpressionStateForLanguage(
|
|
ast_type.GetMinimumLanguage());
|
|
|
|
if (!persistent_expression_state)
|
|
return ValueObjectSP();
|
|
|
|
auto prefix = persistent_expression_state->GetPersistentVariablePrefix();
|
|
ConstString persistent_variable_name =
|
|
persistent_expression_state->GetNextPersistentVariableName(target,
|
|
prefix);
|
|
|
|
lldb::ValueObjectSP const_valobj_sp;
|
|
|
|
// Check in case our value is already a constant value
|
|
if (return_valobj_sp->GetIsConstant()) {
|
|
const_valobj_sp = return_valobj_sp;
|
|
const_valobj_sp->SetName(persistent_variable_name);
|
|
} else
|
|
const_valobj_sp =
|
|
return_valobj_sp->CreateConstantValue(persistent_variable_name);
|
|
|
|
lldb::ValueObjectSP live_valobj_sp = return_valobj_sp;
|
|
|
|
return_valobj_sp = const_valobj_sp;
|
|
|
|
ExpressionVariableSP expr_variable_sp(
|
|
persistent_expression_state->CreatePersistentVariable(
|
|
return_valobj_sp));
|
|
|
|
assert(expr_variable_sp);
|
|
|
|
// Set flags and live data as appropriate
|
|
|
|
const Value &result_value = live_valobj_sp->GetValue();
|
|
|
|
switch (result_value.GetValueType()) {
|
|
case Value::eValueTypeHostAddress:
|
|
case Value::eValueTypeFileAddress:
|
|
// we don't do anything with these for now
|
|
break;
|
|
case Value::eValueTypeScalar:
|
|
case Value::eValueTypeVector:
|
|
expr_variable_sp->m_flags |=
|
|
ExpressionVariable::EVIsFreezeDried;
|
|
expr_variable_sp->m_flags |=
|
|
ExpressionVariable::EVIsLLDBAllocated;
|
|
expr_variable_sp->m_flags |=
|
|
ExpressionVariable::EVNeedsAllocation;
|
|
break;
|
|
case Value::eValueTypeLoadAddress:
|
|
expr_variable_sp->m_live_sp = live_valobj_sp;
|
|
expr_variable_sp->m_flags |=
|
|
ExpressionVariable::EVIsProgramReference;
|
|
break;
|
|
}
|
|
|
|
return_valobj_sp = expr_variable_sp->GetValueObject();
|
|
}
|
|
return return_valobj_sp;
|
|
}
|
|
|
|
ValueObjectSP ABI::GetReturnValueObject(Thread &thread, llvm::Type &ast_type,
|
|
bool persistent) const {
|
|
ValueObjectSP return_valobj_sp;
|
|
return_valobj_sp = GetReturnValueObjectImpl(thread, ast_type);
|
|
return return_valobj_sp;
|
|
}
|
|
|
|
// specialized to work with llvm IR types
|
|
//
|
|
// for now we will specify a default implementation so that we don't need to
|
|
// modify other ABIs
|
|
lldb::ValueObjectSP ABI::GetReturnValueObjectImpl(Thread &thread,
|
|
llvm::Type &ir_type) const {
|
|
ValueObjectSP return_valobj_sp;
|
|
|
|
/* this is a dummy and will only be called if an ABI does not override this */
|
|
|
|
return return_valobj_sp;
|
|
}
|
|
|
|
bool ABI::PrepareTrivialCall(Thread &thread, lldb::addr_t sp,
|
|
lldb::addr_t functionAddress,
|
|
lldb::addr_t returnAddress, llvm::Type &returntype,
|
|
llvm::ArrayRef<ABI::CallArgument> args) const {
|
|
// dummy prepare trivial call
|
|
llvm_unreachable("Should never get here!");
|
|
}
|
|
|
|
bool ABI::GetFallbackRegisterLocation(
|
|
const RegisterInfo *reg_info,
|
|
UnwindPlan::Row::RegisterLocation &unwind_regloc) {
|
|
// Did the UnwindPlan fail to give us the caller's stack pointer? The stack
|
|
// pointer is defined to be the same as THIS frame's CFA, so return the CFA
|
|
// value as the caller's stack pointer. This is true on x86-32/x86-64 at
|
|
// least.
|
|
if (reg_info->kinds[eRegisterKindGeneric] == LLDB_REGNUM_GENERIC_SP) {
|
|
unwind_regloc.SetIsCFAPlusOffset(0);
|
|
return true;
|
|
}
|
|
|
|
// If a volatile register is being requested, we don't want to forward the
|
|
// next frame's register contents up the stack -- the register is not
|
|
// retrievable at this frame.
|
|
if (RegisterIsVolatile(reg_info)) {
|
|
unwind_regloc.SetUndefined();
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
std::unique_ptr<llvm::MCRegisterInfo> ABI::MakeMCRegisterInfo(const ArchSpec &arch) {
|
|
std::string triple = arch.GetTriple().getTriple();
|
|
std::string lookup_error;
|
|
const llvm::Target *target =
|
|
llvm::TargetRegistry::lookupTarget(triple, lookup_error);
|
|
if (!target) {
|
|
LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_PROCESS),
|
|
"Failed to create an llvm target for {0}: {1}", triple,
|
|
lookup_error);
|
|
return nullptr;
|
|
}
|
|
std::unique_ptr<llvm::MCRegisterInfo> info_up(
|
|
target->createMCRegInfo(triple));
|
|
assert(info_up);
|
|
return info_up;
|
|
}
|
|
|
|
void ABI::AugmentRegisterInfo(RegisterInfo &info) {
|
|
if (info.kinds[eRegisterKindEHFrame] != LLDB_INVALID_REGNUM &&
|
|
info.kinds[eRegisterKindDWARF] != LLDB_INVALID_REGNUM)
|
|
return;
|
|
|
|
RegisterInfo abi_info;
|
|
if (!GetRegisterInfoByName(ConstString(info.name), abi_info))
|
|
return;
|
|
|
|
if (info.kinds[eRegisterKindEHFrame] == LLDB_INVALID_REGNUM)
|
|
info.kinds[eRegisterKindEHFrame] = abi_info.kinds[eRegisterKindEHFrame];
|
|
if (info.kinds[eRegisterKindDWARF] == LLDB_INVALID_REGNUM)
|
|
info.kinds[eRegisterKindDWARF] = abi_info.kinds[eRegisterKindDWARF];
|
|
if (info.kinds[eRegisterKindGeneric] == LLDB_INVALID_REGNUM)
|
|
info.kinds[eRegisterKindGeneric] = abi_info.kinds[eRegisterKindGeneric];
|
|
}
|