987d331fab
Summary: The motivating use case is eliminating duplicate profile data registered for the same inline function in two object files. Before this change, users would observe multiple symbol definition errors with VC link, but links with LLD would succeed. Users (Mozilla) have reported that PGO works well with clang-cl and LLD, but when using LLD without this static registration, we would get into a "relocation against a discarded section" situation. I'm not sure what happens in that situation, but I suspect that duplicate, unused profile information was retained. If so, this change will reduce the size of such binaries with LLD. Now, Windows uses static registration and is in line with all the other platforms. Reviewers: davidxl, wmi, inglorion, void, calixte Subscribers: mgorny, krytarowski, eraman, fedor.sergeev, hiraditya, #sanitizers, dmajor, llvm-commits Tags: #sanitizers, #llvm Differential Revision: https://reviews.llvm.org/D57929 llvm-svn: 353547
66 lines
2.4 KiB
C
66 lines
2.4 KiB
C
/*===- InstrProfilingPlatformWindows.c - Profile data on Windows ----------===*\
|
|
|*
|
|
|* Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
|* See https://llvm.org/LICENSE.txt for license information.
|
|
|* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
|*
|
|
\*===----------------------------------------------------------------------===*/
|
|
|
|
#include "InstrProfiling.h"
|
|
|
|
#if defined(_WIN32)
|
|
|
|
#if defined(_MSC_VER)
|
|
/* Merge read-write sections into .data. */
|
|
#pragma comment(linker, "/MERGE:.lprfc=.data")
|
|
#pragma comment(linker, "/MERGE:.lprfd=.data")
|
|
#pragma comment(linker, "/MERGE:.lprfv=.data")
|
|
#pragma comment(linker, "/MERGE:.lprfnd=.data")
|
|
/* Merge read-only sections into .rdata. */
|
|
#pragma comment(linker, "/MERGE:.lprfn=.rdata")
|
|
#pragma comment(linker, "/MERGE:.lcovmap=.rdata")
|
|
|
|
/* Allocate read-only section bounds. */
|
|
#pragma section(".lprfn$A", read)
|
|
#pragma section(".lprfn$Z", read)
|
|
|
|
/* Allocate read-write section bounds. */
|
|
#pragma section(".lprfd$A", read, write)
|
|
#pragma section(".lprfd$Z", read, write)
|
|
#pragma section(".lprfc$A", read, write)
|
|
#pragma section(".lprfc$Z", read, write)
|
|
#pragma section(".lprfnd$A", read, write)
|
|
#pragma section(".lprfnd$Z", read, write)
|
|
#endif
|
|
|
|
__llvm_profile_data COMPILER_RT_SECTION(".lprfd$A") DataStart = {0};
|
|
__llvm_profile_data COMPILER_RT_SECTION(".lprfd$Z") DataEnd = {0};
|
|
|
|
const char COMPILER_RT_SECTION(".lprfn$A") NamesStart = '\0';
|
|
const char COMPILER_RT_SECTION(".lprfn$Z") NamesEnd = '\0';
|
|
|
|
uint64_t COMPILER_RT_SECTION(".lprfc$A") CountersStart;
|
|
uint64_t COMPILER_RT_SECTION(".lprfc$Z") CountersEnd;
|
|
|
|
ValueProfNode COMPILER_RT_SECTION(".lprfnd$A") VNodesStart;
|
|
ValueProfNode COMPILER_RT_SECTION(".lprfnd$Z") VNodesEnd;
|
|
|
|
const __llvm_profile_data *__llvm_profile_begin_data(void) {
|
|
return &DataStart + 1;
|
|
}
|
|
const __llvm_profile_data *__llvm_profile_end_data(void) { return &DataEnd; }
|
|
|
|
const char *__llvm_profile_begin_names(void) { return &NamesStart + 1; }
|
|
const char *__llvm_profile_end_names(void) { return &NamesEnd; }
|
|
|
|
uint64_t *__llvm_profile_begin_counters(void) { return &CountersStart + 1; }
|
|
uint64_t *__llvm_profile_end_counters(void) { return &CountersEnd; }
|
|
|
|
ValueProfNode *__llvm_profile_begin_vnodes(void) { return &VNodesStart + 1; }
|
|
ValueProfNode *__llvm_profile_end_vnodes(void) { return &VNodesEnd; }
|
|
|
|
ValueProfNode *CurrentVNode = &VNodesStart + 1;
|
|
ValueProfNode *EndVNode = &VNodesEnd;
|
|
|
|
#endif
|