cac5be495e
Checks for some thread-unsafe functions against a black list of known-to-be-unsafe functions. Usually they access static variables without synchronization (e.g. gmtime(3)) or utilize signals in a racy way (e.g. sleep(3)). The patch adds a check instead of auto-fix as thread-safe alternatives usually have API with an additional argument (e.g. gmtime(3) v.s. gmtime_r(3)) or have a different semantics (e.g. exit(3) v.s. __exit(3)), so it is a rather tricky or non-expected fix. An option specifies which functions in libc should be considered thread-safe, possible values are `posix`, `glibc`, or `any` (the most strict check). It defaults to 'any' as it is unknown what target libc type is - clang-tidy may be run on linux but check sources compiled for other *NIX. The check is used in Yandex Taxi backend and has caught many unpleasant bugs. A similar patch for coroutine-unsafe API is coming next. Reviewed By: lebedev.ri Differential Revision: https://reviews.llvm.org/D90944
38 lines
1.2 KiB
C++
38 lines
1.2 KiB
C++
//===--- ConcurrencyTidyModule.cpp - clang-tidy ---------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "MtUnsafeCheck.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace concurrency {
|
|
|
|
class ConcurrencyModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.registerCheck<concurrency::MtUnsafeCheck>(
|
|
"concurrency-mt-unsafe");
|
|
}
|
|
};
|
|
|
|
} // namespace concurrency
|
|
|
|
// Register the ConcurrencyTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<concurrency::ConcurrencyModule>
|
|
X("concurrency-module", "Adds concurrency checks.");
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the ConcurrencyModule.
|
|
volatile int ConcurrencyModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|