a20168d030
When adding an archive member with a problem, e.g. a new bitcode with an old archiver, containing an unsupported attribute, or an ELF file with a malformed symbol table, the archiver would throw away the error and simply add the member to the archive without any symbol entries. This meant that the resultant archive could be silently unusable when not using --whole-archive, and result in unexpected undefined symbols. This change fixes this issue by addressing two FIXMEs and only throwing away not-an-object errors. However, this meant that some LLD tests which didn't need symbol tables and were using invalid members deliberately to test the linker's malformed input handling no longer worked, so this patch also stops the archiver from looking for symbols in an object if it doesn't require a symbol table, and updates the tests accordingly. Differential Revision: https://reviews.llvm.org/D88288 Reviewed by: grimar, rupprecht, MaskRay
128 lines
4.3 KiB
C++
128 lines
4.3 KiB
C++
//===- SymbolicFile.cpp - Interface that only provides symbols ------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines a file format independent SymbolicFile class.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/Object/SymbolicFile.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "llvm/BinaryFormat/Magic.h"
|
|
#include "llvm/Object/COFFImportFile.h"
|
|
#include "llvm/Object/Error.h"
|
|
#include "llvm/Object/IRObjectFile.h"
|
|
#include "llvm/Object/ObjectFile.h"
|
|
#include "llvm/Support/Compiler.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/ErrorOr.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/MemoryBuffer.h"
|
|
#include <algorithm>
|
|
#include <memory>
|
|
|
|
using namespace llvm;
|
|
using namespace object;
|
|
|
|
SymbolicFile::SymbolicFile(unsigned int Type, MemoryBufferRef Source)
|
|
: Binary(Type, Source) {}
|
|
|
|
SymbolicFile::~SymbolicFile() = default;
|
|
|
|
Expected<std::unique_ptr<SymbolicFile>>
|
|
SymbolicFile::createSymbolicFile(MemoryBufferRef Object, file_magic Type,
|
|
LLVMContext *Context) {
|
|
StringRef Data = Object.getBuffer();
|
|
if (Type == file_magic::unknown)
|
|
Type = identify_magic(Data);
|
|
|
|
if (!isSymbolicFile(Type, Context))
|
|
return errorCodeToError(object_error::invalid_file_type);
|
|
|
|
switch (Type) {
|
|
case file_magic::bitcode:
|
|
// Context is guaranteed to be non-null here, because bitcode magic only
|
|
// indicates a symbolic file when Context is non-null.
|
|
return IRObjectFile::create(Object, *Context);
|
|
case file_magic::elf:
|
|
case file_magic::elf_executable:
|
|
case file_magic::elf_shared_object:
|
|
case file_magic::elf_core:
|
|
case file_magic::macho_executable:
|
|
case file_magic::macho_fixed_virtual_memory_shared_lib:
|
|
case file_magic::macho_core:
|
|
case file_magic::macho_preload_executable:
|
|
case file_magic::macho_dynamically_linked_shared_lib:
|
|
case file_magic::macho_dynamic_linker:
|
|
case file_magic::macho_bundle:
|
|
case file_magic::macho_dynamically_linked_shared_lib_stub:
|
|
case file_magic::macho_dsym_companion:
|
|
case file_magic::macho_kext_bundle:
|
|
case file_magic::pecoff_executable:
|
|
case file_magic::xcoff_object_32:
|
|
case file_magic::xcoff_object_64:
|
|
case file_magic::wasm_object:
|
|
return ObjectFile::createObjectFile(Object, Type);
|
|
case file_magic::coff_import_library:
|
|
return std::unique_ptr<SymbolicFile>(new COFFImportFile(Object));
|
|
case file_magic::elf_relocatable:
|
|
case file_magic::macho_object:
|
|
case file_magic::coff_object: {
|
|
Expected<std::unique_ptr<ObjectFile>> Obj =
|
|
ObjectFile::createObjectFile(Object, Type);
|
|
if (!Obj || !Context)
|
|
return std::move(Obj);
|
|
|
|
Expected<MemoryBufferRef> BCData =
|
|
IRObjectFile::findBitcodeInObject(*Obj->get());
|
|
if (!BCData) {
|
|
consumeError(BCData.takeError());
|
|
return std::move(Obj);
|
|
}
|
|
|
|
return IRObjectFile::create(
|
|
MemoryBufferRef(BCData->getBuffer(), Object.getBufferIdentifier()),
|
|
*Context);
|
|
}
|
|
default:
|
|
llvm_unreachable("Unexpected Binary File Type");
|
|
}
|
|
}
|
|
|
|
bool SymbolicFile::isSymbolicFile(file_magic Type, const LLVMContext *Context) {
|
|
switch (Type) {
|
|
case file_magic::bitcode:
|
|
return Context != nullptr;
|
|
case file_magic::elf:
|
|
case file_magic::elf_executable:
|
|
case file_magic::elf_shared_object:
|
|
case file_magic::elf_core:
|
|
case file_magic::macho_executable:
|
|
case file_magic::macho_fixed_virtual_memory_shared_lib:
|
|
case file_magic::macho_core:
|
|
case file_magic::macho_preload_executable:
|
|
case file_magic::macho_dynamically_linked_shared_lib:
|
|
case file_magic::macho_dynamic_linker:
|
|
case file_magic::macho_bundle:
|
|
case file_magic::macho_dynamically_linked_shared_lib_stub:
|
|
case file_magic::macho_dsym_companion:
|
|
case file_magic::macho_kext_bundle:
|
|
case file_magic::pecoff_executable:
|
|
case file_magic::xcoff_object_32:
|
|
case file_magic::xcoff_object_64:
|
|
case file_magic::wasm_object:
|
|
case file_magic::coff_import_library:
|
|
case file_magic::elf_relocatable:
|
|
case file_magic::macho_object:
|
|
case file_magic::coff_object:
|
|
return true;
|
|
default:
|
|
return false;
|
|
}
|
|
}
|