In [1], a few new insns are proposed to expand BPF ISA to
. fixing the limitation of existing insn (e.g., 16bit jmp offset)
. adding new insns which may improve code quality
(sign_ext_ld, sign_ext_mov, st)
. feature complete (sdiv, smod)
. better user experience (bswap)
This patch implemented insn encoding for
. sign-extended load
. sign-extended mov
. sdiv/smod
. bswap insns
. unconditional jump with 32bit offset
The new bswap insns are generated under cpu=v4 for __builtin_bswap.
For cpu=v3 or earlier, for __builtin_bswap, be or le insns are generated
which is not intuitive for the user.
To support 32-bit branch offset, a 32-bit ja (JMPL) insn is implemented.
For conditional branch which is beyond 16-bit offset, llvm will do
some transformation 'cond_jmp' -> 'cond_jmp + jmpl' to simulate 32bit
conditional jmp. See BPFMIPeephole.cpp for details. The algorithm is
hueristic based. I have tested bpf selftest pyperf600 with unroll account
600 which can indeed generate 32-bit jump insn, e.g.,
13: 06 00 00 00 9b cd 00 00 gotol +0xcd9b <LBB0_6619>
Eduard is working on to add 'st' insn to cpu=v4.
A list of llc flags:
disable-ldsx, disable-movsx, disable-bswap,
disable-sdiv-smod, disable-gotol
can be used to disable a particular insn for cpu v4.
For example, user can do:
llc -march=bpf -mcpu=v4 -disable-movsx t.ll
to enable cpu v4 without movsx insns.
References:
[1] https://lore.kernel.org/bpf/4bfe98be-5333-1c7e-2f6d-42486c8ec039@meta.com/
Differential Revision: https://reviews.llvm.org/D144829
118 lines
3.5 KiB
C++
118 lines
3.5 KiB
C++
//===-- BPFInstPrinter.cpp - Convert BPF MCInst to asm syntax -------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This class prints an BPF MCInst to a .s file.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
#include "BPF.h"
|
|
#include "MCTargetDesc/BPFInstPrinter.h"
|
|
#include "llvm/MC/MCAsmInfo.h"
|
|
#include "llvm/MC/MCExpr.h"
|
|
#include "llvm/MC/MCInst.h"
|
|
#include "llvm/MC/MCRegister.h"
|
|
#include "llvm/MC/MCSymbol.h"
|
|
#include "llvm/Support/Casting.h"
|
|
#include "llvm/Support/ErrorHandling.h"
|
|
#include "llvm/Support/FormattedStream.h"
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "asm-printer"
|
|
|
|
// Include the auto-generated portion of the assembly writer.
|
|
#include "BPFGenAsmWriter.inc"
|
|
|
|
void BPFInstPrinter::printInst(const MCInst *MI, uint64_t Address,
|
|
StringRef Annot, const MCSubtargetInfo &STI,
|
|
raw_ostream &O) {
|
|
printInstruction(MI, Address, O);
|
|
printAnnotation(O, Annot);
|
|
}
|
|
|
|
static void printExpr(const MCExpr *Expr, raw_ostream &O) {
|
|
#ifndef NDEBUG
|
|
const MCSymbolRefExpr *SRE;
|
|
|
|
if (const MCBinaryExpr *BE = dyn_cast<MCBinaryExpr>(Expr))
|
|
SRE = dyn_cast<MCSymbolRefExpr>(BE->getLHS());
|
|
else
|
|
SRE = dyn_cast<MCSymbolRefExpr>(Expr);
|
|
assert(SRE && "Unexpected MCExpr type.");
|
|
|
|
MCSymbolRefExpr::VariantKind Kind = SRE->getKind();
|
|
|
|
assert(Kind == MCSymbolRefExpr::VK_None);
|
|
#endif
|
|
O << *Expr;
|
|
}
|
|
|
|
void BPFInstPrinter::printOperand(const MCInst *MI, unsigned OpNo,
|
|
raw_ostream &O, const char *Modifier) {
|
|
assert((Modifier == nullptr || Modifier[0] == 0) && "No modifiers supported");
|
|
const MCOperand &Op = MI->getOperand(OpNo);
|
|
if (Op.isReg()) {
|
|
O << getRegisterName(Op.getReg());
|
|
} else if (Op.isImm()) {
|
|
O << formatImm((int32_t)Op.getImm());
|
|
} else {
|
|
assert(Op.isExpr() && "Expected an expression");
|
|
printExpr(Op.getExpr(), O);
|
|
}
|
|
}
|
|
|
|
void BPFInstPrinter::printMemOperand(const MCInst *MI, int OpNo, raw_ostream &O,
|
|
const char *Modifier) {
|
|
const MCOperand &RegOp = MI->getOperand(OpNo);
|
|
const MCOperand &OffsetOp = MI->getOperand(OpNo + 1);
|
|
|
|
// register
|
|
assert(RegOp.isReg() && "Register operand not a register");
|
|
O << getRegisterName(RegOp.getReg());
|
|
|
|
// offset
|
|
if (OffsetOp.isImm()) {
|
|
auto Imm = OffsetOp.getImm();
|
|
if (Imm >= 0)
|
|
O << " + " << formatImm(Imm);
|
|
else
|
|
O << " - " << formatImm(-Imm);
|
|
} else {
|
|
assert(0 && "Expected an immediate");
|
|
}
|
|
}
|
|
|
|
void BPFInstPrinter::printImm64Operand(const MCInst *MI, unsigned OpNo,
|
|
raw_ostream &O) {
|
|
const MCOperand &Op = MI->getOperand(OpNo);
|
|
if (Op.isImm())
|
|
O << formatImm(Op.getImm());
|
|
else if (Op.isExpr())
|
|
printExpr(Op.getExpr(), O);
|
|
else
|
|
O << Op;
|
|
}
|
|
|
|
void BPFInstPrinter::printBrTargetOperand(const MCInst *MI, unsigned OpNo,
|
|
raw_ostream &O) {
|
|
const MCOperand &Op = MI->getOperand(OpNo);
|
|
if (Op.isImm()) {
|
|
if (MI->getOpcode() == BPF::JMPL) {
|
|
int32_t Imm = Op.getImm();
|
|
O << ((Imm >= 0) ? "+" : "") << formatImm(Imm);
|
|
} else {
|
|
int16_t Imm = Op.getImm();
|
|
O << ((Imm >= 0) ? "+" : "") << formatImm(Imm);
|
|
}
|
|
} else if (Op.isExpr()) {
|
|
printExpr(Op.getExpr(), O);
|
|
} else {
|
|
O << Op;
|
|
}
|
|
}
|