Peng Liu cf9806eb4d
[libc++] Fix UB in bitwise logic of {std, ranges}::{fill, fill_n} algorithms (#122410)
This PR addresses an undefined behavior that arises when using the
`std::fill` and `std::fill_n` algorithms, as well as their ranges
counterparts `ranges::fill` and `ranges::fill_n`, with `vector<bool, Alloc>`
that utilizes a custom-sized allocator with small integral types.
2025-02-05 11:39:49 -05:00

144 lines
4.4 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// <algorithm>
// template<ForwardIterator Iter, class T>
// requires OutputIterator<Iter, const T&>
// constexpr void // constexpr after C++17
// fill(Iter first, Iter last, const T& value);
#include <algorithm>
#include <array>
#include <cassert>
#include <cstddef>
#include <vector>
#include "sized_allocator.h"
#include "test_macros.h"
#include "test_iterators.h"
template <class Iter, class Container>
TEST_CONSTEXPR_CXX20 void
test(Container in, size_t from, size_t to, typename Container::value_type value, Container expected) {
std::fill(Iter(in.data() + from), Iter(in.data() + to), value);
assert(in == expected);
}
template <class T>
struct Test {
template <class Iter>
TEST_CONSTEXPR_CXX20 void operator()() {
{
std::array<T, 4> in = {1, 2, 3, 4};
std::array<T, 4> expected = {5, 5, 5, 5};
test<Iter>(in, 0, 4, 5, expected);
}
{
std::array<T, 4> in = {1, 2, 3, 4};
std::array<T, 4> expected = {1, 5, 5, 4};
test<Iter>(in, 1, 3, 5, expected);
}
}
};
// Make sure std::fill behaves properly with std::vector<bool> iterators with custom size types.
// See https://github.com/llvm/llvm-project/pull/122410.
TEST_CONSTEXPR_CXX20 void test_bititer_with_custom_sized_types() {
{
using Alloc = sized_allocator<bool, std::uint8_t, std::int8_t>;
std::vector<bool, Alloc> in(100, false, Alloc(1));
std::vector<bool, Alloc> expected(100, true, Alloc(1));
std::fill(in.begin(), in.end(), true);
assert(in == expected);
}
{
using Alloc = sized_allocator<bool, std::uint16_t, std::int16_t>;
std::vector<bool, Alloc> in(200, false, Alloc(1));
std::vector<bool, Alloc> expected(200, true, Alloc(1));
std::fill(in.begin(), in.end(), true);
assert(in == expected);
}
{
using Alloc = sized_allocator<bool, std::uint32_t, std::int32_t>;
std::vector<bool, Alloc> in(200, false, Alloc(1));
std::vector<bool, Alloc> expected(200, true, Alloc(1));
std::fill(in.begin(), in.end(), true);
assert(in == expected);
}
{
using Alloc = sized_allocator<bool, std::uint64_t, std::int64_t>;
std::vector<bool, Alloc> in(200, false, Alloc(1));
std::vector<bool, Alloc> expected(200, true, Alloc(1));
std::fill(in.begin(), in.end(), true);
assert(in == expected);
}
}
TEST_CONSTEXPR_CXX20 bool test() {
types::for_each(types::forward_iterator_list<char*>(), Test<char>());
types::for_each(types::forward_iterator_list<int*>(), Test<int>());
{ // test vector<bool>::iterator optimization
{ // simple case
std::vector<bool> in(4, false);
std::vector<bool> expected(4, true);
std::fill(in.begin(), in.end(), true);
assert(in == expected);
}
{ // partial byte in the front is not filled
std::vector<bool> in(8, false);
std::vector<bool> expected(8, true);
expected[0] = false;
expected[1] = false;
std::fill(in.begin() + 2, in.end(), true);
assert(in == expected);
}
{ // partial byte in the back is not filled
std::vector<bool> in(8, false);
std::vector<bool> expected(8, true);
expected[6] = false;
expected[7] = false;
std::fill(in.begin(), in.end() - 2, true);
assert(in == expected);
}
{ // partial byte in the front and back is not filled
std::vector<bool> in(16, false);
std::vector<bool> expected(16, true);
expected[0] = false;
expected[1] = false;
expected[14] = false;
expected[15] = false;
std::fill(in.begin() + 2, in.end() - 2, true);
assert(in == expected);
}
{ // only a few bits of a byte are set
std::vector<bool> in(8, false);
std::vector<bool> expected(8, true);
expected[0] = false;
expected[1] = false;
expected[6] = false;
expected[7] = false;
std::fill(in.begin() + 2, in.end() - 2, true);
assert(in == expected);
}
}
test_bititer_with_custom_sized_types();
return true;
}
int main(int, char**) {
test();
#if TEST_STD_VER >= 20
static_assert(test());
#endif
return 0;
}