d05ab119e1
The std::advance function has a clear precondition that it can only be called with a negative distance when a bidirectional iterator is used. However, prev() and next() don't have such preconditions explicitly, they inherit it from calling advance(). This patch removes assertions in prev() and next() that were duplicates of similar ones in advance(), and removes a copy-pasted comment that was trying to justify the use of _LIBCPP_ASSERT_PEDANTIC but IMO is creating confusion with little benefit.
32 lines
1008 B
C++
32 lines
1008 B
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// REQUIRES: has-unix-headers
|
|
// UNSUPPORTED: c++03
|
|
// REQUIRES: libcpp-hardening-mode={{extensive|debug}}
|
|
// XFAIL: libcpp-hardening-mode=debug && availability-verbose_abort-missing
|
|
|
|
// <list>
|
|
|
|
// Call next(non-bidi iterator, -1)
|
|
|
|
#include <iterator>
|
|
|
|
#include "check_assertion.h"
|
|
#include "test_iterators.h"
|
|
|
|
int main(int, char**) {
|
|
int a[] = {1, 2, 3};
|
|
forward_iterator<int *> it(a+1);
|
|
(void)std::next(it, 1); // should work fine
|
|
(void)std::next(it, 0); // should work fine
|
|
TEST_LIBCPP_ASSERT_FAILURE(std::next(it, -1), "Attempt to advance(it, n) with negative n on a non-bidirectional iterator");
|
|
|
|
return 0;
|
|
}
|