
This patch makes the final major change of the RemoveDIs project, changing the default IR output from debug intrinsics to debug records. This is expected to break a large number of tests: every single one that tests for uses or declarations of debug intrinsics and does not explicitly disable writing records. If this patch has broken your downstream tests (or upstream tests on a configuration I wasn't able to run): 1. If you need to immediately unblock a build, pass `--write-experimental-debuginfo=false` to LLVM's option processing for all failing tests (remember to use `-mllvm` for clang/flang to forward arguments to LLVM). 2. For most test failures, the changes are trivial and mechanical, enough that they can be done by script; see the migration guide for a guide on how to do this: https://llvm.org/docs/RemoveDIsDebugInfo.html#test-updates 3. If any tests fail for reasons other than FileCheck check lines that need updating, such as assertion failures, that is most likely a real bug with this patch and should be reported as such. For more information, see the recent PSA: https://discourse.llvm.org/t/psa-ir-output-changing-from-debug-intrinsics-to-debug-records/79578
154 lines
7.4 KiB
LLVM
154 lines
7.4 KiB
LLVM
; RUN: opt -passes='cgscc(inline)' -S %s -o - -S | FileCheck %s --implicit-check-not=dbg.value
|
|
; RUN: opt -passes='cgscc(inline)' -S %s -o - -S --try-experimental-debuginfo-iterators | FileCheck %s --implicit-check-not=dbg.value
|
|
|
|
;; Test that dbg.value intrinsics are inlined, remapped, and have their
|
|
;; dilocation updated just like normal instructions. This becomes
|
|
;; important when debug-info records case to be instructions.
|
|
;;
|
|
;; test should be inlined into test2
|
|
|
|
; CHECK: define i32 @test2
|
|
; CHECK-NEXT: entry:
|
|
; CHECK: %k.addr.i = alloca i32, align 4
|
|
; CHECK: %k2.i = alloca i32, align 4
|
|
; CHECK: %0 = load i32, ptr @global_var, align 4, !dbg !9
|
|
; CHECK: store i32 %0, ptr %k.addr.i, align 4
|
|
; CHECK-NEXT: #dbg_value(ptr %k.addr.i, ![[KVAR:[0-9]+]], !DIExpression(), ![[KLINE:[0-9]+]]
|
|
; CHECK-NEXT: #dbg_value(ptr %k2.i, ![[K2VAR:[0-9]+]], !DIExpression(), ![[GLINE:[0-9]+]]
|
|
; CHECK-NEXT: %1 = load i32, ptr %k.addr.i, align 4,
|
|
;;
|
|
;; dbg.values in this block should be remapped to the local load, but also
|
|
;; the Argument to the calling test2 function.
|
|
;;
|
|
; CHECK: if.then.i:
|
|
; CHECK-NEXT: %3 = load i32, ptr %k2.i,
|
|
; CHECK-NEXT: #dbg_value(i32 %3, ![[KVAR]], !DIExpression(), ![[KLINE]]
|
|
; CHECK-NEXT: #dbg_value(i32 %foo, ![[K2VAR]], !DIExpression(), ![[GLINE]]
|
|
;
|
|
;; Similarly, the end block should retain remapped dbg.values, with the second
|
|
;; referring to the @global_var load in the entry block. Check that we clone
|
|
;; from the terminator correctly.
|
|
;
|
|
; CHECK: if.end.i:
|
|
; CHECK-NEXT: store i32 0, ptr %retval.i, align 4,
|
|
; CHECK-NEXT: #dbg_value(i32 0, ![[KVAR]], !DIExpression(), ![[KLINE]]
|
|
; CHECK-NEXT: #dbg_value(i32 %0, ![[K2VAR]], !DIExpression(), ![[GLINE]]
|
|
; CHECK-NEXT: br label %test.exit,
|
|
;
|
|
;; More or less the same checks again in the exit block, this time at the head
|
|
;; of the block, and on a terminator that gets elided.
|
|
;
|
|
; CHECK: test.exit:
|
|
; CHECK-NEXT: #dbg_value(i32 %0, ![[KVAR]], !DIExpression(), ![[KLINE]]
|
|
; CHECK-NEXT: #dbg_value(i32 %bar, ![[K2VAR]], !DIExpression(), ![[GLINE]]
|
|
; CHECK-NEXT: %4 = load i32, ptr %retval.i, align 4,
|
|
; CHECK-NEXT: #dbg_value(i32 1, ![[KVAR]], !DIExpression(), ![[KLINE]]
|
|
; CHECK-NEXT: #dbg_value(i32 1, ![[K2VAR]], !DIExpression(), ![[GLINE]]
|
|
;
|
|
;
|
|
;; Test that the metadata maps onto the correct things, and that the DILocations
|
|
;; attached to the intrinsics have been inlined.
|
|
;
|
|
; CHECK-DAG: ![[TEST2SP:[0-9]+]] = distinct !DISubprogram(name: "test2",
|
|
; CHECK-DAG: ![[INLINESITEBLOCK:[0-9]+]] = distinct !DILexicalBlock(scope: ![[TEST2SP]],
|
|
; CHECK-DAG: ![[TESTSP:[0-9]+]] = distinct !DISubprogram(name: "test",
|
|
; CHECK-DAG: ![[KVAR]] = !DILocalVariable(name: "k",
|
|
; CHECK-DAG: ![[K2VAR]] = !DILocalVariable(name: "k2",
|
|
; CHECK-DAG: ![[KLINE]] = !DILocation(line: 4, scope: ![[TESTSP]], inlinedAt: ![[INLINESITE:[0-9]+]])
|
|
; CHECK-DAG: ![[INLINESITE]] = distinct !DILocation(line: 14, scope: ![[INLINESITEBLOCK]])
|
|
; CHECK-DAG: ![[GLINE]] = !DILocation(line: 5, scope: ![[TESTSP]], inlinedAt: ![[INLINESITE:[0-9]+]])
|
|
|
|
target triple = "x86_64--"
|
|
|
|
@global_var = external global i32
|
|
|
|
define internal i32 @test(i32 %k, i32 %foo, i32 %bar) !dbg !4 {
|
|
entry:
|
|
%retval = alloca i32, align 4
|
|
%k.addr = alloca i32, align 4
|
|
%k2 = alloca i32, align 4
|
|
store i32 %k, ptr %k.addr, align 4
|
|
call void @llvm.dbg.value(metadata ptr %k.addr, metadata !13, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata ptr %k2, metadata !15, metadata !DIExpression()), !dbg !16
|
|
%0 = load i32, ptr %k.addr, align 4, !dbg !16
|
|
%call = call i32 @_Z8test_exti(i32 %0), !dbg !16
|
|
store i32 %call, ptr %k2, align 4, !dbg !16
|
|
%1 = load i32, ptr %k2, align 4, !dbg !17
|
|
%cmp = icmp sgt i32 %1, 100, !dbg !17
|
|
br i1 %cmp, label %if.then, label %if.end, !dbg !17
|
|
|
|
if.then: ; preds = %entry
|
|
%2 = load i32, ptr %k2, align 4, !dbg !18
|
|
call void @llvm.dbg.value(metadata i32 %2, metadata !13, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata i32 %foo, metadata !15, metadata !DIExpression()), !dbg !16
|
|
store i32 %2, ptr %retval, !dbg !18
|
|
br label %return, !dbg !18
|
|
|
|
if.end: ; preds = %entry
|
|
store i32 0, ptr %retval, !dbg !19
|
|
call void @llvm.dbg.value(metadata i32 0, metadata !13, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata i32 %k, metadata !15, metadata !DIExpression()), !dbg !16
|
|
br label %return, !dbg !19
|
|
|
|
return: ; preds = %if.end, %if.then
|
|
call void @llvm.dbg.value(metadata i32 %k, metadata !13, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata i32 %bar, metadata !15, metadata !DIExpression()), !dbg !16
|
|
%3 = load i32, ptr %retval, !dbg !20
|
|
call void @llvm.dbg.value(metadata i32 1, metadata !13, metadata !DIExpression()), !dbg !14
|
|
call void @llvm.dbg.value(metadata i32 1, metadata !15, metadata !DIExpression()), !dbg !16
|
|
ret i32 %3, !dbg !20
|
|
}
|
|
|
|
declare i32 @_Z8test_exti(i32)
|
|
|
|
define i32 @test2(i32 %foo, i32 %bar) !dbg !10 {
|
|
entry:
|
|
%exn.slot = alloca ptr
|
|
%ehselector.slot = alloca i32
|
|
%e = alloca i32, align 4
|
|
%0 = load i32, ptr @global_var, align 4, !dbg !21
|
|
%call = call i32 @test(i32 %0, i32 %foo, i32 %bar), !dbg !21
|
|
br label %try.cont, !dbg !23
|
|
|
|
try.cont: ; preds = %catch, %invoke.cont
|
|
store i32 1, ptr @global_var, align 4, !dbg !29
|
|
ret i32 0, !dbg !30
|
|
}
|
|
|
|
declare void @llvm.dbg.value(metadata, metadata, metadata) #1
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!31}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, producer: "clang version 3.3 ", isOptimized: false, emissionKind: FullDebug, file: !1, enums: !2, retainedTypes: !2, globals: !2, imports: !2)
|
|
!1 = !DIFile(filename: "<unknown>", directory: "")
|
|
!2 = !{}
|
|
!4 = distinct !DISubprogram(name: "test", linkageName: "_Z4testi", line: 4, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, unit: !0, scopeLine: 4, file: !5, scope: !6, type: !7, retainedNodes: !2)
|
|
!5 = !DIFile(filename: "test.cpp", directory: "")
|
|
!6 = !DIFile(filename: "test.cpp", directory: "")
|
|
!7 = !DISubroutineType(types: !8)
|
|
!8 = !{!9, !9}
|
|
!9 = !DIBasicType(tag: DW_TAG_base_type, name: "int", size: 32, align: 32, encoding: DW_ATE_signed)
|
|
!10 = distinct !DISubprogram(name: "test2", linkageName: "_Z5test2v", line: 11, isLocal: false, isDefinition: true, virtualIndex: 6, flags: DIFlagPrototyped, isOptimized: false, unit: !0, scopeLine: 11, file: !5, scope: !6, type: !11, retainedNodes: !2)
|
|
!11 = !DISubroutineType(types: !12)
|
|
!12 = !{!9}
|
|
!13 = !DILocalVariable(name: "k", line: 4, arg: 1, scope: !4, file: !6, type: !9)
|
|
!14 = !DILocation(line: 4, scope: !4)
|
|
!15 = !DILocalVariable(name: "k2", line: 5, scope: !4, file: !6, type: !9)
|
|
!16 = !DILocation(line: 5, scope: !4)
|
|
!17 = !DILocation(line: 6, scope: !4)
|
|
!18 = !DILocation(line: 7, scope: !4)
|
|
!19 = !DILocation(line: 8, scope: !4)
|
|
!20 = !DILocation(line: 9, scope: !4)
|
|
!21 = !DILocation(line: 14, scope: !22)
|
|
!22 = distinct !DILexicalBlock(line: 13, column: 0, file: !5, scope: !10)
|
|
!23 = !DILocation(line: 15, scope: !22)
|
|
!24 = !DILocalVariable(name: "e", line: 16, scope: !10, file: !6, type: !9)
|
|
!25 = !DILocation(line: 16, scope: !10)
|
|
!26 = !DILocation(line: 17, scope: !27)
|
|
!27 = distinct !DILexicalBlock(line: 16, column: 0, file: !5, scope: !10)
|
|
!28 = !DILocation(line: 18, scope: !27)
|
|
!29 = !DILocation(line: 19, scope: !10)
|
|
!30 = !DILocation(line: 20, scope: !10)
|
|
!31 = !{i32 1, !"Debug Info Version", i32 3}
|