00809c8889
Currently version script patterns are ignored for .symver produced
non-default version (single @) symbols. This makes such symbols
not localizable by `local:`, e.g.
```
.symver foo3_v1,foo3@v1
.globl foo_v1
foo3_v1:
ld.lld --version-script=a.ver -shared a.o
```
This patch adds the support:
* Move `config->versionDefinitions[VER_NDX_LOCAL].patterns` to `config->versionDefinitions[versionId].localPatterns`
* Rename `config->versionDefinitions[versionId].patterns` to `config->versionDefinitions[versionId].nonLocalPatterns`
* Allow `findAllByVersion` to find non-default version symbols when `includeNonDefault` is true. (Note: `symtab` keys do not have `@@`)
* Make each pattern check both the unversioned `pat.name` and the versioned `${pat.name}@${v.name}`
* `localPatterns` can localize `${pat.name}@${v.name}`. `nonLocalPatterns` can prevent localization by assigning `verdefIndex` (before `parseSymbolVersion`).
---
If a user notices new `undefined symbol` errors with a version script containing
`local: *;`, the issue is likely due to a missing `global:` pattern.
Reviewed By: peter.smith
Differential Revision: https://reviews.llvm.org/D107234
46 lines
1.8 KiB
ArmAsm
46 lines
1.8 KiB
ArmAsm
# REQUIRES: x86
|
|
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64 %s -o %t.o
|
|
|
|
# RUN: echo 'v1 { local: extern "C++" { "foo1()"; "foo3(int)"; }; }; v2 { local: extern "C++" { "foo2()"; "foo4(int)"; }; };' > %t1.script
|
|
# RUN: ld.lld --version-script %t1.script -shared %t.o -o %t1.so
|
|
# RUN: llvm-readelf --dyn-syms %t1.so | FileCheck --check-prefix=EXACT %s
|
|
# EXACT: UND
|
|
# EXACT-NEXT: [[#]] _start{{$}}
|
|
# EXACT-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { global: *; local: extern "C++" {foo*;}; }; v2 { global: extern "C++" {"foo2()";}; };' > %t2.script
|
|
# RUN: ld.lld --version-script %t2.script -shared %t.o -o %t2.so
|
|
# RUN: llvm-readelf --dyn-syms %t2.so | FileCheck --check-prefix=MIX1 %s
|
|
# MIX1: UND
|
|
# MIX1-NEXT: [[#]] _Z4foo2v@@v2
|
|
# MIX1-NEXT: [[#]] _start@@v1
|
|
# MIX1-NEXT: [[#]] _Z4foo4i@@v2
|
|
# MIX1-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { local: extern "C++" {foo*;}; }; v2 { global: extern "C++" {"foo2()";}; };' > %t3.script
|
|
# RUN: ld.lld --version-script %t3.script -shared %t.o -o %t3.so
|
|
# RUN: llvm-readelf --dyn-syms %t3.so | FileCheck --check-prefix=MIX2 %s
|
|
# MIX2: UND
|
|
# MIX2-NEXT: [[#]] _Z4foo2v@@v2
|
|
# MIX2-NEXT: [[#]] _start{{$}}
|
|
# MIX2-NEXT: [[#]] _Z4foo4i@@v2
|
|
# MIX2-NOT: {{.}}
|
|
|
|
# RUN: echo 'v1 { global: extern "C++" {foo*;}; local: *; }; v2 { global: extern "C++" {"foo4(int)";}; local: *; };' > %t4.script
|
|
# RUN: ld.lld --version-script %t4.script -shared %t.o -o %t4.so
|
|
# RUN: llvm-readelf --dyn-syms %t4.so | FileCheck --check-prefix=MIX3 %s
|
|
# MIX3: UND
|
|
# MIX3-NEXT: [[#]] _Z4foo1v@@v1
|
|
# MIX3-NEXT: [[#]] _Z4foo2v@@v1
|
|
# MIX3-NEXT: [[#]] _Z4foo3i@v1
|
|
# MIX3-NEXT: [[#]] _Z4foo4i@@v2
|
|
# MIX3-NOT: {{.}}
|
|
|
|
.globl _Z4foo1v; _Z4foo1v: ret
|
|
.globl _Z4foo2v; _Z4foo2v: ret
|
|
.globl _Z4foo3i; .symver _Z4foo3i,_Z4foo3i@v1,remove; _Z4foo3i: ret
|
|
.globl _Z4foo4i; .symver _Z4foo4i,_Z4foo4i@@@v2; _Z4foo4i: ret
|
|
|
|
.globl _start; _start: ret
|