d9ab3e82f3
This avoids recomputing string length that is already known at compile time. It has a slight impact on preprocessing / compile time, see https://llvm-compile-time-tracker.com/compare.php?from=3f36d2d579d8b0e8824d9dd99bfa79f456858f88&to=e49640c507ddc6615b5e503144301c8e41f8f434&stat=instructions:u This a recommit of e953ae5bbc313fd0cc980ce021d487e5b5199ea4 and the subsequent fixes caa713559bd38f337d7d35de35686775e8fb5175 and 06b90e2e9c991e211fecc97948e533320a825470. The above patchset caused some version of GCC to take eons to compile clang/lib/Basic/Targets/AArch64.cpp, as spotted in aa171833ab0017d9732e82b8682c9848ab25ff9e. The fix is to make BuiltinInfo tables a compilation unit static variable, instead of a private static variable. Differential Revision: https://reviews.llvm.org/D139881
59 lines
1.9 KiB
C++
59 lines
1.9 KiB
C++
//===--- DriverOptions.cpp - Driver Options Table -------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Driver/Options.h"
|
|
#include "llvm/ADT/STLExtras.h"
|
|
#include "llvm/Option/OptTable.h"
|
|
#include "llvm/Option/Option.h"
|
|
#include <cassert>
|
|
|
|
using namespace clang::driver;
|
|
using namespace clang::driver::options;
|
|
using namespace llvm::opt;
|
|
|
|
#define PREFIX(NAME, VALUE) \
|
|
static constexpr llvm::StringLiteral NAME##_init[] = VALUE; \
|
|
static constexpr llvm::ArrayRef<llvm::StringLiteral> NAME( \
|
|
NAME##_init, std::size(NAME##_init) - 1);
|
|
#include "clang/Driver/Options.inc"
|
|
#undef PREFIX
|
|
|
|
static constexpr OptTable::Info InfoTable[] = {
|
|
#define OPTION(PREFIX, NAME, ID, KIND, GROUP, ALIAS, ALIASARGS, FLAGS, PARAM, \
|
|
HELPTEXT, METAVAR, VALUES) \
|
|
{PREFIX, NAME, HELPTEXT, METAVAR, OPT_##ID, Option::KIND##Class, \
|
|
PARAM, FLAGS, OPT_##GROUP, OPT_##ALIAS, ALIASARGS, VALUES},
|
|
#include "clang/Driver/Options.inc"
|
|
#undef OPTION
|
|
};
|
|
|
|
namespace {
|
|
|
|
class DriverOptTable : public OptTable {
|
|
public:
|
|
DriverOptTable()
|
|
: OptTable(InfoTable) {}
|
|
};
|
|
|
|
}
|
|
|
|
const llvm::opt::OptTable &clang::driver::getDriverOptTable() {
|
|
static const DriverOptTable *Table = []() {
|
|
auto Result = std::make_unique<DriverOptTable>();
|
|
// Options.inc is included in DriverOptions.cpp, and calls OptTable's
|
|
// addValues function.
|
|
// Opt is a variable used in the code fragment in Options.inc.
|
|
OptTable &Opt = *Result;
|
|
#define OPTTABLE_ARG_INIT
|
|
#include "clang/Driver/Options.inc"
|
|
#undef OPTTABLE_ARG_INIT
|
|
return Result.release();
|
|
}();
|
|
return *Table;
|
|
}
|