llvm-project/clang/unittests/StaticAnalyzer/BugReportInterestingnessTest.cpp
serge-sans-paille d9ab3e82f3
[clang] Use a StringRef instead of a raw char pointer to store builtin and call information
This avoids recomputing string length that is already known at compile time.

It has a slight impact on preprocessing / compile time, see

https://llvm-compile-time-tracker.com/compare.php?from=3f36d2d579d8b0e8824d9dd99bfa79f456858f88&to=e49640c507ddc6615b5e503144301c8e41f8f434&stat=instructions:u

This a recommit of e953ae5bbc313fd0cc980ce021d487e5b5199ea4 and the subsequent fixes caa713559bd38f337d7d35de35686775e8fb5175 and 06b90e2e9c991e211fecc97948e533320a825470.

The above patchset caused some version of GCC to take eons to compile clang/lib/Basic/Targets/AArch64.cpp, as spotted in aa171833ab0017d9732e82b8682c9848ab25ff9e.
The fix is to make BuiltinInfo tables a compilation unit static variable, instead of a private static variable.

Differential Revision: https://reviews.llvm.org/D139881
2022-12-27 09:55:19 +01:00

164 lines
5.5 KiB
C++

//===----------------------------------------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "Reusables.h"
#include "clang/Frontend/CompilerInstance.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
#include "clang/StaticAnalyzer/Core/Checker.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
#include "clang/StaticAnalyzer/Frontend/AnalysisConsumer.h"
#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h"
#include "clang/Tooling/Tooling.h"
#include "gtest/gtest.h"
using namespace clang;
using namespace ento;
using namespace llvm;
namespace {
class InterestingnessTestChecker : public Checker<check::PreCall> {
BugType BT_TestBug;
using HandlerFn = std::function<void(const InterestingnessTestChecker *,
const CallEvent &, CheckerContext &)>;
CallDescriptionMap<HandlerFn> Handlers = {
{{{"setInteresting"}, 1}, &InterestingnessTestChecker::handleInteresting},
{{{"setNotInteresting"}, 1},
&InterestingnessTestChecker::handleNotInteresting},
{{{"check"}, 1}, &InterestingnessTestChecker::handleCheck},
{{{"bug"}, 1}, &InterestingnessTestChecker::handleBug},
};
void handleInteresting(const CallEvent &Call, CheckerContext &C) const;
void handleNotInteresting(const CallEvent &Call, CheckerContext &C) const;
void handleCheck(const CallEvent &Call, CheckerContext &C) const;
void handleBug(const CallEvent &Call, CheckerContext &C) const;
public:
InterestingnessTestChecker()
: BT_TestBug(this, "InterestingnessTestBug", "Test") {}
void checkPreCall(const CallEvent &Call, CheckerContext &C) const {
const HandlerFn *Handler = Handlers.lookup(Call);
if (!Handler)
return;
(*Handler)(this, Call, C);
}
};
} // namespace
void InterestingnessTestChecker::handleInteresting(const CallEvent &Call,
CheckerContext &C) const {
SymbolRef Sym = Call.getArgSVal(0).getAsSymbol();
assert(Sym);
C.addTransition(nullptr, C.getNoteTag([Sym](PathSensitiveBugReport &BR) {
BR.markInteresting(Sym);
return "";
}));
}
void InterestingnessTestChecker::handleNotInteresting(const CallEvent &Call,
CheckerContext &C) const {
SymbolRef Sym = Call.getArgSVal(0).getAsSymbol();
assert(Sym);
C.addTransition(nullptr, C.getNoteTag([Sym](PathSensitiveBugReport &BR) {
BR.markNotInteresting(Sym);
return "";
}));
}
void InterestingnessTestChecker::handleCheck(const CallEvent &Call,
CheckerContext &C) const {
SymbolRef Sym = Call.getArgSVal(0).getAsSymbol();
assert(Sym);
C.addTransition(nullptr, C.getNoteTag([Sym](PathSensitiveBugReport &BR) {
if (BR.isInteresting(Sym))
return "Interesting";
else
return "NotInteresting";
}));
}
void InterestingnessTestChecker::handleBug(const CallEvent &Call,
CheckerContext &C) const {
ExplodedNode *N = C.generateErrorNode();
C.emitReport(
std::make_unique<PathSensitiveBugReport>(BT_TestBug, "test bug", N));
}
namespace {
class TestAction : public ASTFrontendAction {
ExpectedDiagsTy ExpectedDiags;
public:
TestAction(ExpectedDiagsTy &&ExpectedDiags)
: ExpectedDiags(std::move(ExpectedDiags)) {}
std::unique_ptr<ASTConsumer> CreateASTConsumer(CompilerInstance &Compiler,
StringRef File) override {
std::unique_ptr<AnalysisASTConsumer> AnalysisConsumer =
CreateAnalysisConsumer(Compiler);
AnalysisConsumer->AddDiagnosticConsumer(new VerifyPathDiagnosticConsumer(
std::move(ExpectedDiags), Compiler.getSourceManager()));
AnalysisConsumer->AddCheckerRegistrationFn([](CheckerRegistry &Registry) {
Registry.addChecker<InterestingnessTestChecker>("test.Interestingness",
"Description", "");
});
Compiler.getAnalyzerOpts()->CheckersAndPackages = {
{"test.Interestingness", true}};
return std::move(AnalysisConsumer);
}
};
} // namespace
TEST(BugReportInterestingness, Symbols) {
EXPECT_TRUE(tooling::runToolOnCode(
std::make_unique<TestAction>(ExpectedDiagsTy{
{{15, 7},
"test bug",
"test bug",
"test.Interestingness",
"InterestingnessTestBug",
"Test",
{
{{8, 7}, "Interesting", {{{8, 7}, {8, 14}}}},
{{10, 7}, "NotInteresting", {{{10, 7}, {10, 14}}}},
{{12, 7}, "Interesting", {{{12, 7}, {12, 14}}}},
{{14, 7}, "NotInteresting", {{{14, 7}, {14, 14}}}},
{{15, 7}, "test bug", {{{15, 7}, {15, 12}}}},
}}}),
R"(
void setInteresting(int);
void setNotInteresting(int);
void check(int);
void bug(int);
void f(int A) {
check(A);
setInteresting(A);
check(A);
setNotInteresting(A);
check(A);
setInteresting(A);
check(A);
bug(A);
}
)",
"input.cpp"));
}