da3658e2b7
ASTMatchers currently have problems mixing bound TypeLoc nodes with Decl/Stmt
nodes. That should be fixed soon but for this checker there we only need the
TypeLoc to generate a fixit so postpone the potentially heavyweight AST walking
until after we know that we're going to emit a warning.
This is covered by existing test cases.
Original message:
[clang-tidy] Add a check for RAII temporaries.
This tries to find code similar that immediately destroys
an object that looks like it's trying to follow RAII.
{
scoped_lock(&global_mutex);
critical_section();
}
This checker will have false positives if someone uses this pattern
to legitimately invoke a destructor immediately (or the statement is
at the end of a scope anyway). To reduce the number we ignore this
pattern in macros (this is heavily used by gtest) and ignore objects
with no user-defined destructor.
llvm-svn: 213738
57 lines
1.9 KiB
C++
57 lines
1.9 KiB
C++
//===--- MiscTidyModule.cpp - clang-tidy ----------------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../ClangTidy.h"
|
|
#include "../ClangTidyModule.h"
|
|
#include "../ClangTidyModuleRegistry.h"
|
|
#include "ArgumentCommentCheck.h"
|
|
#include "BoolPointerImplicitConversion.h"
|
|
#include "RedundantSmartptrGet.h"
|
|
#include "SwappedArgumentsCheck.h"
|
|
#include "UnusedRAII.h"
|
|
#include "UseOverride.h"
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
|
|
class MiscModule : public ClangTidyModule {
|
|
public:
|
|
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
|
|
CheckFactories.addCheckFactory(
|
|
"misc-argument-comment",
|
|
new ClangTidyCheckFactory<ArgumentCommentCheck>());
|
|
CheckFactories.addCheckFactory(
|
|
"misc-bool-pointer-implicit-conversion",
|
|
new ClangTidyCheckFactory<BoolPointerImplicitConversion>());
|
|
CheckFactories.addCheckFactory(
|
|
"misc-redundant-smartptr-get",
|
|
new ClangTidyCheckFactory<RedundantSmartptrGet>());
|
|
CheckFactories.addCheckFactory(
|
|
"misc-swapped-arguments",
|
|
new ClangTidyCheckFactory<SwappedArgumentsCheck>());
|
|
CheckFactories.addCheckFactory(
|
|
"misc-unused-raii",
|
|
new ClangTidyCheckFactory<UnusedRAIICheck>());
|
|
CheckFactories.addCheckFactory(
|
|
"misc-use-override",
|
|
new ClangTidyCheckFactory<UseOverride>());
|
|
}
|
|
};
|
|
|
|
// Register the MiscTidyModule using this statically initialized variable.
|
|
static ClangTidyModuleRegistry::Add<MiscModule>
|
|
X("misc-module", "Adds miscellaneous lint checks.");
|
|
|
|
// This anchor is used to force the linker to link in the generated object file
|
|
// and thus register the MiscModule.
|
|
volatile int MiscModuleAnchorSource = 0;
|
|
|
|
} // namespace tidy
|
|
} // namespace clang
|