bec5cfd970
Protect the various SetBreakpoint functions with the API mutex. This fixes a race condition between the breakpoint being created and the DAP label getting added. This was causing `TestDAP_breakpointEvents.py` to be flaky. Fixes #131242.
89 lines
3.0 KiB
C++
89 lines
3.0 KiB
C++
//===-- Breakpoint.cpp ----------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Breakpoint.h"
|
|
#include "DAP.h"
|
|
#include "JSONUtils.h"
|
|
#include "lldb/API/SBAddress.h"
|
|
#include "lldb/API/SBBreakpointLocation.h"
|
|
#include "lldb/API/SBLineEntry.h"
|
|
#include "lldb/API/SBMutex.h"
|
|
#include "llvm/ADT/StringExtras.h"
|
|
#include "llvm/Support/JSON.h"
|
|
#include <cstddef>
|
|
#include <cstdint>
|
|
#include <mutex>
|
|
#include <string>
|
|
|
|
using namespace lldb_dap;
|
|
|
|
void Breakpoint::SetCondition() { m_bp.SetCondition(m_condition.c_str()); }
|
|
|
|
void Breakpoint::SetHitCondition() {
|
|
uint64_t hitCount = 0;
|
|
if (llvm::to_integer(m_hit_condition, hitCount))
|
|
m_bp.SetIgnoreCount(hitCount - 1);
|
|
}
|
|
|
|
void Breakpoint::CreateJsonObject(llvm::json::Object &object) {
|
|
// Each breakpoint location is treated as a separate breakpoint for VS code.
|
|
// They don't have the notion of a single breakpoint with multiple locations.
|
|
if (!m_bp.IsValid())
|
|
return;
|
|
object.try_emplace("verified", m_bp.GetNumResolvedLocations() > 0);
|
|
object.try_emplace("id", m_bp.GetID());
|
|
// VS Code DAP doesn't currently allow one breakpoint to have multiple
|
|
// locations so we just report the first one. If we report all locations
|
|
// then the IDE starts showing the wrong line numbers and locations for
|
|
// other source file and line breakpoints in the same file.
|
|
|
|
// Below we search for the first resolved location in a breakpoint and report
|
|
// this as the breakpoint location since it will have a complete location
|
|
// that is at least loaded in the current process.
|
|
lldb::SBBreakpointLocation bp_loc;
|
|
const auto num_locs = m_bp.GetNumLocations();
|
|
for (size_t i = 0; i < num_locs; ++i) {
|
|
bp_loc = m_bp.GetLocationAtIndex(i);
|
|
if (bp_loc.IsResolved())
|
|
break;
|
|
}
|
|
// If not locations are resolved, use the first location.
|
|
if (!bp_loc.IsResolved())
|
|
bp_loc = m_bp.GetLocationAtIndex(0);
|
|
auto bp_addr = bp_loc.GetAddress();
|
|
|
|
if (bp_addr.IsValid()) {
|
|
std::string formatted_addr =
|
|
"0x" + llvm::utohexstr(bp_addr.GetLoadAddress(m_bp.GetTarget()));
|
|
object.try_emplace("instructionReference", formatted_addr);
|
|
auto line_entry = bp_addr.GetLineEntry();
|
|
const auto line = line_entry.GetLine();
|
|
if (line != UINT32_MAX)
|
|
object.try_emplace("line", line);
|
|
const auto column = line_entry.GetColumn();
|
|
if (column != 0)
|
|
object.try_emplace("column", column);
|
|
object.try_emplace("source", CreateSource(line_entry));
|
|
}
|
|
}
|
|
|
|
bool Breakpoint::MatchesName(const char *name) {
|
|
return m_bp.MatchesName(name);
|
|
}
|
|
|
|
void Breakpoint::SetBreakpoint() {
|
|
lldb::SBMutex lock = m_dap.GetAPIMutex();
|
|
std::lock_guard<lldb::SBMutex> guard(lock);
|
|
|
|
m_bp.AddName(kDAPBreakpointLabel);
|
|
if (!m_condition.empty())
|
|
SetCondition();
|
|
if (!m_hit_condition.empty())
|
|
SetHitCondition();
|
|
}
|